<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123809/">https://git.reviewboard.kde.org/r/123809/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 16th, 2015, 6:44 p.m. MSK, <b>Philipp A.</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">i’m also against this. i’ve dived a bit into color theory, and if the algorithm to choose the set of colors isn’t named, there’s not much to argue for it.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">i think we want a qualitative color palette, and shhould choose a way to generate easily distinguishable colors.</p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">http://stanford.edu/~mwaskom/software/seaborn/tutorial/color_palettes.html</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">http://colorbrewer2.org/?type=qualitative&scheme=Paired&n=12</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">http://datavisualization.ch/inside/how-we-created-color-scales/</li>
</ul></pre>
</blockquote>
<p>On May 17th, 2015, 1:14 p.m. MSK, <b>Sergey Kalinichev</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">i’m also against this. i’ve dived a bit into color theory, and if the algorithm to choose the set of colors isn’t named, there’s not much to argue for it.</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">See my previous comment.</p>
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">i think we want a qualitative color palette, and should choose a way to generate easily distinguishable colors.</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I took a quick look at the links that you provided, but couldn't find a set of 30-35 distinguishable colors or an algorithm to generate it. Seems like all those links about generating 10-15 colors which is hardly enough.</p></pre>
</blockquote>
<p>On May 17th, 2015, 1:19 p.m. MSK, <b>Philipp A.</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">then how about <a href="http://tools.medialab.sciences-po.fr/iwanthue/" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">this</a>?</p></pre>
</blockquote>
<p>On May 17th, 2015, 1:31 p.m. MSK, <b>Philipp A.</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">just play with the sliders and keep in mind:</p>
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If you produce too many colors, you will still be able to use the first colors, since they will be distinct. </p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">so we can create 100 colors and they will simply become less distinguishable the more variables there are, but stay distinguishable.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">we’ll want to leave out very low & very high brightness (“white” and “black”), as well as very low chroma (gray):</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">so maybe (all hues) chroma ? [0.2, 3] and lightness ? [0.1, 1.4]</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">for 100 colors, you’ll also need the force vector setting.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">also we can eventually do this algorithmically in kdevelop, not on the website.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ok, thanks for the link, I'll see what I can do.</p></pre>
<br />
<p>- Sergey</p>
<br />
<p>On May 16th, 2015, 11:07 a.m. MSK, Sergey Kalinichev wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Sergey Kalinichev.</div>
<p style="color: grey;"><i>Updated May 16, 2015, 11:07 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This fixes 2 issues:
*Currently rainbow highlighting only works for the first 10 declarations in Function and Other contexts. All other declarations get highlighted with the default color.
*The current interpolation algorithm is very poor, it can generate only about 10 different colors, all other look alike.
So this patch adds ~35 distinguishable colors, which should be more than enough for most cases.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>language/highlighting/colorcache.cpp <span style="color: grey">(e2729f2)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123809/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/05/16/2fb289f0-69d8-4817-bf0d-d1691c98d3c1__test_highl_b.png">Before</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/05/16/7bcdb744-e47f-435b-a02e-d0ad35b4a59e__test_highl_a.png">After</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/05/16/b67be6b5-b4bf-4d74-8ed9-206e897daa14__test_highl_adark.png">After (dark)</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>