<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123741/">https://git.reviewboard.kde.org/r/123741/</a>
     </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
 <br />









<p>- Kevin Funk</p>


<br />
<p>On May 16th, 2015, 3:51 p.m. UTC, Laurent Navet wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
 <tr>
  <td>

<div>Review request for KDevelop.</div>
<div>By Laurent Navet.</div>


<p style="color: grey;"><i>Updated May 16, 2015, 3:51 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdev-qmake
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">KDebug is deprecated, use QDebug, also remove calls to KBacktrace</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes.</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>parser/buildastvisitor.cpp <span style="color: grey">(202f4ba)</span></li>

 <li>parser/main.cpp <span style="color: grey">(720ed33)</span></li>

 <li>parser/qmake.g <span style="color: grey">(ce87992)</span></li>

 <li>parser/qmakedebugvisitor.cpp <span style="color: grey">(b98281d)</span></li>

 <li>parser/qmakedriver.cpp <span style="color: grey">(3542715)</span></li>

 <li>parser/tests/CMakeLists.txt <span style="color: grey">(dc8e692)</span></li>

 <li>qmakebuilddirchooser.cpp <span style="color: grey">(d1dbc25)</span></li>

 <li>qmakebuilddirchooserdialog.cpp <span style="color: grey">(eff28a8)</span></li>

 <li>qmakebuilder/CMakeLists.txt <span style="color: grey">(7e1d7e2)</span></li>

 <li>qmakebuilder/qmakebuilder.cpp <span style="color: grey">(83fdebe)</span></li>

 <li>qmakebuilder/qmakebuilderdebug.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakebuilder/qmakebuilderdebug.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakebuilder/qmakebuilderpreferences.cpp <span style="color: grey">(d4c3de9)</span></li>

 <li>qmakeconfig.cpp <span style="color: grey">(e20bec8)</span></li>

 <li>qmakefile.cpp <span style="color: grey">(2107524)</span></li>

 <li>qmakefilevisitor.cpp <span style="color: grey">(f04bf1f)</span></li>

 <li>qmakejob.cpp <span style="color: grey">(469b250)</span></li>

 <li>qmakemanager.cpp <span style="color: grey">(f93656c)</span></li>

 <li>qmakeprojectfile.cpp <span style="color: grey">(a2831e4)</span></li>

 <li>tests/CMakeLists.txt <span style="color: grey">(48f1b99)</span></li>

 <li>tests/test_qmakeproject.cpp <span style="color: grey">(3b7cdd7)</span></li>

 <li>variablereferenceparser.cpp <span style="color: grey">(941416f)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/123741/diff/" style="margin-left: 3em;">View Diff</a></p>






  </td>
 </tr>
</table>







  </div>
 </body>
</html>