<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122658/">https://git.reviewboard.kde.org/r/122658/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 15th, 2015, 9:14 vorm. UTC, <b>Kevin Funk</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Heya, one issue remains: For me, there is just a clang-format-3.x binary available. So just invoking 'clang-format' (silently) fails.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Maybe you have ideas how to better deal with this situation?</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Sorry for the late reply, hadn't much time recently.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I actually don't have a satisfying solution for this issue, due to different reasons. First I'm not even closely familiar with Qt, KDELibs or Kdevplatforms, so I unfortunately don't know, which way would be the best to implement either the notice, that the executable is missing, or a search and selection of a proper executable. Any thoughts on that?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Second if you haven't installed e.g. GNU indent, formattors based on this also fails silently. But yeah it's slightly different, because it's not obvious, that you need a clang-format executable instead of a clang-format-x.y executable. I just realized, that my Debian also misses this link and I have created it manually. Personally, I think, that this is a bug in packaging clang-format. But I can understand this, as clang-format has been changed a lot since version 3.2. While 3.2 not even had the option "-style=file", the recognized keywords in the .clang-format files differs from version to version. This being said, even if I could write the code to search for possible instances of clang-format, I couldn't come up with a strategy to choose one, in case there are found several different versions, as I can't know, which version should be used for the intended .clang-format file.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I still have the feeling, that this patch can be useful, if we add some sort of error message.</p></pre>
<br />
<p>- Mario</p>
<br />
<p>On April 10th, 2015, 9:07 nachm. UTC, Mario Bielert wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Mario Bielert.</div>
<p style="color: grey;"><i>Updated April 10, 2015, 9:07 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevelop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch adds ClangFormat as a predefinded style to customscript_plugin formatter</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Not much testing required, as it's just a few lines adding the command line and a name.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>formatters/customscript/customscript_plugin.cpp <span style="color: grey">(8e2e6bb)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122658/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>