<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123133/">https://git.reviewboard.kde.org/r/123133/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/123133/diff/1/?file=356620#file356620line109" style="color: black; font-weight: bold; text-decoration: underline;">CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">101</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">install</span><span class="p">(</span><span class="s">TARGETS</span> <span class="s">kdevpythonlanguagesupport</span> <span class="s">DESTINATION</span> <span class="o">${</span><span class="nv">PLUGIN_INSTALL_DIR</span><span class="o">}</span><span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">108</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">install</span><span class="p">(</span><span class="s">TARGETS</span> <span class="s">kdevpythonlanguagesupport</span> <span class="s">DESTINATION</span> <span class="o">${</span><span class="nv">PLUGIN_INSTALL_DIR</span><span class="o">}</span><span class="s"><span class="hl">/kdevplatform/</span></span><span class="o"><span class="hl">${</span></span><span class="nv"><span class="hl">KDEV_PLUGIN_VERSION</span></span><span class="o"><span class="hl">}</span></span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Isn't this already done by kdevplatform_add_plugin ?</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/123133/diff/1/?file=356621#file356621line39" style="color: black; font-weight: bold; text-decoration: underline;">debugger/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">38</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">install</span><span class="p">(</span><span class="s">TARGETS</span> <span class="s">kdevpdb</span> <span class="s">DESTINATION</span> <span class="o">${</span><span class="nv">PLUGIN_INSTALL_DIR</span><span class="o">}</span><span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">39</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">install</span><span class="p">(</span><span class="s">TARGETS</span> <span class="s">kdevpdb</span> <span class="s">DESTINATION</span> <span class="o">${</span><span class="nv">PLUGIN_INSTALL_DIR</span><span class="o">}</span><span class="s"><span class="hl">/kdevplatform/</span></span><span class="o"><span class="hl">${</span></span><span class="nv"><span class="hl">KDEV_PLUGIN_VERSION</span></span><span class="o"><span class="hl">}</span></span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">same here</p></pre>
</div>
</div>
<br />
<p>- Laurent Navet</p>
<br />
<p>On March 26th, 2015, 12:34 a.m. CET, Alex Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop and Sven Brauch.</div>
<div>By Alex Richardson.</div>
<p style="color: grey;"><i>Updated March 26, 2015, 12:34 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdev-python
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Port PEP8 KCM to new config page architecture
Port Python documentation KCM to new config page architecture</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(1d49fe98ae8d91bbb3f3c816f093d2b77c1c37e8)</span></li>
<li>debugger/CMakeLists.txt <span style="color: grey">(9b84a9238aaa25cbb36d3850667ecc478992ad2f)</span></li>
<li>debugger/kdevpdb.desktop <span style="color: grey">(761ab468d78e7e5a38e29af65266d76290bc04e7)</span></li>
<li>debugger/kdevpdb.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>debugger/pdbdebuggerplugin.cpp <span style="color: grey">(6ad9f2e29d49d2f0afaa5984ee1b5c8b65725c0a)</span></li>
<li>docfilekcm/CMakeLists.txt <span style="color: grey">(84e584cb57daf9893b2fa3e5815a38119c77a16a)</span></li>
<li>docfilekcm/kcm_docfiles.h <span style="color: grey">(317885e80d67bc3e7c7ebefffbd2b693661f4b20)</span></li>
<li>docfilekcm/kcm_docfiles.cpp <span style="color: grey">(60da38deb3c8cdb18f69bfa8d7be6972229b376e)</span></li>
<li>docfilekcm/kcm_kdevpythondocfiles.desktop <span style="color: grey">(8bcf68c5f3b7d3b285a3b0413fb52d00117fb13c)</span></li>
<li>kdevpythonsupport.desktop.cmake <span style="color: grey">(8e83a1f20ea734b84af96059bb05560795d2514d)</span></li>
<li>kdevpythonsupport.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>pep8kcm/CMakeLists.txt <span style="color: grey">(807a7509a1a962085db5ef08e692d4828818138f)</span></li>
<li>pep8kcm/kcm_kdevpythonpep8.desktop <span style="color: grey">(2d316f055177bcb1bad9dd3db126357fe7038648)</span></li>
<li>pep8kcm/kcm_pep8.h <span style="color: grey">(24d885ce5a303c388528411bae27eeecb667a40e)</span></li>
<li>pep8kcm/kcm_pep8.cpp <span style="color: grey">(16ba0c2eccb4de82607ebaa32f4104fc3e9670d3)</span></li>
<li>pythonlanguagesupport.h <span style="color: grey">(c431131a27b60aaeb72d704e1ae4bf4b30edcf3b)</span></li>
<li>pythonlanguagesupport.cpp <span style="color: grey">(9ac3e5005dcce9199c129a782e34eb824ec756fa)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123133/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>