<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122169/">https://git.reviewboard.kde.org/r/122169/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Milian Wolff.</div>
<p style="color: grey;"><i>Updated May 5, 2015, 9:19 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Submitted with commit de49bb7ab86645e0fd434f634c8249a0b2071558 by Milian Wolff to branch master.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdev-clang
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is much better, in my opinion. It allows one to easily include
long paths as well as change existing includes more easily as the
rest of the line gets removed as well.
Additionally, comments get taken into account as well as whitespaces.
An extensive unit test suite is added.
REVIEW: 122169</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>codecompletion/includepathcompletioncontext.cpp <span style="color: grey">(9dea2879418c4f81ab1927d848c831b092bd11e6)</span></li>
<li>codecompletion/model.h <span style="color: grey">(961bdf5cc4a33a9b41cea0cc8c81f0ecfb647b1f)</span></li>
<li>tests/test_clangutils.cpp <span style="color: grey">(1a3c85f4e5c288a5bdbc742ee65e61ba1c49cd9f)</span></li>
<li>tests/test_codecompletion.h <span style="color: grey">(20cc5a94d51062d12674d6823ced10c056c067bc)</span></li>
<li>tests/test_codecompletion.cpp <span style="color: grey">(465c57d7575d9e56776aadf3e200a209e40d24c5)</span></li>
<li>tests/test_duchainutils.cpp <span style="color: grey">(1ae10f1d6686d2823c4cda4ffde34d10460ac3d0)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122169/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>