<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123563/">https://git.reviewboard.kde.org/r/123563/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Alex Richardson.</div>
<p style="color: grey;"><i>Updated May 4, 2015, 3:28 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use new approach and provide the eclipse icons as an external freedesktop.org icon theme (should be okay from a licensing perspective AFAIK)
Requires the matching commit in KDevelop to install icons according to that scheme (maybe the icons should be moved to kdevplatform since they are referenced from there)
-> https://git.reviewboard.kde.org/r/123629/</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Summary (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Allow setting custom code completion icons</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This will make it easier for people that regularly use other IDEs. My
motivation here is that I often used Eclipse for Java development (and
also sometimes for C) and find the mixture of custom icons and ones from
Visual Studio that is used in KDevelop quite confusing in comparison.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This feature is customizable in the Language Support settings. If the
default of "KDevelop Classic" is used there it should have no visible
change to the used icons other than the fact that the namespace icon is
now used instead of the default fallback of field.png</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The Eclipse code completion theme is available from
http://quickgit.kde.org/?p=scratch%2Farichardson%2Feclipse-codecompletion-icons.git
or as prebuilt RPM from
http://download.opensuse.org/repositories/home:/a_richardson/openSUSE_Tumbleweed/noarch/</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The plugin version has been increased since a new virtual function was
added to interfaces/icompletionsettings.h</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Icons are loaded, switching between themes also works</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Examples below are from the outline view plugin (https://git.reviewboard.kde.org/r/123562/)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>util/iconutils.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/settings/ccpreferences.ui <span style="color: grey">(48bd90f44f670b5ea879bc6b187ead8c9bcbba30)</span></li>
<li>shell/settings/ccpreferences.cpp <span style="color: grey">(9346e2397ea4225f9bde02ab4c30889ab0732d24)</span></li>
<li>shell/settings/ccconfig.kcfg <span style="color: grey">(624d8da97580266f52220258e7aa42e0067e76a3)</span></li>
<li>util/iconutils.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>util/CMakeLists.txt <span style="color: grey">(95dd68ee31e0b7845374af7f5b27496627998345)</span></li>
<li>shell/settings/ccpreferences.h <span style="color: grey">(a736c3674784c173837e80758520e6618700d2a5)</span></li>
<li>shell/completionsettings.cpp <span style="color: grey">(89cf68b46e312e0a54cd67cf7235ff5930833f82)</span></li>
<li>shell/completionsettings.h <span style="color: grey">(05f166b4323c773c38ceb6703f36aabe35900636)</span></li>
<li>plugins/outlineview/outlinenode.cpp <span style="color: grey">(fedcbd87cc8dc6e9e18bad1336e912a643af6722)</span></li>
<li>pics/CMakeLists.txt <span style="color: grey">(6e046c7fcb5eb29a6c3331c13cdbeff992946a8a)</span></li>
<li>language/duchain/types/typesystem.h <span style="color: grey">(a054882bcf9039f74a5062d85ccf8f5c2e49b301)</span></li>
<li>language/duchain/duchainutils.cpp <span style="color: grey">(8a26194dcadeb98c94785fecd1b69c91ca0b4502)</span></li>
<li>language/duchain/duchainutils.h <span style="color: grey">(7d4760af955f37c0ad87f4635ddaa8ce31eb445b)</span></li>
<li>language/codecompletion/normaldeclarationcompletionitem.cpp <span style="color: grey">(4f98e4843ff790319ef6e1aecb182d8d716d5431)</span></li>
<li>language/CMakeLists.txt <span style="color: grey">(171428eaca3786a54b63691fd12eef9b6b29cf7c)</span></li>
<li>CMakeLists.txt <span style="color: grey">(08ae3dacd7732d07283e742ee00af3be4bb9fe2b)</span></li>
<li>interfaces/icompletionsettings.h <span style="color: grey">(4b95c5184cf3b950907f291986a1efa2ad48d032)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123563/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/04/29/91b275a1-006e-4752-a322-2404cf674595__eclipse_icons1.png">eclipse_icons1.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/04/29/d365bd2b-20a5-4b8f-9743-84efbf552577__eclipse_icons2.png">eclipse_icons2.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/04/29/ef3ecddd-2a0e-40d1-acd4-db105d2e3748__eclipse_icons3.png">eclipse_icons3.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/04/29/b22651f8-f260-467a-85b6-36592f7176fd__eclipse_icons4.png">eclipse_icons4.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>