<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123563/">https://git.reviewboard.kde.org/r/123563/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 30th, 2015, 9:54 a.m. BST, <b>Jonathan Riddell</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This would need an exception to the kde licence policy which means e-mailing kde-licencing@ and not getting any complaints</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It needs to be well documented with a copy of the licence in the top directory and packagers notified</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">However I question why not just use Breeze icons, the artists working on it are responsive and will make icons that fit in with the rest of KDE and with the correct licence.</p></pre>
</blockquote>
<p>On April 30th, 2015, 10:22 a.m. BST, <b>Kevin Funk</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I agree. Despite the licensing issues, I think using a fairly large amount of icons from another IDE somehow undermines our product identity.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Not to mention those icons don't really fit into the Breeze decoration style. :)</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I wrote this patch a few years ago and just discovered it again so I thought I'd put it up for review.
At the time I was using Eclipse for Java development most of the day and KDevelop for KDE stuff. I didn't like having those totally different code completion icons since with the Visual Studio icons I never know what's what.
I still find them confusing and very much prefer the eclipse ones, but now I've kind of got used to them so it's no longer as important.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I just had a look at the Breeze "code-*" icons and they also seem to try and copy Visual Studio and even worse get rid of all the colour (which I find very important for distinguishing the icons).
I find this patch quite useful for people who are used to Eclipse, but due to the licensing probably not a good idea having this in the main repository?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">What about the other part of the patch, caching icons+overlays in a QHash instead of lots of a sequence of statements each time they are queried?</p></pre>
<br />
<p>- Alex</p>
<br />
<p>On April 29th, 2015, 1:56 p.m. BST, Alex Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Alex Richardson.</div>
<p style="color: grey;"><i>Updated April 29, 2015, 1:56 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I personally find them a lot more intuitive than the Visual Studio ones that
KDevelop ships (C = class, U = Union, S = Struct, T = typedef and N = namespace).
I still had an old branch that replaced the KDevelop icons from a few years ago.
I now cleaned it up and added them as an additional option besides the existing
icon set. It is configurable at runtime but might take a while until all currently
displayed icons have been updated.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Icons are loaded, switching between themes also works</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Examples below are from the outline view plugin (https://git.reviewboard.kde.org/r/123562/)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>interfaces/icompletionsettings.h <span style="color: grey">(4b95c5184cf3b950907f291986a1efa2ad48d032)</span></li>
<li>language/duchain/duchainutils.h <span style="color: grey">(7d4760af955f37c0ad87f4635ddaa8ce31eb445b)</span></li>
<li>language/duchain/duchainutils.cpp <span style="color: grey">(8a26194dcadeb98c94785fecd1b69c91ca0b4502)</span></li>
<li>pics/CMakeLists.txt <span style="color: grey">(6e046c7fcb5eb29a6c3331c13cdbeff992946a8a)</span></li>
<li>pics/codecompletion/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/codecompletion/eclipse_class.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/codecompletion/eclipse_class_forward.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/codecompletion/eclipse_class_package.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/codecompletion/eclipse_class_private.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/codecompletion/eclipse_class_protected.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/codecompletion/eclipse_class_public.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/codecompletion/eclipse_define.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/codecompletion/eclipse_enum.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/codecompletion/eclipse_enum_forward.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/codecompletion/eclipse_enumerator.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/codecompletion/eclipse_field_package.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/codecompletion/eclipse_field_private.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/codecompletion/eclipse_field_protected.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/codecompletion/eclipse_field_public.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/codecompletion/eclipse_function_global.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/codecompletion/eclipse_function_package.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/codecompletion/eclipse_function_private.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/codecompletion/eclipse_function_protected.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/codecompletion/eclipse_function_public.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/codecompletion/eclipse_global_function_declaration.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/codecompletion/eclipse_implement.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/codecompletion/eclipse_interface.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/codecompletion/eclipse_interface_forward.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/codecompletion/eclipse_namespace.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/codecompletion/eclipse_overlay_abstract.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/codecompletion/eclipse_overlay_const.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/codecompletion/eclipse_overlay_implement.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/codecompletion/eclipse_overlay_override.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/codecompletion/eclipse_overlay_package_access.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/codecompletion/eclipse_overlay_private.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/codecompletion/eclipse_overlay_protected.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/codecompletion/eclipse_overlay_public.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/codecompletion/eclipse_overlay_static.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/codecompletion/eclipse_overlay_virtual.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/codecompletion/eclipse_override.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/codecompletion/eclipse_shadows.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/codecompletion/eclipse_struct.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/codecompletion/eclipse_struct_forward.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/codecompletion/eclipse_type_variable.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/codecompletion/eclipse_typedef.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/codecompletion/eclipse_typedef_forward.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/codecompletion/eclipse_union.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/codecompletion/eclipse_union_forward.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/codecompletion/eclipse_unknown_type.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/codecompletion/eclipse_unknown_type_2.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/codecompletion/eclipse_using.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/codecompletion/eclipse_variable_declaration.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/codecompletion/eclipse_variable_global.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/codecompletion/eclipse_variable_local.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/codecompletion/eclipse_variable_type.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/completionsettings.h <span style="color: grey">(05f166b4323c773c38ceb6703f36aabe35900636)</span></li>
<li>shell/completionsettings.cpp <span style="color: grey">(89cf68b46e312e0a54cd67cf7235ff5930833f82)</span></li>
<li>shell/settings/ccconfig.kcfg <span style="color: grey">(624d8da97580266f52220258e7aa42e0067e76a3)</span></li>
<li>shell/settings/ccpreferences.cpp <span style="color: grey">(9346e2397ea4225f9bde02ab4c30889ab0732d24)</span></li>
<li>shell/settings/ccpreferences.ui <span style="color: grey">(48bd90f44f670b5ea879bc6b187ead8c9bcbba30)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123563/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/04/29/91b275a1-006e-4752-a322-2404cf674595__eclipse_icons1.png">eclipse_icons1.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/04/29/d365bd2b-20a5-4b8f-9743-84efbf552577__eclipse_icons2.png">eclipse_icons2.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/04/29/ef3ecddd-2a0e-40d1-acd4-db105d2e3748__eclipse_icons3.png">eclipse_icons3.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/04/29/b22651f8-f260-467a-85b6-36592f7176fd__eclipse_icons4.png">eclipse_icons4.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>