<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122169/">https://git.reviewboard.kde.org/r/122169/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 27th, 2015, 6:59 a.m. UTC, <b>Sergey Kalinichev</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm just wondering why we can't use the regexp anymore and have to switch to the hand-made parser? The regexp takes up less space and much easy to understand IMO (e.g. currently I fail to grasp what the rightBoundary parameter for. Seems like everything should work just fine without it...)
What is more important: if I have a foo.h file and type:
\#include "foo|"
Then invoke code-completion at | and select the foo.h item I get: #include "foofoo.h"
Which is obviously wrong.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I failed to implement this behavior in a sane way with a regular expression. If you start to allow comments everywhere it gets super hard to write a correct regexp for this. I don't think the super long regex that may be written would be easier to understand than this simple parser.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thanks for the failing test though, I'll add a test for that and ensure it works later.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Bye</p></pre>
<br />
<p>- Milian</p>
<br />
<p>On April 21st, 2015, 3:03 p.m. UTC, Milian Wolff wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Milian Wolff.</div>
<p style="color: grey;"><i>Updated April 21, 2015, 3:03 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdev-clang
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is much better, in my opinion. It allows one to easily include
long paths as well as change existing includes more easily as the
rest of the line gets removed as well.
Additionally, comments get taken into account as well as whitespaces.
An extensive unit test suite is added.
REVIEW: 122169</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>codecompletion/includepathcompletioncontext.cpp <span style="color: grey">(9dea2879418c4f81ab1927d848c831b092bd11e6)</span></li>
<li>codecompletion/model.h <span style="color: grey">(961bdf5cc4a33a9b41cea0cc8c81f0ecfb647b1f)</span></li>
<li>tests/test_clangutils.cpp <span style="color: grey">(1a3c85f4e5c288a5bdbc742ee65e61ba1c49cd9f)</span></li>
<li>tests/test_codecompletion.h <span style="color: grey">(20cc5a94d51062d12674d6823ced10c056c067bc)</span></li>
<li>tests/test_codecompletion.cpp <span style="color: grey">(465c57d7575d9e56776aadf3e200a209e40d24c5)</span></li>
<li>tests/test_duchainutils.cpp <span style="color: grey">(1ae10f1d6686d2823c4cda4ffde34d10460ac3d0)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122169/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>