<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123279/">https://git.reviewboard.kde.org/r/123279/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I forgot to say: this is pretty neat and I like the idea. but just make it off-by-default and cleanup your implementation some more. then I'm more than willing to accept it. thanks!</p></pre>
<br />
<p>- Milian</p>
<br />
<p>On April 23rd, 2015, 10:20 p.m. UTC, Sebastien Speierer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Sebastien Speierer.</div>
<p style="color: grey;"><i>Updated April 23, 2015, 10:20 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch adds a checkbox in the KDevelop setting that allows KDevelop to color the tabs (of the open files) depending of their project.
This feature was asked by several users on the KDE bugtracking system.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I tested the feature (open file before/after enable the coloring, tried to open files from several different projects,...), the implementation seems robust.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>.kateproject.d/notes.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/projectmanagerview/projectmodelitemdelegate.cpp <span style="color: grey">(69fd6c4)</span></li>
<li>plugins/projectmanagerview/projecttreeview.h <span style="color: grey">(6512157)</span></li>
<li>plugins/projectmanagerview/projecttreeview.cpp <span style="color: grey">(dbd25ff)</span></li>
<li>shell/mainwindow.h <span style="color: grey">(ae22648)</span></li>
<li>shell/mainwindow.cpp <span style="color: grey">(8757942)</span></li>
<li>shell/project.cpp <span style="color: grey">(e7e6efa)</span></li>
<li>shell/settings/uiconfig.kcfg <span style="color: grey">(b168294)</span></li>
<li>shell/settings/uiconfig.ui <span style="color: grey">(a0d76de)</span></li>
<li>shell/uicontroller.cpp <span style="color: grey">(2108ff2)</span></li>
<li>sublime/container.h <span style="color: grey">(9049f55)</span></li>
<li>sublime/container.cpp <span style="color: grey">(4444077)</span></li>
<li>sublime/urldocument.h <span style="color: grey">(4a02d89)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123279/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/04/22/c544c7ee-765e-4851-be5c-86d5b2241dab__kdevelop5_env_1.png">Screenshot01</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/04/23/79fa321d-3952-43d7-83e8-4af07116c82f__kdevelop5_env_2.png">Screenshot #2 project_manager</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>