<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121045/">https://git.reviewboard.kde.org/r/121045/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On novembris 8th, 2014, 8:33 p.m. EET, <b>Kevin Funk</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121045/diff/1/?file=326850#file326850line75" style="color: black; font-weight: bold; text-decoration: underline;">plugins/appwizard/projectvcspage.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">ProjectVcsPage::ProjectVcsPage( KDevelop::IPluginController* controller, QWidget * parent )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">75</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">disconnect</span><span class="p">(</span> <span class="k">this</span><span class="p">,</span> <span class="n">SLOT</span><span class="p">(</span><span class="n">validateData</span><span class="p">())</span> <span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">75</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">disconnect</span><span class="p">(</span> <span class="k">this</span><span class="p">,</span> <span class="k">static_cast</span><span class="o"><</span><span class="kt">void</span><span class="p">(</span><span class="n">ProjectVcsPage</span><span class="o">::*</span><span class="p">)()</span><span class="o">></span><span class="p">(</span><span class="k">nullptr</span><span class="p">),</span> <span class="k">this</span><span class="p">,</span> <span class="o">&</span><span class="n">ProjectVcsPage</span><span class="o">::</span><span class="n">validateData</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Second parameter can just be <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">nullptr</code>.</p></pre>
</blockquote>
<p>On novembris 9th, 2014, 10:39 p.m. EET, <b>Alex Richardson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Sadly it doesn't, the explicit cast is required here</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">Object::disconnect: signal not found in ProjectVcsPage</code>
^ it doesn't work (changing back to old syntax, no such warning anymore)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I looked into it and couldn't find how to do this with new syntax, seems it should be just <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">disconnect( this, 0, this, &ProjectVcsPage::validateData )</code> but that doesn't work.
from http://doc.qt.io/qt-5/qobject.html#disconnect "If signal is 0, it disconnects receiver and method from any signal."</p></pre>
<br />
<p>- Dāvis</p>
<br />
<p>On novembris 10th, 2014, 2:24 p.m. EET, Alex Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Alex Richardson.</div>
<p style="color: grey;"><i>Updated Nov. 10, 2014, 2:24 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Convert appwizard plugin to new signal/slot syntax</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Convert bazaar plugin to new signal/slot syntax</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Fixes one bad connection: argument was changed from time_t to QDateTime</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Convert classbrowser plugin to new signal/slot syntax</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">EditorViewManager should inherit publicly from QObject, not priavtely</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Convert contextbrowser plugin to new signal/slot syntax</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Convert cvs plugin to new signal/slot syntax</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Convert documentswitcher and documentview to new signal/slot syntax</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Convert execute and executescript plugins to new signal/slot syntax</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Convert externalscript plugin to new signal/slot syntax</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Convert filemanager plugin to new signal/slot syntax</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Convert filetemplates plugin to new signal/slot syntax</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Convert git plugin to new signal/slot syntax</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Convert grepview plugin to new signal/slot syntax</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/appwizard/appwizarddialog.cpp <span style="color: grey">(52bbdc4ae1fde23fdd2577686c780e47e39344cd)</span></li>
<li>plugins/appwizard/appwizardplugin.cpp <span style="color: grey">(d6779eb5a9eede2c705cf14a6cdafca64a9ab901)</span></li>
<li>plugins/appwizard/projectselectionpage.cpp <span style="color: grey">(20cce746a1d4011369dd61f748d4ebf0e0a3f2e2)</span></li>
<li>plugins/appwizard/projectvcspage.cpp <span style="color: grey">(21b57f96526bc63325f7fc6dcde560569bfaeb29)</span></li>
<li>plugins/bazaar/bazaarplugin.cpp <span style="color: grey">(24cf6c2145fcef7e696cf5ab995063faee40cae1)</span></li>
<li>plugins/bazaar/bzrannotatejob.cpp <span style="color: grey">(7c434d959a8652cd4bacd4ac590a6e85f11df336)</span></li>
<li>plugins/bazaar/copyjob.h <span style="color: grey">(3e5c8b8f0e5bc3874e0c8d008c438ca46fa2e20d)</span></li>
<li>plugins/bazaar/copyjob.cpp <span style="color: grey">(68dce4ecd140a20127a19b02f6896ef2d89c7b96)</span></li>
<li>plugins/bazaar/diffjob.cpp <span style="color: grey">(16187d17bc269b86b9f3adc1c43c388ee2a74235)</span></li>
<li>plugins/filetemplates/templateclassassistant.cpp <span style="color: grey">(f9e27e4387abb0bf2f9a2f54ff2ec0b9fdc3ebc8)</span></li>
<li>plugins/filetemplates/templatepreviewtoolview.cpp <span style="color: grey">(5fe1e51337ed651c6367695e60008c42eb4f7b9d)</span></li>
<li>plugins/filetemplates/templateselectionpage.cpp <span style="color: grey">(dac99f46e0dccfcfd06630ac353cbf8a5aef2025)</span></li>
<li>plugins/filetemplates/testcasespage.cpp <span style="color: grey">(4e395cf93fa0109efc3b99c6e9de05fbaef3f410)</span></li>
<li>plugins/git/gitclonejob.cpp <span style="color: grey">(70ec36cfe5b1e2415c36bca0660d5f4540901976)</span></li>
<li>plugins/git/gitplugin.cpp <span style="color: grey">(c07911db717a1b841e2affd21b4e28bb437c739b)</span></li>
<li>plugins/git/gitplugincheckinrepositoryjob.cpp <span style="color: grey">(1a62cacd3c043a0dbe73ce9812314efc3426180c)</span></li>
<li>plugins/git/stashmanagerdialog.cpp <span style="color: grey">(8275cf460f2cd8314b5167bcc366b1dc70dc044c)</span></li>
<li>plugins/git/stashpatchsource.cpp <span style="color: grey">(03804608b13b9d0ed7bba3c5315d6a3a2360b1e1)</span></li>
<li>plugins/grepview/grepdialog.cpp <span style="color: grey">(0cb0563376c6cb8ca8c203f9e09605895242adfd)</span></li>
<li>plugins/grepview/grepjob.cpp <span style="color: grey">(850f15b65ee807d2fd36e5fb202ace9de1765cec)</span></li>
<li>plugins/grepview/grepoutputmodel.cpp <span style="color: grey">(81cb2b9f3c2efdd28cd325a5c5fb12f5029a3849)</span></li>
<li>plugins/grepview/grepoutputview.cpp <span style="color: grey">(f14b1700b8f98ddb8e86d45ada7a2d4c833b3eca)</span></li>
<li>plugins/grepview/grepviewplugin.cpp <span style="color: grey">(0aaddb4b531e67446b75597c078c5b93da56939c)</span></li>
<li>plugins/filetemplates/outputpage.cpp <span style="color: grey">(24b5ea7342bd80241662490fcf6403f5418b8dec)</span></li>
<li>plugins/filetemplates/overridespage.cpp <span style="color: grey">(6a1282731b1198a4cea1fee0016ff2fea5d84de3)</span></li>
<li>plugins/documentview/kdevdocumentview.h <span style="color: grey">(eb307ab8745fa41d92e918debbe09f611533f35f)</span></li>
<li>plugins/documentview/kdevdocumentview.cpp <span style="color: grey">(32e27eb38349ef860933a32ad17b190a12004bfb)</span></li>
<li>plugins/documentview/kdevdocumentviewplugin.cpp <span style="color: grey">(2b9b637134cd8d94ecaa609e5560e5ce3352cd0a)</span></li>
<li>plugins/execute/nativeappconfig.cpp <span style="color: grey">(bd8883e8093e5dfa5d563907c4fc20c563e77283)</span></li>
<li>plugins/execute/nativeappjob.cpp <span style="color: grey">(79ad1415416e196105eb0c76c8ca04a9fedcfd5c)</span></li>
<li>plugins/executescript/scriptappconfig.cpp <span style="color: grey">(4bd2a17985ec72541ad42368a287f77ab0ef06e3)</span></li>
<li>plugins/executescript/scriptappjob.cpp <span style="color: grey">(2f96d2099d8c0b213e8f68e8617ad6bf6ae940ac)</span></li>
<li>plugins/externalscript/editexternalscript.cpp <span style="color: grey">(5e08f8f28309a76f05a8f8450f5fe0a1c166aa1b)</span></li>
<li>plugins/externalscript/externalscriptitem.cpp <span style="color: grey">(555dda728caf2c86dfb62da755c9be1e3ed8bced)</span></li>
<li>plugins/externalscript/externalscriptjob.cpp <span style="color: grey">(44753ef735940b4d6017778835d8955d2cb945d3)</span></li>
<li>plugins/externalscript/externalscriptplugin.cpp <span style="color: grey">(968adb5567710e35ac8dfc7dfe9dc2efa367c2ea)</span></li>
<li>plugins/externalscript/externalscriptview.cpp <span style="color: grey">(329a7f49aa5c77b64ee15df5bcc73d196545039d)</span></li>
<li>plugins/filemanager/filemanager.cpp <span style="color: grey">(73081157d1bb0265db30bb48ef62eb105cfd2472)</span></li>
<li>plugins/filetemplates/classidentifierpage.cpp <span style="color: grey">(65ec2db24211633b0ecfc46ec2fdf60102319866)</span></li>
<li>plugins/filetemplates/filetemplatesplugin.cpp <span style="color: grey">(9ea20b6c7b4116abaeb89a433cb7ffdffa1aaa88)</span></li>
<li>plugins/filetemplates/licensepage.cpp <span style="color: grey">(f44088b9929d988e914a595610f9a77ca500eefb)</span></li>
<li>plugins/contextbrowser/contextbrowser.cpp <span style="color: grey">(de97edc883b1b351f79340e70a44de8a8bb31b19)</span></li>
<li>plugins/contextbrowser/contextbrowserview.cpp <span style="color: grey">(aeacb7913b7f8733124e7c03f82b7e5c0c07327b)</span></li>
<li>plugins/cvs/checkoutdialog.cpp <span style="color: grey">(2807fdedc2176c90bbe3b217448b72e4622ddf1f)</span></li>
<li>plugins/cvs/cvsgenericoutputview.cpp <span style="color: grey">(52908155430a90539582c48bb127cefda32d75c8)</span></li>
<li>plugins/cvs/cvsmainview.cpp <span style="color: grey">(ee0df0a55abcc5fe8027339c07fa08c984d394dd)</span></li>
<li>plugins/cvs/cvsplugin.cpp <span style="color: grey">(925e5d8ec4b6f68815c72e0e6d081c5802a56197)</span></li>
<li>plugins/cvs/editorsview.cpp <span style="color: grey">(10513d7e1916994604364766cf7db645a53aaa7b)</span></li>
<li>plugins/cvs/importdialog.cpp <span style="color: grey">(4c6ef1cfa8f71934ffec1f196e2318861a38539e)</span></li>
<li>plugins/cvs/importmetadatawidget.cpp <span style="color: grey">(3c978f3f0b47f21b663cb35e2843f00f3b2ac611)</span></li>
<li>plugins/documentswitcher/documentswitcherplugin.cpp <span style="color: grey">(eebd6163f7a74c50b1286a288917604620abdba6)</span></li>
<li>plugins/classbrowser/allclassesfolder.cpp <span style="color: grey">(749151c76a256ac8e04c90367b56e7f36f0bbfc2)</span></li>
<li>plugins/classbrowser/classbrowserplugin.cpp <span style="color: grey">(b5d6a678d33870ab73e2ff9a92d44d7d478e3b5a)</span></li>
<li>plugins/classbrowser/classmodel.cpp <span style="color: grey">(5ca922da5b3524c830ca105341161bffca8aabff)</span></li>
<li>plugins/classbrowser/classmodelnodescontroller.cpp <span style="color: grey">(7f29a0e13f48bdad8847b15ac35e028947e711f5)</span></li>
<li>plugins/classbrowser/classtree.cpp <span style="color: grey">(0463a135ea8e56ce3b10914aa5f18de5f28cbce8)</span></li>
<li>plugins/classbrowser/classwidget.cpp <span style="color: grey">(798be66633f40ad728718e58c9ce8482594c48bf)</span></li>
<li>plugins/classbrowser/documentclassesfolder.cpp <span style="color: grey">(3ec451034ffbd66d07fb019da173b00978dd8dcb)</span></li>
<li>plugins/contextbrowser/browsemanager.h <span style="color: grey">(79426ce968d2e5bde76525f9c40814abbd46fb06)</span></li>
<li>plugins/contextbrowser/browsemanager.cpp <span style="color: grey">(c36e64644ed2b4f8242abd7135c9d63bcdba4bab)</span></li>
<li>plugins/contextbrowser/contextbrowser.h <span style="color: grey">(18b2b1347490718fd1c960452d2a980680e5f45c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121045/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>