<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119830/">https://git.reviewboard.kde.org/r/119830/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Would be nice if you could go through the other KDevelop-related repos and check if they still compile with this change.</p></pre>
<br />
<p>- Kevin Funk</p>
<br />
<p>On March 21st, 2015, 4:19 a.m. UTC, Dāvis Mosāns wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Dāvis Mosāns.</div>
<p style="color: grey;"><i>Updated March 21, 2015, 4:19 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Remove deprecated IProject methods. No need to keep them, when KUrl will be changed to QUrl signatures would be different anyway, so just remove now.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tests does pass :)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">but note that KDevelop must also be updated and currently it won't compile against this because it still uses these deprecated methods.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>interfaces/iproject.h <span style="color: grey">(bdfd66557dc9d9eebe4f8773e0428a8183ec1825)</span></li>
<li>plugins/execute/nativeappconfig.cpp <span style="color: grey">(9c83db9e021201b0732ce186423a3d922458262d)</span></li>
<li>plugins/executescript/scriptappconfig.cpp <span style="color: grey">(947cc464a42e3c18c38034287c93bdcb4ae8726c)</span></li>
<li>plugins/externalscript/externalscriptjob.cpp <span style="color: grey">(e65516d65e9315129bb8a9efc6d8897b4413cde6)</span></li>
<li>plugins/filetemplates/templateclassassistant.cpp <span style="color: grey">(8681590b8e15ed1f3ceb15cba118733eb67c7e06)</span></li>
<li>plugins/grepview/grepdialog.cpp <span style="color: grey">(4671c30bcdb75699d0cd474da78cfbf15eadf535)</span></li>
<li>plugins/projectmanagerview/projectmanagerview.cpp <span style="color: grey">(95ae9a90273ec4f4be57fdc5e526e4416440788f)</span></li>
<li>plugins/projectmanagerview/vcsoverlayproxymodel.cpp <span style="color: grey">(62e632c9c6e243d4a34626837f9232b3a3cc3f2a)</span></li>
<li>project/projectmodel.h <span style="color: grey">(e7513ff99cdb8f1724828e7e4d338c0fdcf1a7fa)</span></li>
<li>project/projectmodel.cpp <span style="color: grey">(49cd984bdcbba661fedd8fbf42912b43fa28b733)</span></li>
<li>shell/project.h <span style="color: grey">(aec5be208c058a17540b3646dd4a8a0a12a29750)</span></li>
<li>shell/project.cpp <span style="color: grey">(e7e6efa462e8000c566af265d441464b5ab5cdce)</span></li>
<li>shell/projectcontroller.cpp <span style="color: grey">(50bdce4b47c16a4e62c8b7014897a6ae12d6bba6)</span></li>
<li>tests/testproject.h <span style="color: grey">(06757db24be0a356f4a0aee27f07899b6ea906b7)</span></li>
<li>tests/testproject.cpp <span style="color: grey">(39a6d0be6505fcb7f5e130f27481fe02b89a7446)</span></li>
<li>vcs/models/brancheslistmodel.cpp <span style="color: grey">(0737f8bcb8f855ac0901be6885428721218acefb)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119830/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>