<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122727/">https://git.reviewboard.kde.org/r/122727/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 26th, 2015, 3:04 p.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Shouldn't this be up to the language implementation? I don't think it's something up to the user to configure more than it's Ruby where the declaration concept doesn't make that much sense in practice...</p></pre>
</blockquote>
<p>On February 26th, 2015, 3:24 p.m. UTC, <b>Kevin Funk</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I had the same thoughts, but then again, there seem to be quite a few users being put off by the bold font <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">in general</em>, according to https://bugs.kde.org/show_bug.cgi?id=294819.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">But it probably makes sense to allow <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">languages</em> to disable it completely, regardless of what the user configured. Maybe by adding a corresponding flag in ILanguageSupport. Thoughts?</p></pre>
</blockquote>
<p>On February 26th, 2015, 3:28 p.m. UTC, <b>Miquel Sabaté Solà</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Not really. I said at first that this is specially useful in languages such as Ruby or PHP, but I'd also want this in C++ and in any language really (see the bug reports, they are not talking about specific languages either). Moreover, I can see people prefering "the old way" for Ruby or Python too.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So, regardless of the language, some people might want to have it enabled, and some ohers disabled. Therefore, this should be configurable, not implemented by language plugins.</p></pre>
</blockquote>
<p>On February 26th, 2015, 3:33 p.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Well, I don't really agree, I don't think it's that much about what people want but about what makes sense.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Well, I don't think it's bad to allow to disable it. We generally have <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">very</em> few options for an IDE, too few at times, I think.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Let's choose sane defaults, but allow people to override them.</p></pre>
<br />
<p>- Kevin</p>
<br />
<p>On February 26th, 2015, 2:38 p.m. UTC, Miquel Sabaté Solà wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Miquel Sabaté Solà.</div>
<p style="color: grey;"><i>Updated Feb. 26, 2015, 2:38 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=234898">234898</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=294819">294819</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I've added a configurable option for the semantic highlighting in which the user can deactivate a bold style for declarations. This is specially useful for languages such as Ruby or PHP in which the difference between a declaration and a use is narrower than in languages like C. By default this option is set to true, which is the behavior that we had before this patch. I've uploaded some images too.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Manual testing.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>interfaces/icompletionsettings.h <span style="color: grey">(c41ee20)</span></li>
<li>language/highlighting/codehighlighting.cpp <span style="color: grey">(918038b)</span></li>
<li>language/highlighting/colorcache.h <span style="color: grey">(d021fd2)</span></li>
<li>language/highlighting/colorcache.cpp <span style="color: grey">(5494be1)</span></li>
<li>shell/completionsettings.h <span style="color: grey">(e441319)</span></li>
<li>shell/completionsettings.cpp <span style="color: grey">(0440ca7)</span></li>
<li>shell/settings/ccconfig.kcfg <span style="color: grey">(1cd72a4)</span></li>
<li>shell/settings/ccpreferences.ui <span style="color: grey">(fa4559e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122727/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/02/26/2a291537-8ad4-4d61-b287-4b5a0973eeba__before.png">Bold declarations</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/02/26/a208ddcd-ea43-4403-ac7c-bb1f18e04056__after.png">Without bold declarations</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/02/26/236ada26-d6f5-4395-a5f6-6bf7bbb46969__cfg.png">Configuration dialog</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>