<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122095/">https://git.reviewboard.kde.org/r/122095/</a>
     </td>
    </tr>
   </table>
   <br />





<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
 <p style="margin-top: 0;">On janvier 19th, 2015, 4:04 après-midi CET, <b>Kevin Funk</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Note, you can easily validate all JSON files via <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">python-demjson</code>. Install and then run:
<code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">$ find . -iname "*.json" | xargs jsonlint</code></p></pre>
 </blockquote>




 <p>On janvier 27th, 2015, 1:46 après-midi CET, <b>Milian Wolff</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ping, any news on this front? Otherwise I'll probably pick up your work and fix the issues to get it in.</p></pre>
 </blockquote>








</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">yes, it's almost finished, but yesterday rebasing on master failed because scripty has touched some desktop.cmake, I need to fix this and it should be ok.</p></pre>
<br />










<p>- Laurent</p>


<br />
<p>On janvier 17th, 2015, 11:19 après-midi CET, Laurent Navet wrote:</p>









<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
 <tr>
  <td>

<div>Review request for KDevelop.</div>
<div>By Laurent Navet.</div>


<p style="color: grey;"><i>Updated jan. 17, 2015, 11:19 après-midi</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevelop
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">use new .json format instead</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">test pass or fail as before.</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kdeintegration/kdeprovider/kdeproviderplugin.cpp <span style="color: grey">(d3d0504)</span></li>

 <li>documentation/manpage/kdevmanpage.json <span style="color: grey">(PRE-CREATION)</span></li>

 <li>documentation/manpage/manpageplugin.cpp <span style="color: grey">(9c742dc)</span></li>

 <li>formatters/astyle/CMakeLists.txt <span style="color: grey">(9a3a6f7)</span></li>

 <li>formatters/astyle/astyle_plugin.cpp <span style="color: grey">(16ce95a)</span></li>

 <li>formatters/astyle/kdevastyle.desktop.cmake <span style="color: grey">(b7f8383)</span></li>

 <li>formatters/astyle/kdevastyle.json <span style="color: grey">(PRE-CREATION)</span></li>

 <li>formatters/customscript/CMakeLists.txt <span style="color: grey">(b90b449)</span></li>

 <li>formatters/customscript/customscript_plugin.cpp <span style="color: grey">(2e835c5)</span></li>

 <li>formatters/customscript/kdevcustomscript.desktop.cmake <span style="color: grey">(f9785b7)</span></li>

 <li>formatters/customscript/kdevcustomscript.json <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kdeintegration/executeplasmoid/CMakeLists.txt <span style="color: grey">(f7a859f)</span></li>

 <li>kdeintegration/executeplasmoid/executeplasmoidplugin.cpp <span style="color: grey">(92c1ec8)</span></li>

 <li>kdeintegration/executeplasmoid/kdevexecuteplasmoid.desktop.cmake <span style="color: grey">(8fad749)</span></li>

 <li>kdeintegration/executeplasmoid/kdevexecuteplasmoid.json <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kdeintegration/kdeprovider/CMakeLists.txt <span style="color: grey">(ed44923)</span></li>

 <li>kdeintegration/kdeprovider/kdevkdeprovider.desktop.cmake <span style="color: grey">(8a46583)</span></li>

 <li>kdeintegration/kdeprovider/kdevkdeprovider.json <span style="color: grey">(PRE-CREATION)</span></li>

 <li>languages/cpp/CMakeLists.txt <span style="color: grey">(c12b33f)</span></li>

 <li>languages/cpp/cpplanguagesupport.cpp <span style="color: grey">(8ed8f3e)</span></li>

 <li>languages/cpp/kdevcppsupport.desktop.cmake <span style="color: grey">(83665d7)</span></li>

 <li>languages/cpp/kdevcppsupport.json <span style="color: grey">(PRE-CREATION)</span></li>

 <li>languages/plugins/custom-definesandincludes/CMakeLists.txt <span style="color: grey">(4887880)</span></li>

 <li>languages/plugins/custom-definesandincludes/definesandincludesmanager.cpp <span style="color: grey">(f5a1aeb)</span></li>

 <li>languages/plugins/custom-definesandincludes/kdevdefinesandincludesmanager.desktop.cmake <span style="color: grey">(70095a4)</span></li>

 <li>languages/plugins/custom-definesandincludes/kdevdefinesandincludesmanager.json <span style="color: grey">(PRE-CREATION)</span></li>

 <li>projectbuilders/cmakebuilder/CMakeLists.txt <span style="color: grey">(2bef798)</span></li>

 <li>projectbuilders/cmakebuilder/cmakebuilder.cpp <span style="color: grey">(c9fdecc)</span></li>

 <li>projectbuilders/cmakebuilder/kdevcmakebuilder.desktop.cmake <span style="color: grey">(cb99d23)</span></li>

 <li>projectbuilders/cmakebuilder/kdevcmakebuilder.json <span style="color: grey">(PRE-CREATION)</span></li>

 <li>projectbuilders/makebuilder/CMakeLists.txt <span style="color: grey">(f73be22)</span></li>

 <li>projectbuilders/makebuilder/kdevmakebuilder.desktop.cmake <span style="color: grey">(c1fec9f)</span></li>

 <li>projectbuilders/makebuilder/kdevmakebuilder.json <span style="color: grey">(PRE-CREATION)</span></li>

 <li>projectbuilders/makebuilder/makebuilder.cpp <span style="color: grey">(f653f54)</span></li>

 <li>projectbuilders/ninjabuilder/CMakeLists.txt <span style="color: grey">(5b9cc52)</span></li>

 <li>projectbuilders/ninjabuilder/kdevninja.desktop.cmake <span style="color: grey">(ab17779)</span></li>

 <li>projectbuilders/ninjabuilder/kdevninja.json <span style="color: grey">(PRE-CREATION)</span></li>

 <li>projectbuilders/ninjabuilder/kdevninjabuilderplugin.cpp <span style="color: grey">(30b2605)</span></li>

 <li>projectmanagers/cmake/CMakeLists.txt <span style="color: grey">(56d769f)</span></li>

 <li>projectmanagers/cmake/cmakedocumentation.cpp <span style="color: grey">(6d3caf0)</span></li>

 <li>projectmanagers/cmake/cmakemanager.cpp <span style="color: grey">(35a96ba)</span></li>

 <li>projectmanagers/cmake/kdevcmakedocumentation.desktop.cmake <span style="color: grey">(bddd45e)</span></li>

 <li>projectmanagers/cmake/kdevcmakedocumentation.json <span style="color: grey">(PRE-CREATION)</span></li>

 <li>projectmanagers/cmake/kdevcmakemanager.desktop.cmake <span style="color: grey">(7452be2)</span></li>

 <li>projectmanagers/cmake/kdevcmakemanager.json <span style="color: grey">(PRE-CREATION)</span></li>

 <li>projectmanagers/custom-buildsystem/CMakeLists.txt <span style="color: grey">(7bb019e)</span></li>

 <li>projectmanagers/custom-buildsystem/kdevcustombuildsystem.desktop.cmake <span style="color: grey">(cc79185)</span></li>

 <li>projectmanagers/custom-buildsystem/kdevcustombuildsystem.json <span style="color: grey">(PRE-CREATION)</span></li>

 <li>projectmanagers/custommake/CMakeLists.txt <span style="color: grey">(8a8b20e)</span></li>

 <li>projectmanagers/custommake/custommakemanager.cpp <span style="color: grey">(cd3bf8f)</span></li>

 <li>projectmanagers/custommake/kdevcustommakemanager.desktop.cmake <span style="color: grey">(327028a)</span></li>

 <li>projectmanagers/custommake/kdevcustommakemanager.json <span style="color: grey">(PRE-CREATION)</span></li>

 <li>providers/ghprovider/CMakeLists.txt <span style="color: grey">(878be9d)</span></li>

 <li>providers/ghprovider/ghproviderplugin.cpp <span style="color: grey">(88277ea)</span></li>

 <li>providers/ghprovider/kdevghprovider.desktop.cmake <span style="color: grey">(e641712)</span></li>

 <li>providers/ghprovider/kdevghprovider.json <span style="color: grey">(PRE-CREATION)</span></li>

 <li>debuggers/gdb/CMakeLists.txt <span style="color: grey">(b2751ff)</span></li>

 <li>debuggers/gdb/debuggerplugin.cpp <span style="color: grey">(53a2588)</span></li>

 <li>debuggers/gdb/kdevgdb.desktop.cmake <span style="color: grey">(9ab07eb)</span></li>

 <li>debuggers/gdb/kdevgdb.json <span style="color: grey">(PRE-CREATION)</span></li>

 <li>documentation/manpage/CMakeLists.txt <span style="color: grey">(003804c)</span></li>

 <li>documentation/manpage/kdevmanpage.desktop.cmake <span style="color: grey">(89c9257)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122095/diff/" style="margin-left: 3em;">View Diff</a></p>






  </td>
 </tr>
</table>








  </div>
 </body>
</html>