<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122160/">https://git.reviewboard.kde.org/r/122160/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 21st, 2015, 2:26 p.m. UTC, <b>Sergey Kalinichev</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Looks good for me.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Can't we maybe store information about whenever a document is being reparsed for the second time in ClangSupport or ClangIndex to prevent endless recursion?</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yep, afaik there is actually API to mark a rescheduled parse job. So we just need to check that flag. Python is using it, afaik, for similar reasons.</p></pre>
<br />
<p>- Milian</p>
<br />
<p>On January 20th, 2015, 12:55 a.m. UTC, Milian Wolff wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Milian Wolff.</div>
<p style="color: grey;"><i>Updated Jan. 20, 2015, 12:55 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdev-clang
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In such cases, it's worthwile to use the source buddy as best-guess as
it allows us to get rid of the parse run for the "header TU" which
gets thrown away later on anyways.
Note that this might be troublesome and lead to infinite recursion
when the buddy's TU is not including the header file, as we'd then
reschedule the header for parsing and end up with the same situation
as before. Suggestions on how to fix this would be welcome...
Performance wise, this patch improves the index run on a 48 file
project using STL: It goes from ~17s down to ~14s, just b/c we safe
a few needless clang runs on "header TUs".</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(22deffa2bbd5c7e2558ab1548b4447667d9671e4)</span></li>
<li>clangsupport.cpp <span style="color: grey">(f4f49b079d52462cfb0d56086780751605a6ab46)</span></li>
<li>documentfinderhelpers.h <span style="color: grey">()</span></li>
<li>documentfinderhelpers.cpp <span style="color: grey">()</span></li>
<li>duchain/CMakeLists.txt <span style="color: grey">(8ed282b652361c45c668fa948917e075fed4f277)</span></li>
<li>duchain/clangindex.cpp <span style="color: grey">(25c7855e7bd67aa2a3be28f1ea803dd025e6a1ba)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122160/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>