<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121649/">https://git.reviewboard.kde.org/r/121649/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 31st, 2014, 7:26 a.m. UTC, <b>Olivier Jean de Gaalon</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Rather embarassing that I didn't notice this sooner. I came up with a completely different solution: https://git.reviewboard.kde.org/r/121757/ </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The advantage of what I have is that it should work for headers that have no buddy but are otherwise used anywhere in the project.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Of course my solution doesn't actually work right now (CMake doesn't build targets, but that needs to be fixed?) so about this:
1. This might useful in addition to the other as a "first guess" before any "target" TUs are found/created
2. I /really/ think it would be better to use the TU of the cpp rather than merging the includes. Is that significantly more work?</p></pre>
</blockquote>
<p>On December 31st, 2014, 10:43 a.m. UTC, <b>Olivier Jean de Gaalon</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">What about creating a parse job for the source-buddy and waiting for it?
As long as the source environment can beat the header environment it should stick?</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">(regarding cmake)
Well, the headers are extracted from the compile_commands.json file, we just have the headers separately for each .cpp file. In cmake you can have file-specific include directories so doing headers in a target scope doesn't make much sense in cmake (and I guess on others will be the same, e.g. Makefiles).
OTOH I have a branch with targets, so they do exist, but it doesn't seem they will get include directories information.</p></pre>
<br />
<p>- Aleix</p>
<br />
<p>On December 23rd, 2014, 5:28 p.m. UTC, Milian Wolff wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Milian Wolff.</div>
<p style="color: grey;"><i>Updated Dec. 23, 2014, 5:28 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdev-clang
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">We use the existing find-buddy-document architecture to find a
source file corresponding to the current header file. If we find
a match that also has a project file, we ask it for its include
files.
This fixes an issue, where when editing a header file Clang would
never find the include paths. The reason is that in e.g. CMake,
only the .cpp files have include paths, but not the .h files.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>clangparsejob.cpp <span style="color: grey">(297b836128c441a7f6aacbac7ec175ca4bf7b8e1)</span></li>
<li>duchain/clangparsingenvironment.cpp <span style="color: grey">(1decc1493eba5b81d18937ce43dd5c24ea6db01f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121649/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>