<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121690/">https://git.reviewboard.kde.org/r/121690/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hey Alex, I don't really know anything about the plugin stuff and cannot comment on the big picture, but I did notice two stylistic issues.</p></pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121690/diff/1/?file=335943#file335943line95" style="color: black; font-weight: bold; text-decoration: underline;">shell/loadedpluginsdialog.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">95</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">case</span> <span class="n">CommentRole</span>:</pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">95</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">case</span> <span class="n">CommentRole</span>:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">96</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="n">pluginInfo</span><span class="p">(</span><span class="n">plugin</span><span class="p">).</span><span class="n"><span class="hl">comment</span></span><span class="p">();</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">96</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="n">pluginInfo</span><span class="p">(</span><span class="n">plugin</span><span class="p">).</span><span class="n"><span class="hl">description</span></span><span class="p">();</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Since CommentRole is a user-define role here, it should be renamed to DescriptionRole for consistency.</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121690/diff/1/?file=335946#file335946line662" style="color: black; font-weight: bold; text-decoration: underline;">shell/plugincontroller.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">IPlugin *PluginController::loadPluginInternal( const QString &pluginId )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">657</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">Q_FOREACH</span><span class="p">(</span> <span class="k">const</span> <span class="n">KPlugin<span class="hl">Info</span></span><span class="o">&</span> <span class="n">info</span> <span class="p">,</span> <span class="n">d</span><span class="o">-></span><span class="n">plugins</span> <span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">645</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">Q_FOREACH</span><span class="p">(</span> <span class="k">const</span> <span class="n">KPlugin<span class="hl">MetaData</span></span><span class="o">&</span> <span class="n">info</span> <span class="p">,</span> <span class="n">d</span><span class="o">-></span><span class="n">plugins</span> <span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Use C++11 for-range loop.</p></pre>
</div>
</div>
<br />
<p>- Nicolai Hähnle</p>
<br />
<p>On December 27th, 2014, 2:11 p.m. UTC, Alex Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Alex Richardson.</div>
<p style="color: grey;"><i>Updated Dec. 27, 2014, 2:11 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Port from KPluginInfo to KPluginMetaData</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/standardoutputview/tests/test_standardoutputview.cpp <span style="color: grey">(8159560be2eaba42a931da8f64ec954d020cfb25)</span></li>
<li>shell/documentcontroller.cpp <span style="color: grey">(8b3fde4f218b11ad9cb126224302bdff52ee74c3)</span></li>
<li>shell/languagecontroller.cpp <span style="color: grey">(5f0a8c15f65f697df837ec634cb1508188e28e67)</span></li>
<li>shell/loadedpluginsdialog.cpp <span style="color: grey">(10787a41e8094208f41bd6a6e025539377321581)</span></li>
<li>interfaces/iplugincontroller.h <span style="color: grey">(687c1a0f00f94b9d6cf793dba4adfd79947172ac)</span></li>
<li>plugins/appwizard/appwizardplugin.cpp <span style="color: grey">(e8e9472caa62370191647bdc6fbc456837f0e96f)</span></li>
<li>plugins/appwizard/projectvcspage.cpp <span style="color: grey">(2127caf7697ebdc7f92b11a07100d86098e63343)</span></li>
<li>plugins/contextbrowser/contextbrowser.cpp <span style="color: grey">(5771c92e9a8eb6604ec1e97a9d504487c0655fcd)</span></li>
<li>plugins/dashboard/appletselector.cpp <span style="color: grey">(32c616b7a64b5d61f90d854b233c80c17872f397)</span></li>
<li>plugins/patchreview/patchreviewtoolview.cpp <span style="color: grey">(17e63be67244a02d5804c7e0d97e0138848bc163)</span></li>
<li>shell/openprojectpage.cpp <span style="color: grey">(b551b0511583a6dbd6edc16a30f1f4d7148a3e1c)</span></li>
<li>shell/plugincontroller.h <span style="color: grey">(65aeed01e5d1547716882d75de124c7366a1665a)</span></li>
<li>shell/plugincontroller.cpp <span style="color: grey">(f24be065a293f0112227ba20f51159d377e47a88)</span></li>
<li>shell/project.cpp <span style="color: grey">(19dcb1122338f3d1ab6f296193c3f9b50ec4e91d)</span></li>
<li>shell/projectcontroller.cpp <span style="color: grey">(6eeb434609749c8cdef1e53537efd8023d5dcc54)</span></li>
<li>shell/projectinfopage.cpp <span style="color: grey">(19984009928257ee4c272b93dc814afafe20315b)</span></li>
<li>shell/projectsourcepage.cpp <span style="color: grey">(d6c1ac1a604eb4af33575fea80e6ed55ecd12c66)</span></li>
<li>shell/session.cpp <span style="color: grey">(079e3ce63b1698446f1d35b7de6c8da73beca50c)</span></li>
<li>shell/settings/pluginpreferences.cpp <span style="color: grey">(4b8be9db715ce9fd8d98eabac617a424d11ec879)</span></li>
<li>shell/settings/sourceformattersettings.cpp <span style="color: grey">(2421bd12d2eacf85383f96758a17c79c02b2b91e)</span></li>
<li>shell/sourceformattercontroller.h <span style="color: grey">(b53660cbe9011a60b90d7f6c9c96e5dba1d95234)</span></li>
<li>shell/sourceformattercontroller.cpp <span style="color: grey">(eee6bd243ad41ca9fe738476fe1b155989b71e77)</span></li>
<li>shell/tests/test_plugincontroller.cpp <span style="color: grey">(fae7654c3bd48f61374bfcd1c50047f25febdefe)</span></li>
<li>shell/textdocument.cpp <span style="color: grey">(3e47a412069eef381579b0f1a5cd3069334359f0)</span></li>
<li>tests/testplugincontroller.h <span style="color: grey">(674c91e4393ea3ccdfd6a5204ee2c4d66e96443d)</span></li>
<li>tests/testplugincontroller.cpp <span style="color: grey">(2e00bebca322539c0105b1d164398808e8255ae3)</span></li>
<li>vcs/models/projectchangesmodel.cpp <span style="color: grey">(153af358d618e249e364ef1b4f34ccf08bb58411)</span></li>
<li>vcs/vcspluginhelper.cpp <span style="color: grey">(c11fbf28a33716393e42d5a0411e808a54a2fc8d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121690/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>