<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121681/">https://git.reviewboard.kde.org/r/121681/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 26th, 2014, 3:23 p.m. UTC, <b>Alex Richardson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121681/diff/1/?file=335863#file335863line68" style="color: black; font-weight: bold; text-decoration: underline;">uploadjob.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void UploadJob::start()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">67</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k"><span class="hl">if</span></span><span class="hl"> </span><span class="p"><span class="hl">(</span></span><span class="n">KIO</span><span class="o">::</span><span class="n"><span class="hl">NetAccess</span></span><span class="o">::</span><span class="n">stat</span><span class="p">(</span><span class="n">item</span><span class="o">-></span><span class="n">path</span><span class="p">().</span><span class="n">toUrl</span><span class="p">()<span class="hl">,</span></span><span class="hl"> </span><span class="n"><span class="hl">entry</span></span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="n"><span class="hl">m_progressDialog</span></span><span class="p"><span class="hl">))</span></span><span class="hl"> </span><span class="p"><span class="hl">{</span></span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">66</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KIO</span><span class="o">::</span><span class="n"><span class="hl">StatJob</span></span><span class="hl"> </span><span class="o"><span class="hl">*</span></span><span class="n"><span class="hl">statjob</span></span><span class="hl"> </span><span class="o"><span class="hl">=</span></span><span class="hl"> </span><span class="n"><span class="hl">KIO</span></span><span class="o">::</span><span class="n">stat</span><span class="p">(</span><span class="n">item</span><span class="o">-></span><span class="n">path</span><span class="p">().</span><span class="n">toUrl</span><span class="p">()<span class="hl">);</span></span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Doesn't this leak the KIO::StatJob?</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">You are probably right. I've added delete statements - hope that's tidy enough solution.</p></pre>
<br />
<p>- Jakub</p>
<br />
<p>On December 26th, 2014, 4:03 p.m. UTC, Jakub Caban wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Jakub Caban.</div>
<p style="color: grey;"><i>Updated Dec. 26, 2014, 4:03 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdev-upload
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Just a few porting bits to make it compile again without KDELibs4Support:
- port away from KIcon
- port away from KIO::NetAccess
- kDebug() -> qDebug() (actually I've enforced kDebug(int) -> qDebug() as I found no reason to keep that categorization in one place. If I'm mistaken let me know)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Compiles and works in simple cases I've tried.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>allprofilesmodel.cpp <span style="color: grey">(3ee6053)</span></li>
<li>kdevuploadplugin.cpp <span style="color: grey">(3f05752)</span></li>
<li>profilesfiletree.cpp <span style="color: grey">(45152f6)</span></li>
<li>tests/permissions.cpp <span style="color: grey">(1837838)</span></li>
<li>uploaddialog.cpp <span style="color: grey">(8d0c7a1)</span></li>
<li>uploadjob.cpp <span style="color: grey">(ebe556b)</span></li>
<li>uploadpreferences.cpp <span style="color: grey">(1fe0d72)</span></li>
<li>uploadprofiledlg.cpp <span style="color: grey">(ac0fba2)</span></li>
<li>uploadprofileitem.cpp <span style="color: grey">(f957ce4)</span></li>
<li>uploadprofilemodel.cpp <span style="color: grey">(bc5153f)</span></li>
<li>uploadprojectmodel.cpp <span style="color: grey">(c7ddacf)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121681/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>