<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121456/">https://git.reviewboard.kde.org/r/121456/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 16th, 2014, 12:04 p.m. UTC, <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121456/diff/4/?file=333326#file333326line614" style="color: black; font-weight: bold; text-decoration: underline;">debuggers/gdb/gdbcommand.cpp</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void GDBCommand::setStateReloading(bool f)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">614</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt">void</span> <span class="n">GDBCommand</span><span class="o">::</span><span class="n">markAsEnqueued</span><span class="p">()</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">this stuff is only for debugging purposes, or? should it really always run?</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes, the times are only for debugging the timing of the plugin and GDB. I could disable these calculation by a simple #ifdef _DEBUG?</p></pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 16th, 2014, 12:04 p.m. UTC, <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121456/diff/4/?file=333328#file333328line89" style="color: black; font-weight: bold; text-decoration: underline;">debuggers/gdb/gdbcommandqueue.cpp</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">89</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QMutableListIterator</span><span class="o"><</span><span class="n">GDBCommand</span><span class="o">*></span> <span class="n">it</span> <span class="o">=</span> <span class="n">m_commandList</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">if at all possible, I'd prefer stl-like iterators:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"><span style="color: #008000; font-weight: bold">auto</span> it <span style="color: #666666">=</span> m_commandList.begin();
<span style="color: #008000; font-weight: bold">while</span> (it <span style="color: #666666">!=</span> m_commandList.end()) {
<span style="color: #008000; font-weight: bold">auto</span> currentCmd <span style="color: #666666">=</span> <span style="color: #666666">*</span>it;
<span style="color: #008000; font-weight: bold">if</span> (...) {
delete currentCmd;
it <span style="color: #666666">=</span> m_commandList.erase(it);
} <span style="color: #008000; font-weight: bold">else</span> {
<span style="color: #666666">++</span>it;
}
}
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">but I now see that below the Java style was already used. anyhow, not that important</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I also prefer the stl iterators, but i used the existing function as template which uses the Java style.</p></pre>
<br />
<p>- Andreas</p>
<br />
<p>On December 15th, 2014, 7:29 a.m. UTC, Andreas Roth wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Andreas Roth.</div>
<p style="color: grey;"><i>Updated Dec. 15, 2014, 7:29 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevelop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Repo is available at https://github.com/aroth-arsoft/kdevelop/tree/4.7-gdb-enhancements
- switch the assembler flavor from AT&T to Intel and back in the dissassembler widget
- remove StackList commands from the queue when a new Exec command arrives. This reduces the wait time when stepping through the code quickly.
- remove duplicated command in the queue. Mostly to eliminate duplicate variable updates.
- show the pending command in the command queue. This is purely for debugging and to check which commands are currently pending.
- slight improvements to memory view to use sizeof() when no size argument is given</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Only preliminary testing done; haven't checked the unit-tests yets</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>debuggers/gdb/debugsession.cpp <span style="color: grey">(edc0d34473e99230db510457fd609a178bc8fa34)</span></li>
<li>debuggers/gdb/disassemblewidget.h <span style="color: grey">(ccffc2f0325aac8c8486ff413ed64219548461c3)</span></li>
<li>debuggers/gdb/disassemblewidget.cpp <span style="color: grey">(91194ed7e69ff87ebdfbb5383c1b38939760d098)</span></li>
<li>debuggers/gdb/gdb.cpp <span style="color: grey">(46420876149604a318caec7111f252dcc12b39b4)</span></li>
<li>debuggers/gdb/gdbcommand.h <span style="color: grey">(e1ebc6988fb508a187d2775735c13b9123fcda04)</span></li>
<li>debuggers/gdb/gdbcommand.cpp <span style="color: grey">(67abbd87f1f0d10a84a45b3ee9f104c77ffe925b)</span></li>
<li>debuggers/gdb/gdbcommandqueue.h <span style="color: grey">(7d82f45a244d9fffb9b3a2ba5a82eaaa06f5c8d0)</span></li>
<li>debuggers/gdb/gdbcommandqueue.cpp <span style="color: grey">(801bc41e79f62a226de04cd1a91500c86a9cf1a3)</span></li>
<li>debuggers/gdb/memviewdlg.cpp <span style="color: grey">(cf9d0b49ea0b617b405a5065354af9c9e59afa8d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121456/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>