<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121285/">https://git.reviewboard.kde.org/r/121285/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Big +1 from my side, once the patch in KActionCollection landed. There will definitely be another KF5 release before we ever can think about releasing a KF5 based KDevelop. So that really is not an issue (yet). I'm all for improving KF5 as much as possible for our usecase. Once we are comfortable, we can attach ourselfs to a concrete KF5 version dependency. Not yet though.</p></pre>
<br />
<p>- Milian Wolff</p>
<br />
<p>On November 28th, 2014, 8:58 p.m. UTC, Alexander Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Alexander Richardson.</div>
<p style="color: grey;"><i>Updated Nov. 28, 2014, 8:58 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Use new style connect in KActionCollection::addAction()</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This requires https://git.reviewboard.kde.org/r/121283/</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(eaf32e7234ba7530e363ef07e75970ec4d21c0cc)</span></li>
<li>language/codegen/applychangeswidget.cpp <span style="color: grey">(c6460db12e6faba1115d7eb23f940d9a837ecea8)</span></li>
<li>plugins/documentswitcher/documentswitcherplugin.cpp <span style="color: grey">(e4592377cc355c2a3f5d2f7b60c397094140de85)</span></li>
<li>shell/mainwindow_p.cpp <span style="color: grey">(82429aedaf7ff8d5692037e9c77c9028131b0c32)</span></li>
<li>plugins/appwizard/appwizardplugin.cpp <span style="color: grey">(e8e9472caa62370191647bdc6fbc456837f0e96f)</span></li>
<li>plugins/codeutils/codeutilsplugin.cpp <span style="color: grey">(49efa7731988dfa611049b8c75033da10e32462b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121285/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>