<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120317/">https://git.reviewboard.kde.org/r/120317/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yay! I only have one small issue regarding qDebug and the move of the environment configure button. Please let the latter stay in util/. That should work fine without any circular dependency, since util only links against interfaces, but not shell. So shell can link against util, if it doesn't do that already, no?</p></pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/120317/diff/10/?file=329531#file329531line453" style="color: black; font-weight: bold; text-decoration: underline;">plugins/execute/nativeappconfig.ui</a>
<span style="font-weight: normal;">
(Diff revision 10)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">453</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <header><span class="hl">uti</span>l/environmentconfigurebutton.h</header></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">453</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <header><span class="hl">shel</span>l/environmentconfigurebutton.h</header></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">this is wrong, it should still point to util/</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/120317/diff/10/?file=329551#file329551line163" style="color: black; font-weight: bold; text-decoration: underline;">shell/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 10)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">160</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="s">environmentconfigurebutton.h</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">ah, you moved that file - why?</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/120317/diff/10/?file=329575#file329575line104" style="color: black; font-weight: bold; text-decoration: underline;">shell/settings/pluginpreferences.cpp</a>
<span style="font-weight: normal;">
(Diff revision 10)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">PluginPreferences::PluginPreferences( QWidget *parent, const QVariantList &args )</pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">PluginPreferences::PluginPreferences(QWidget* parent)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">104</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KCModule</span><span class="o">::</span><span class="n">save</span><span class="p">();</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">91</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">qDebug</span><span class="p">()</span> <span class="o"><<</span> <span class="s">"Plugins before apply: "</span> <span class="o"><<</span> <span class="n">Core</span><span class="o">::</span><span class="n">self</span><span class="p">()</span><span class="o">-></span><span class="n">pluginControllerInternal</span><span class="p">()</span><span class="o">-></span><span class="n">allPluginNames</span><span class="p">();</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">here and everywhere else you use qDebug: either remove or use qCDebug please</p></pre>
</div>
</div>
<br />
<p>- Milian Wolff</p>
<br />
<p>On November 23rd, 2014, 11:38 a.m. UTC, Alexander Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Alexander Richardson.</div>
<p style="color: grey;"><i>Updated Nov. 23, 2014, 11:38 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Everything seems to work fine with the converted config pages.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is a huge diff, should I maybe push my changes to a new branch or to some other repository?</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Dialog is shown correctly, apply, okay work correctly.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Not sure why the first title is translated, AFAIK I don't have any KF5 translations installed (but maybe it loads it from my KDE4 installation?)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shell/CMakeLists.txt <span style="color: grey">(e4f2347e531fd1005bf8147b6db155e8bbc1972e)</span></li>
<li>shell/configdialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>project/projectkcmodule.h <span style="color: grey">(8c413bbe18d5f3b623ef72c897a1ba771e7d3a68)</span></li>
<li>plugins/templatemanager/templateconfig.h <span style="color: grey">(2dcab9075c16351fcccdf8725f4c96efd2ab1ca9)</span></li>
<li>plugins/templatemanager/templateconfig.cpp <span style="color: grey">(286bd7ccf20df6075eb915a66f9c5ce40c29b3d2)</span></li>
<li>plugins/templatemanager/templateconfig.ui <span style="color: grey">()</span></li>
<li>plugins/templatemanager/templatepage.h <span style="color: grey">(ed8a703e6919146b762d657e35d379c33687c74d)</span></li>
<li>plugins/templatemanager/templatepage.cpp <span style="color: grey">(1361a8d54f3732857e621b05113c0fa27f355b3f)</span></li>
<li>plugins/templatemanager/templatepage.ui <span style="color: grey">()</span></li>
<li>project/CMakeLists.txt <span style="color: grey">(948e7ffd8a1e4c8fd4982ed1ad208c7b616bc637)</span></li>
<li>project/interfaces/iprojectbuilder.h <span style="color: grey">(c47573a6867c3f81ced411bd973becc29b0c7b94)</span></li>
<li>project/projectconfigpage.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/execute/CMakeLists.txt <span style="color: grey">(00feea61444d52a67b6634f65c93545b3d426d93)</span></li>
<li>plugins/execute/nativeappconfig.cpp <span style="color: grey">(a1070715cc72e0851b45c1da6dab6c6c7bb9c10e)</span></li>
<li>plugins/execute/nativeappconfig.ui <span style="color: grey">(c7a3540047acf795ce4bab9212242dff274f83c3)</span></li>
<li>plugins/projectfilter/CMakeLists.txt <span style="color: grey">(77e746b075e81d2c0477b1bb547979d658197959)</span></li>
<li>plugins/projectfilter/kcm_kdevprojectfilter.desktop.cmake <span style="color: grey">(2d728b3fcb6b0cd8b6976771a214f270995bc2b7)</span></li>
<li>plugins/projectfilter/projectfilterkcm.h <span style="color: grey">(01d143469528117589c86853e5847fad6bc2aaaf)</span></li>
<li>plugins/projectfilter/projectfilterkcm.cpp <span style="color: grey">(4457066d6d9c2d67d1c3108183b6bc162bdae87a)</span></li>
<li>plugins/projectfilter/projectfilterprovider.h <span style="color: grey">(cb1fa978e0c40fcf8cf5e3fcaf73294c1b9d314e)</span></li>
<li>plugins/projectfilter/projectfilterprovider.cpp <span style="color: grey">(102a482de5377fdc4b21a81dcd5c12510c5c1e8c)</span></li>
<li>plugins/templatemanager/CMakeLists.txt <span style="color: grey">(5f42051e4fb6e153e9ccdaef1eb60187225777c9)</span></li>
<li>plugins/templatemanager/Messages.sh <span style="color: grey">()</span></li>
<li>plugins/templatemanager/kdevtemplatemanager_config.desktop.cmake <span style="color: grey">(018b2789eabe97d8ee9f2286783de92526c8a5ba)</span></li>
<li>CMakeLists.txt <span style="color: grey">(580159cfa6ac23cef48004837e7fe3ceea8fe6e3)</span></li>
<li>interfaces/CMakeLists.txt <span style="color: grey">(37c389e90ac37cb57d02a5ed218f67235bd9d6cd)</span></li>
<li>interfaces/configpage.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>interfaces/configpage.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>interfaces/iplugin.h <span style="color: grey">(54c688af8d8a2d016599599466e53a4b289dfa9b)</span></li>
<li>interfaces/iplugin.cpp <span style="color: grey">(800a63fa2f4a9887cd7493a84444197b494e743c)</span></li>
<li>plugins/CMakeLists.txt <span style="color: grey">(2028ebb45ad884ce52d785f9c0cdf5a81a136d8c)</span></li>
<li>shell/configdialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/editorconfigpage.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/editorconfigpage.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/plugincontroller.cpp <span style="color: grey">(a0adcddbe1b074adb6cc48c9073f8cde54653025)</span></li>
<li>shell/projectcontroller.h <span style="color: grey">(08cb7cbfec32cac918d674ed9a076ce9286ffd30)</span></li>
<li>shell/projectcontroller.cpp <span style="color: grey">(14da967059768fe0efb08b4afe7992e62a0586b8)</span></li>
<li>shell/settings/CMakeLists.txt <span style="color: grey">(c0988fb989e72db7b745c874f62fb620c11bd0ce)</span></li>
<li>shell/settings/bgconfig.kcfgc <span style="color: grey">(8dfe6e314a14972b725f97d341ce6fa5b2795349)</span></li>
<li>shell/settings/bgpreferences.h <span style="color: grey">(e516b6395beda6d964cea72c35e694038b84f71a)</span></li>
<li>shell/settings/bgpreferences.cpp <span style="color: grey">(a74acf445e687633bb0b5b410f5876ff45fa45af)</span></li>
<li>shell/settings/ccpreferences.h <span style="color: grey">(186b62a09e2fd10a9937689d919d05911e3d77e0)</span></li>
<li>shell/settings/ccpreferences.cpp <span style="color: grey">(710484dc6ffa7a4cfa14d3c6c9e2dd75cbc8bcf0)</span></li>
<li>shell/settings/environmentpreferences.h <span style="color: grey">(e7c84f4ec750ace28489829eced5bfc0b9c66718)</span></li>
<li>shell/settings/environmentpreferences.cpp <span style="color: grey">(3fdf16b2035c501d60faf2f9003025fd3b757203)</span></li>
<li>shell/settings/kcm_kdev_bgsettings.desktop.cmake <span style="color: grey">(374e041f35bf49422a76096fa15ced9e6dcef587)</span></li>
<li>shell/settings/kcm_kdev_ccsettings.desktop.cmake <span style="color: grey">(56f8394d7ff93bf755f3771471f9c8528bda9d98)</span></li>
<li>shell/settings/kcm_kdev_envsettings.desktop.cmake <span style="color: grey">(5fe88f5a9ddc90ae8cc6078e5b67b159ede5a2eb)</span></li>
<li>shell/settings/kcm_kdev_pluginsettings.desktop.cmake <span style="color: grey">(10d126ed24adc10d3e6f7183d7b97677c661287e)</span></li>
<li>shell/settings/kcm_kdev_projectsettings.desktop.cmake <span style="color: grey">(b1ac9bc4d59a2b3128745ceae79a3b66eda08245)</span></li>
<li>shell/settings/kcm_kdev_uisettings.desktop.cmake <span style="color: grey">(336e233c2cb1570a2d8523680938f1d094a9a915)</span></li>
<li>shell/settings/kcm_kdevsourceformattersettings.desktop.cmake <span style="color: grey">(6f22083488be2d4ad350ab5293a25c56e0797e43)</span></li>
<li>shell/settings/pluginpreferences.h <span style="color: grey">(12f9d233d9a06739ff0e460e5c41ff92f9431af3)</span></li>
<li>shell/settings/pluginpreferences.cpp <span style="color: grey">(b0d77d5f61caab17b6b2d243168c48c9b26fa40c)</span></li>
<li>shell/settings/projectconfig.kcfgc <span style="color: grey">(31355435eff9d2306ce98219095ecf02283cc2e9)</span></li>
<li>shell/settings/projectpreferences.h <span style="color: grey">(18a5357829a4293ba284868ca6be6c33134ef8da)</span></li>
<li>shell/settings/projectpreferences.cpp <span style="color: grey">(31e81de0dd97fb458953b700bdfc6c25a5cd9e2f)</span></li>
<li>shell/settings/sourceformattersettings.h <span style="color: grey">(e27933c45309ed763db24be1d0ed19d4a183e861)</span></li>
<li>shell/settings/sourceformattersettings.cpp <span style="color: grey">(b7daf38b930faa5bfd0bf265fee6f6c01d899bdd)</span></li>
<li>shell/settings/uipreferences.h <span style="color: grey">(34c46f3902cf06156c7f8279e6672ebb7a06a31e)</span></li>
<li>shell/settings/uipreferences.cpp <span style="color: grey">(c8ba26201516241e29f76db4c6e448de787c4704)</span></li>
<li>shell/uicontroller.h <span style="color: grey">(7d7c6622cd39a0570a5cd93ce6fd74f0f887c64b)</span></li>
<li>shell/uicontroller.cpp <span style="color: grey">(11ee89808dc6c7e4bff1c4e66ee8f29d02c0db51)</span></li>
<li>util/CMakeLists.txt <span style="color: grey">(9903178297ca5f6fdb391f92792b27b94797b407)</span></li>
<li>util/environmentconfigurebutton.h <span style="color: grey">(9a6503801cb9cdb9384bb68ac8cc7cd4559c12d9)</span></li>
<li>util/environmentconfigurebutton.cpp <span style="color: grey">(9abbd033c2fc346a20c5583e38dc0f41ee15b7f1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120317/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/7e219540-1632-4465-9675-ad24a2fde56c__kdev_config_new.png">kdev_config_new.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/f4f16e26-e6dd-4c98-9969-588342f85f4c__kdev_config_new1.png">kdev_config_new1.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/09/25/7130af0f-5e23-45cf-b781-ebe318be8369__kdev_config_new2.png">plugin enabled -> entry exists</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/09/25/dff38c1f-2b3d-4ab7-a97d-adff0a99bb3d__kdev_config_new3.png">plugin unloaded -> entry disappears</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>