<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121129/">https://git.reviewboard.kde.org/r/121129/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ship It!</p></pre>
<br />
<p>- Aleix Pol Gonzalez</p>
<br />
<p>On November 16th, 2014, 1:57 p.m. UTC, Kevin Funk wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Kevin Funk.</div>
<p style="color: grey;"><i>Updated Nov. 16, 2014, 1:57 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Some parts/plugins were left out, because I did not verify everything
was working after the porting scripts did their job
- plugins/cvs - (don't even know how to trigger the code path)
- plugins/subversion (lot's of dialogs involved)
- plugins/snippet/legacy/ (will be dropped anyway, not worth it)
- plugins/dashboard (not built, what's the state of that anyway?)
For the rest of dialogs, ported in this patch, I manually tested each
of them. So everything should still be working as expected.
Still putting this up for review to have another pair of eyes on the patch.
REVIEW: 121128</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>vcs/widgets/vcscommitdialog.h <span style="color: grey">(c3b1dd171c78e46a8fbb6f73bafd9a144d3c4d7c)</span></li>
<li>vcs/widgets/vcscommitdialog.cpp <span style="color: grey">(77224786235f845edb84e796def20d119f2cca95)</span></li>
<li>vcs/widgets/vcscommitdialog.ui <span style="color: grey">(f32f8a2a9504deff2cbe2a9c9aab40e4e79baa67)</span></li>
<li>vcs/widgets/vcseventwidget.cpp <span style="color: grey">(c4ccda16163acfa63f189fb111e4dc7a3616a5ee)</span></li>
<li>vcs/dvcs/dvcsplugin.cpp <span style="color: grey">(7a9dcde7b74d3acca1c8871684d81d15cda31f6a)</span></li>
<li>vcs/dvcs/ui/branchmanager.h <span style="color: grey">(ef842f0506727f28db8a102a7f9a70173ba9a8c8)</span></li>
<li>vcs/dvcs/ui/branchmanager.cpp <span style="color: grey">(6827f3f0c623ca2234c159ae1a1bbcfb0a3d2de1)</span></li>
<li>vcs/vcspluginhelper.cpp <span style="color: grey">(a4dfec71dd2127a31f9a389120558cbcb92f05b6)</span></li>
<li>shell/uicontroller.cpp <span style="color: grey">(014fa83982fbe0d7bbf73827bd85b2dec2348c54)</span></li>
<li>sublime/idealdockwidget.cpp <span style="color: grey">(b1d2b4ea5cf156bbe1fb0e90ad4d3f96490ee2cb)</span></li>
<li>util/environmentconfigurebutton.cpp <span style="color: grey">(7ff85aae0cb71254fd7b8420b597edb7af195fed)</span></li>
<li>shell/settings/editstyledialog.h <span style="color: grey">(8de5a194c6b24b6e166d66c7194b83ce1516f2b7)</span></li>
<li>shell/settings/editstyledialog.cpp <span style="color: grey">(3d7f2dcbb9aed1f841bf6e9f7724adc8a8ba6b67)</span></li>
<li>shell/settings/environmentwidget.cpp <span style="color: grey">(34558a12195c8c2cc8f890a8ba783d5cbd2e9a9d)</span></li>
<li>shell/settings/sourceformattersettings.cpp <span style="color: grey">(4908eaad29c75206e2443aff617c897fee5b353f)</span></li>
<li>shell/sessionchooserdialog.cpp <span style="color: grey">(2c830890398ebf5411a8ac697a637c75d1c72fec)</span></li>
<li>shell/sessioncontroller.cpp <span style="color: grey">(883cb8a505fcad7c9a1a89132ad49ddb954dfba2)</span></li>
<li>shell/sessiondialog.h <span style="color: grey">(500e9f64f7c5931994277ed265b37777c9755e34)</span></li>
<li>shell/sessiondialog.cpp <span style="color: grey">(db92c056e465f1b889744ee8d82828187bd63816)</span></li>
<li>shell/sessiondialog.ui <span style="color: grey">(711c7d72ac00fc1aa529004328edc49e8edf7d4c)</span></li>
<li>shell/plugincontroller.cpp <span style="color: grey">(898c2e3aeb9ddca1b5bea65680e8003e242f9c07)</span></li>
<li>shell/projectcontroller.cpp <span style="color: grey">(6216f1d01c17eb9827d69415a00fd0258959f419)</span></li>
<li>shell/savedialog.h <span style="color: grey">(a01a17047abc78b838d5327ead6c5562b65d257b)</span></li>
<li>shell/savedialog.cpp <span style="color: grey">(eb3812de0cbdb65d2d30f4ba513d9150de6d995d)</span></li>
<li>shell/sessionchooserdialog.h <span style="color: grey">(e1e4e4d09be0537e83674efcb895488cf040ef11)</span></li>
<li>shell/loadedpluginsdialog.cpp <span style="color: grey">(8ed884eef7a1c71ae5bba0c09efc729e4f1a3c46)</span></li>
<li>shell/openprojectdialog.cpp <span style="color: grey">(07893ca99dd67b4348198362736ca2dd61102064)</span></li>
<li>shell/loadedpluginsdialog.h <span style="color: grey">(5aff5fcd031c4e2004187fc2f71fd0405f59aa86)</span></li>
<li>shell/launchconfigurationdialog.ui <span style="color: grey">(87c79c037c64cd5913fd8d59dae4b2444e7b72eb)</span></li>
<li>plugins/snippet/snippetplugin.cpp <span style="color: grey">(724c9cdf4bf61b0f56cda1773a1691d20718448b)</span></li>
<li>project/projectitemlineedit.cpp <span style="color: grey">(9e9824a7a16baf91e7cf072d8bb70fa238197452)</span></li>
<li>shell/launchconfigurationdialog.h <span style="color: grey">(b0a7d32929f0c61931966a55ac45c8c5d3042dc7)</span></li>
<li>shell/launchconfigurationdialog.cpp <span style="color: grey">(c6eefc320a563f4f3fba7a259822c8ee2d58e4c8)</span></li>
<li>plugins/reviewboard/reviewpatchdialog.h <span style="color: grey">(b55ee41094bfe49d04b374fc01e47db96fa6d800)</span></li>
<li>plugins/reviewboard/reviewpatchdialog.cpp <span style="color: grey">(2d0c191defff01dbabd027e8fea804b483f855c0)</span></li>
<li>plugins/git/stashmanagerdialog.h <span style="color: grey">(5eda0caee8b685fe1d8c7e5990fc7d67673b6a62)</span></li>
<li>plugins/git/stashmanagerdialog.cpp <span style="color: grey">(16a09c1b804fc00e00fe4f5e9836a58b65c0c986)</span></li>
<li>plugins/git/stashmanagerdialog.ui <span style="color: grey">(51d6def44d25a2deeb40a667b39e537d5b333fa0)</span></li>
<li>plugins/quickopen/quickopenplugin.cpp <span style="color: grey">(a8eaba0b4ea44e2c95d3e4ef08fef2e6ce5cb9eb)</span></li>
<li>plugins/reviewboard/reviewboardplugin.cpp <span style="color: grey">(c19f6868742435853784871a57b5986b070988f3)</span></li>
<li>plugins/reviewboard/reviewpatch.ui <span style="color: grey">(8e11f5c09e41fab6471bc0ae3de36404e86133cf)</span></li>
<li>language/codegen/applychangeswidget.cpp <span style="color: grey">(722fc7a9949da80cab88b45b7450c9750d7ad953)</span></li>
<li>plugins/externalscript/editexternalscript.h <span style="color: grey">(ecaa1af5c9f26588d265fda288772f69df9a3232)</span></li>
<li>plugins/externalscript/editexternalscript.cpp <span style="color: grey">(4165b25ed67103dfccfacda57124660249be0e1f)</span></li>
<li>plugins/externalscript/editexternalscript.ui <span style="color: grey">(b8bff47f89d73c4480567a070faa560d5078f6c1)</span></li>
<li>plugins/externalscript/externalscriptview.cpp <span style="color: grey">(07a6ee083b93cf348432a9e660e8fda90b37f7d7)</span></li>
<li>plugins/filetemplates/templateclassassistant.cpp <span style="color: grey">(51ffae6c19d568a832fa39c299da3143b54b39b3)</span></li>
<li>language/codegen/applychangeswidget.h <span style="color: grey">(d947f8dd83260a7771b6aaf3ae589ed942de7a89)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121129/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>