<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121037/">https://git.reviewboard.kde.org/r/121037/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 8th, 2014, 12:44 p.m. UTC, <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121037/diff/1/?file=326730#file326730line185" style="color: black; font-weight: bold; text-decoration: underline;">sublime/controller.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">Q_SIGNALS:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">183</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">void</span> <span class="nf">removeArea</span><span class="p">(</span><span class="n">QObject</span><span class="o">*</span><span class="p">);</span> <span class="c1">// called by Sublime::Area</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I dislike that. could you instead use a lambda where appropriate? Or alternatively make signature typesafe and use a lambda to do the casting.</p></pre>
</blockquote>
<p>On November 8th, 2014, 1:45 p.m. UTC, <b>Alexander Richardson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The best thing would be to use ObjectList from kdevplatformutil, but I don't think that dependency is allowed.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Would it make sense to contribute it to KCoreAddons?</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">maybe. but for now please do the above do not hold the rest of the patch up.</p></pre>
<br />
<p>- Milian</p>
<br />
<p>On November 7th, 2014, 5:34 p.m. UTC, Alexander Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Alexander Richardson.</div>
<p style="color: grey;"><i>Updated Nov. 7, 2014, 5:34 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Convert sublime/ to Qt5 signal/slot syntax</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>sublime/area.cpp <span style="color: grey">(62dd90c446eb7b034bc481a6ba05e2ca85959be4)</span></li>
<li>sublime/container.cpp <span style="color: grey">(9db2c40fb3796a2a63648c48268685d8bf814355)</span></li>
<li>sublime/controller.h <span style="color: grey">(a36163118ac9a38b5ae997aa70b3e556c91cdde8)</span></li>
<li>sublime/controller.cpp <span style="color: grey">(bd50d0533a92feaf1e90da9fc388b516c849bfc5)</span></li>
<li>sublime/document.cpp <span style="color: grey">(780653a08c61db88d963e3329e2837f58dbc4bd1)</span></li>
<li>sublime/examples/example1main.cpp <span style="color: grey">(8ece5cca4c09a82d5b3b12291dc048a47497ac76)</span></li>
<li>sublime/idealbuttonbarwidget.cpp <span style="color: grey">(21ac2e2997c2a3e4346284d5413386f3318d6ecc)</span></li>
<li>sublime/idealcontroller.cpp <span style="color: grey">(f8b67acbc9a0d7bbae5429c93cf44bdc374dd96e)</span></li>
<li>sublime/idealdockwidget.cpp <span style="color: grey">(897862b6428f280b0ce5ba8620237527972d4cbf)</span></li>
<li>sublime/mainwindow.cpp <span style="color: grey">(6f760d6ab7c139eb5ebb71828eca26963100bbcd)</span></li>
<li>sublime/mainwindow_p.cpp <span style="color: grey">(b2982eb085df288155d00a32a26a02ad6c386737)</span></li>
<li>sublime/view.cpp <span style="color: grey">(ab95ed78568a0fdfb2bd56c50e55bd7174f885b0)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121037/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>