<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121040/">https://git.reviewboard.kde.org/r/121040/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121040/diff/1/?file=326770#file326770line59" style="color: black; font-weight: bold; text-decoration: underline;">debugger/framestack/framestackwidget.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">59</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c1">//</span><span class="cs">TODO</span><span class="c1">: shouldn't this signal be in IDebugController? Otherwise we are effectively depending on it being a DebugController here</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">yup that sounds correct</p></pre>
</div>
</div>
<br />
<p>- Milian Wolff</p>
<br />
<p>On November 7th, 2014, 5:34 p.m. UTC, Alexander Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Alexander Richardson.</div>
<p style="color: grey;"><i>Updated Nov. 7, 2014, 5:34 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">convert debugger/ to new signal/slot syntax</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>debugger/util/treeview.cpp <span style="color: grey">(ede55c59d496de2db43aa4263552ad253a562d51)</span></li>
<li>debugger/variable/variablecollection.cpp <span style="color: grey">(46196b0af61fa70be5c6e32cc23949133364b97b)</span></li>
<li>debugger/variable/variabletooltip.cpp <span style="color: grey">(2ceecc7ed72b1d1895b32cab17b88577bce0e04f)</span></li>
<li>debugger/variable/variablewidget.cpp <span style="color: grey">(6ab0726095b865ed9ece09c36ec090effe67552c)</span></li>
<li>debugger/framestack/framestackmodel.cpp <span style="color: grey">(b698df747bcc70bc21d49899d4d5b5ecb26b431f)</span></li>
<li>debugger/framestack/framestackwidget.cpp <span style="color: grey">(1db87f666adef5fff307a0f2f94299d365fcce66)</span></li>
<li>debugger/interfaces/ibreakpointcontroller.cpp <span style="color: grey">(8e925d9612a286b60bcd60b828cbbcf0937f1afa)</span></li>
<li>debugger/interfaces/idebugsession.cpp <span style="color: grey">(8a376afc0a4f825ba8708283701adc7f4862367e)</span></li>
<li>debugger/interfaces/ivariablecontroller.cpp <span style="color: grey">(5407ef6cbd54050c43d7f4f6cfc5cfae598c4046)</span></li>
<li>debugger/util/pathmappings.cpp <span style="color: grey">(f540bfc572d9084a73b95483e6db790a76027d68)</span></li>
<li>debugger/util/treemodel.cpp <span style="color: grey">(a9ff1b61756948fa39fcbcf88c024838c2fd6e54)</span></li>
<li>debugger/breakpoint/breakpointdetails.cpp <span style="color: grey">(c58356d3081bae6eb504ac2d20d023153259f3e9)</span></li>
<li>debugger/breakpoint/breakpointmodel.cpp <span style="color: grey">(5bb7af1de52fab55735a62ffce4670f82c227130)</span></li>
<li>debugger/breakpoint/breakpointwidget.cpp <span style="color: grey">(6e8d588ce6be00ac14b51ab232098d1b96391edc)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121040/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>