<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121036/">https://git.reviewboard.kde.org/r/121036/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 8th, 2014, 10:27 vorm. CET, <b>Kevin Funk</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121036/diff/1/?file=326725#file326725line67" style="color: black; font-weight: bold; text-decoration: underline;">util/objectlist.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">ObjectListTracker::~ObjectListTracker()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">67</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">connect</span><span class="p">(</span><span class="n">object</span><span class="p">,</span> <span class="n"><span class="hl">SIGNAL</span></span><span class="p"><span class="hl">(</span></span><span class="n">destroyed</span><span class="p"><span class="hl">(</span></span><span class="n"><span class="hl">QObject</span></span><span class="o"><span class="hl">*</span></span><span class="p"><span class="hl">))</span>,</span> <span class="k">this</span><span class="p">,</span> <span class="n"><span class="hl">SLOT</span></span><span class="p"><span class="hl">(</span></span><span class="n">objectDestroyed</span><span class="p"><span class="hl">(</span></span><span class="n"><span class="hl">QObject</span></span><span class="o"><span class="hl">*</span></span><span class="p"><span class="hl">))</span>);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">65</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">connect</span><span class="p">(</span><span class="n">object</span><span class="p">,</span> <span class="o"><span class="hl">&</span></span><span class="n"><span class="hl">QObject</span></span><span class="o"><span class="hl">::</span></span><span class="n">destroyed</span><span class="p">,</span> <span class="k">this</span><span class="p">,</span> <span class="o"><span class="hl">&</span></span><span class="n"><span class="hl">ObjectListTracker</span></span><span class="o"><span class="hl">::</span></span><span class="n">objectDestroyed</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hm, why do you add the private method in the public header? Can't you use a lambda as slot here, too?</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The we would need to store all the <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">QMetaObject::Connection</code>s that are returned by the connect call with the lambda. disconnect() only works with pointer-to-member</p></pre>
<br />
<p>- Alexander</p>
<br />
<p>On November 7th, 2014, 6:34 nachm. CET, Alexander Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Alexander Richardson.</div>
<p style="color: grey;"><i>Updated Nov. 7, 2014, 6:34 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Convert util/ to Qt5 signal/slot syntax</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>util/duchainify/main.cpp <span style="color: grey">(fb0ae318e40a80ce9dc60386e4672663acb1961e)</span></li>
<li>util/environmentconfigurebutton.cpp <span style="color: grey">(23703e95ef1ebdb1f5d0bfa087dd9ca297f9dae1)</span></li>
<li>util/focusedtreeview.cpp <span style="color: grey">(9050c30469a4834ab654128811905f3d0005adf5)</span></li>
<li>util/multilevellistview.cpp <span style="color: grey">(cb5f08c85bdcddcaafdac716566a8f7c78da0322)</span></li>
<li>util/objectlist.h <span style="color: grey">(43ec0f474b7423de9b86eeb54928f660513492c7)</span></li>
<li>util/objectlist.cpp <span style="color: grey">(c4b01af408866004ca6f40bf1b6dc44eb9a8405e)</span></li>
<li>util/processlinemaker.cpp <span style="color: grey">(f95d3781832e63f4c3a50156ea91c6c4bbb05eb6)</span></li>
<li>util/projecttestjob.cpp <span style="color: grey">(677c88b6750d5f59d6d9f32a288e5ee9f9249043)</span></li>
<li>util/commandexecutor.cpp <span style="color: grey">(097868aa6044d5ce603626d1663f825a347dbe78)</span></li>
<li>util/activetooltip.cpp <span style="color: grey">(0357842268d989d9f6c2008d5df239bd4a0f8432)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121036/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>