<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121050/">https://git.reviewboard.kde.org/r/121050/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121050/diff/1/?file=327119#file327119line49" style="color: black; font-weight: bold; text-decoration: underline;">projectmanagers/custom-buildsystem/configwidget.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">ConfigWidget::ConfigWidget( QWidget* parent )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">49</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">connect</span><span class="p">(</span> <span class="n">ui</span><span class="o">-></span><span class="n">actionEnvironment</span><span class="p">,</span> <span class="n">SIGNAL</span><span class="p">(</span><span class="n">activated</span><span class="p">(</span><span class="kt">int</span><span class="p">)),</span> <span class="n">SLOT</span><span class="p">(</span><span class="n">actionEnvironmentChanged</span><span class="p">(</span><span class="kt">int</span><span class="p">))</span> <span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">49</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">connect</span><span class="p">(</span> <span class="n">ui</span><span class="o">-></span><span class="n">actionEnvironment</span><span class="p">,</span> <span class="o">&</span><span class="n">KDevelop</span><span class="o">::</span><span class="n">EnvironmentSelectionWidget</span><span class="o">::</span><span class="n">currentProfileChanged</span><span class="p">,</span> <span class="k">this</span><span class="p">,</span> <span class="o">&</span><span class="n">ConfigWidget</span><span class="o">::</span><span class="n">actionEnvironmentChanged</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Style: s/KDevelop:://</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121050/diff/1/?file=327120#file327120line133" style="color: black; font-weight: bold; text-decoration: underline;">projectmanagers/custom-buildsystem/custombuildjob.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void CustomBuildJob::start()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">133</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">connect</span><span class="p">(</span> <span class="n">exec</span><span class="p">,</span> <span class="n"><span class="hl">SIGNAL</span></span><span class="p"><span class="hl">(</span></span><span class="n">receivedStandardError</span><span class="p"><span class="hl">(</span></span><span class="n"><span class="hl">QStringList</span></span><span class="p"><span class="hl">))</span>,</span> <span class="n">model</span><span class="p">,</span> <span class="n"><span class="hl">SLOT</span></span><span class="p"><span class="hl">(</span></span><span class="n">appendLines</span><span class="p"><span class="hl">(</span></span><span class="n"><span class="hl">QStringList</span></span><span class="p"><span class="hl">))</span></span> <span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">133</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">connect</span><span class="p">(</span> <span class="n">exec</span><span class="p">,</span> <span class="o"><span class="hl">&</span></span><span class="n"><span class="hl">KDevelop</span></span><span class="o"><span class="hl">::</span></span><span class="n"><span class="hl">CommandExecutor</span></span><span class="o"><span class="hl">::</span></span><span class="n">receivedStandardError</span><span class="p">,</span> <span class="n">model</span><span class="p">,</span> <span class="o"><span class="hl">&</span></span><span class="n"><span class="hl">KDevelop</span></span><span class="o"><span class="hl">::</span></span><span class="n"><span class="hl">OutputModel</span></span><span class="o"><span class="hl">::</span></span><span class="n">appendLines</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Same here</p></pre>
</div>
</div>
<br />
<p>- Kevin Funk</p>
<br />
<p>On November 7th, 2014, 6:25 p.m. UTC, Alexander Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Alexander Richardson.</div>
<p style="color: grey;"><i>Updated Nov. 7, 2014, 6:25 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevelop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">convert projectmanagers/ to new signal/slot syntax</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>projectmanagers/custommake/custommakemanager.cpp <span style="color: grey">(0e69f02ae5ca8e53e3005aed5db1cdbb37ee6408)</span></li>
<li>projectmanagers/custom-buildsystem/tests/kcmuitestmain.cpp <span style="color: grey">(a98575f489623fd1883d47f0036a90d99cf1e24e)</span></li>
<li>projectmanagers/custom-buildsystem/kcm_custombuildsystem.cpp <span style="color: grey">(7f03fd700795dfc402cde2fbd243494fc158164a)</span></li>
<li>projectmanagers/custom-buildsystem/custombuildsystemconfigwidget.cpp <span style="color: grey">(c0c366e26441eebdac760c62bc8425f38749c356)</span></li>
<li>projectmanagers/custom-buildsystem/custombuildjob.cpp <span style="color: grey">(6300245d90e416e359b5921a50c5c5d7b938994b)</span></li>
<li>projectmanagers/custom-buildsystem/configwidget.cpp <span style="color: grey">(9460ba34dfa8ad459be4b6c2087809b3b0f54f17)</span></li>
<li>projectmanagers/custom-buildsystem/configwidget.h <span style="color: grey">(8c0e29626cde1c22919c6a080b26e5dc2e51875a)</span></li>
<li>projectmanagers/cmake/tests/kdevprojectopen.cpp <span style="color: grey">(7ec874281a8416e230a7c7d62a6222a5bcff9de3)</span></li>
<li>projectmanagers/cmake/settings/cmakepreferences.cpp <span style="color: grey">(0411cecf0b7eb43577dedf3e5dc6c6bb9ebfacbe)</span></li>
<li>projectmanagers/cmake/settings/cmakecachemodel.h <span style="color: grey">(a4c71a2e446032fcb637231f1a84571876c57216)</span></li>
<li>projectmanagers/cmake/settings/cmakecachedelegate.cpp <span style="color: grey">(eb7fc66bdcf3c59fc5aa1454b558c95107b51558)</span></li>
<li>projectmanagers/cmake/cmakemanager.cpp <span style="color: grey">(752c9c32c58616c916b6cf0df940433400833d88)</span></li>
<li>projectmanagers/cmake/cmakeimportjsonjob.cpp <span style="color: grey">(5644562fc73360e0019d253feb2320b5dae26107)</span></li>
<li>projectmanagers/cmake/cmakehelpdocumentation.cpp <span style="color: grey">(bb0419ec404f4d953fb9982f2d34c02ed4b28611)</span></li>
<li>projectmanagers/cmake/cmakebuilddirchooser.cpp <span style="color: grey">(96ac8626fbfb5c45cbf4d13c6f33ea719321abff)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121050/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>