<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120317/">https://git.reviewboard.kde.org/r/120317/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Alexander Richardson.</div>
<p style="color: grey;"><i>Updated Nov. 8, 2014, 9:37 nachm.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">rebased on latest master + addressed comments</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Everything seems to work fine with the converted config pages.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is a huge diff, should I maybe push my changes to a new branch or to some other repository?</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Dialog is shown correctly, apply, okay work correctly.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Not sure why the first title is translated, AFAIK I don't have any KF5 translations installed (but maybe it loads it from my KDE4 installation?)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shell/settings/kcm_kdev_uisettings.desktop.cmake <span style="color: grey">(336e233c2cb1570a2d8523680938f1d094a9a915)</span></li>
<li>shell/settings/kcm_kdevsourceformattersettings.desktop.cmake <span style="color: grey">(6f22083488be2d4ad350ab5293a25c56e0797e43)</span></li>
<li>shell/settings/pluginpreferences.h <span style="color: grey">(12f9d233d9a06739ff0e460e5c41ff92f9431af3)</span></li>
<li>shell/settings/pluginpreferences.cpp <span style="color: grey">(49a4c4a744095a1030976e5b93d1d16a54531a6e)</span></li>
<li>shell/settings/projectconfig.kcfgc <span style="color: grey">(31355435eff9d2306ce98219095ecf02283cc2e9)</span></li>
<li>shell/settings/projectpreferences.h <span style="color: grey">(18a5357829a4293ba284868ca6be6c33134ef8da)</span></li>
<li>shell/settings/projectpreferences.cpp <span style="color: grey">(807819f8bdb261a24f79056aa4704fc8c38a2c10)</span></li>
<li>shell/settings/bgpreferences.h <span style="color: grey">(e516b6395beda6d964cea72c35e694038b84f71a)</span></li>
<li>shell/settings/bgpreferences.cpp <span style="color: grey">(5f5332855d7d6189899cf4e879dd92e3ef48e188)</span></li>
<li>shell/settings/ccpreferences.h <span style="color: grey">(186b62a09e2fd10a9937689d919d05911e3d77e0)</span></li>
<li>shell/settings/ccpreferences.cpp <span style="color: grey">(0817977482f688d1f12d30f4eaa1e67166b70de0)</span></li>
<li>shell/settings/environmentpreferences.h <span style="color: grey">(e7c84f4ec750ace28489829eced5bfc0b9c66718)</span></li>
<li>shell/settings/environmentpreferences.cpp <span style="color: grey">(3fdf16b2035c501d60faf2f9003025fd3b757203)</span></li>
<li>shell/settings/kcm_kdev_bgsettings.desktop.cmake <span style="color: grey">(374e041f35bf49422a76096fa15ced9e6dcef587)</span></li>
<li>shell/settings/kcm_kdev_ccsettings.desktop.cmake <span style="color: grey">(56f8394d7ff93bf755f3771471f9c8528bda9d98)</span></li>
<li>shell/settings/kcm_kdev_envsettings.desktop.cmake <span style="color: grey">(5fe88f5a9ddc90ae8cc6078e5b67b159ede5a2eb)</span></li>
<li>shell/settings/kcm_kdev_pluginsettings.desktop.cmake <span style="color: grey">(10d126ed24adc10d3e6f7183d7b97677c661287e)</span></li>
<li>shell/settings/kcm_kdev_projectsettings.desktop.cmake <span style="color: grey">(b1ac9bc4d59a2b3128745ceae79a3b66eda08245)</span></li>
<li>shell/settings/bgconfig.kcfgc <span style="color: grey">(8dfe6e314a14972b725f97d341ce6fa5b2795349)</span></li>
<li>util/CMakeLists.txt <span style="color: grey">(d88b7e2a30a11073f690007b8fd2f7f577515416)</span></li>
<li>util/environmentconfigurebutton.h <span style="color: grey">(9a6503801cb9cdb9384bb68ac8cc7cd4559c12d9)</span></li>
<li>util/environmentconfigurebutton.cpp <span style="color: grey">(7ff85aae0cb71254fd7b8420b597edb7af195fed)</span></li>
<li>shell/settings/sourceformattersettings.h <span style="color: grey">(e27933c45309ed763db24be1d0ed19d4a183e861)</span></li>
<li>shell/settings/sourceformattersettings.cpp <span style="color: grey">(4908eaad29c75206e2443aff617c897fee5b353f)</span></li>
<li>shell/settings/uipreferences.h <span style="color: grey">(34c46f3902cf06156c7f8279e6672ebb7a06a31e)</span></li>
<li>shell/settings/uipreferences.cpp <span style="color: grey">(c8ba26201516241e29f76db4c6e448de787c4704)</span></li>
<li>shell/uicontroller.h <span style="color: grey">(797fa198ed17608e88f2a9e9a03f8072c5ebf45d)</span></li>
<li>shell/uicontroller.cpp <span style="color: grey">(0898d333848117dfe6be9cf9b5d03ce0ad62d5ea)</span></li>
<li>shell/projectcontroller.h <span style="color: grey">(08cb7cbfec32cac918d674ed9a076ce9286ffd30)</span></li>
<li>shell/projectcontroller.cpp <span style="color: grey">(d6c3e297f157e10a8efa0cbf67e5c70dc131ac83)</span></li>
<li>shell/settings/CMakeLists.txt <span style="color: grey">(adde8f22976732e5e5280cea3289caddd40f8b94)</span></li>
<li>shell/configdialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/configdialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/editorconfigpage.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/editorconfigpage.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/plugincontroller.cpp <span style="color: grey">(898c2e3aeb9ddca1b5bea65680e8003e242f9c07)</span></li>
<li>project/projectkcmodule.h <span style="color: grey">(fe40e9c3ad05963a5c7986110d1d4cb3e3fa5438)</span></li>
<li>shell/CMakeLists.txt <span style="color: grey">(d30897867af75bda6054852925ae39f8b08c80b7)</span></li>
<li>plugins/templatemanager/Messages.sh <span style="color: grey">()</span></li>
<li>plugins/templatemanager/kdevtemplatemanager_config.desktop.cmake <span style="color: grey">(018b2789eabe97d8ee9f2286783de92526c8a5ba)</span></li>
<li>plugins/templatemanager/templateconfig.h <span style="color: grey">(2dcab9075c16351fcccdf8725f4c96efd2ab1ca9)</span></li>
<li>plugins/templatemanager/templateconfig.cpp <span style="color: grey">(286bd7ccf20df6075eb915a66f9c5ce40c29b3d2)</span></li>
<li>plugins/templatemanager/templateconfig.ui <span style="color: grey">()</span></li>
<li>plugins/templatemanager/templatepage.h <span style="color: grey">(ed8a703e6919146b762d657e35d379c33687c74d)</span></li>
<li>plugins/templatemanager/templatepage.cpp <span style="color: grey">(93cff9a030f8bea233008c36710cd312db02b905)</span></li>
<li>plugins/templatemanager/templatepage.ui <span style="color: grey">()</span></li>
<li>project/CMakeLists.txt <span style="color: grey">(5b71fcc0d85712660b7c195bca6399b9dc392a1e)</span></li>
<li>project/interfaces/iprojectbuilder.h <span style="color: grey">(c47573a6867c3f81ced411bd973becc29b0c7b94)</span></li>
<li>project/projectconfigpage.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>CMakeLists.txt <span style="color: grey">(b749e9deeeae164f92d959194302cf892e42bdc7)</span></li>
<li>interfaces/CMakeLists.txt <span style="color: grey">(6763ce44e2d41380820773ed96f14865264b3ffb)</span></li>
<li>interfaces/configpage.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>interfaces/configpage.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>interfaces/iplugin.h <span style="color: grey">(090f2f3c2cb63050958b77951c225b6e8e9ac50a)</span></li>
<li>interfaces/iplugin.cpp <span style="color: grey">(4511a207b38cb331e86838bf3b3bbe957cb3864a)</span></li>
<li>plugins/CMakeLists.txt <span style="color: grey">(46a0b471e6dd06889ef510a1e7b0c18157345157)</span></li>
<li>plugins/execute/CMakeLists.txt <span style="color: grey">(3bb38a5d0279e21997513df205e170183d343b20)</span></li>
<li>plugins/execute/nativeappconfig.cpp <span style="color: grey">(bd8883e8093e5dfa5d563907c4fc20c563e77283)</span></li>
<li>plugins/execute/nativeappconfig.ui <span style="color: grey">(c7a3540047acf795ce4bab9212242dff274f83c3)</span></li>
<li>plugins/projectfilter/CMakeLists.txt <span style="color: grey">(7021328470cf1698fff01b2084a7458f5cc4f90c)</span></li>
<li>plugins/projectfilter/kcm_kdevprojectfilter.desktop.cmake <span style="color: grey">(2d728b3fcb6b0cd8b6976771a214f270995bc2b7)</span></li>
<li>plugins/projectfilter/projectfilterkcm.h <span style="color: grey">(01d143469528117589c86853e5847fad6bc2aaaf)</span></li>
<li>plugins/projectfilter/projectfilterkcm.cpp <span style="color: grey">(7eaba23ca09bfedb76fde50a4ff02b28b009c31a)</span></li>
<li>plugins/projectfilter/projectfilterprovider.h <span style="color: grey">(cb1fa978e0c40fcf8cf5e3fcaf73294c1b9d314e)</span></li>
<li>plugins/projectfilter/projectfilterprovider.cpp <span style="color: grey">(e22198349f02675572b1396e7a02bac1b43d2eb8)</span></li>
<li>plugins/templatemanager/CMakeLists.txt <span style="color: grey">(5d0eec1fd6457aefee776a2bff866cf4d27d08a9)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120317/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/7e219540-1632-4465-9675-ad24a2fde56c__kdev_config_new.png">kdev_config_new.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/f4f16e26-e6dd-4c98-9969-588342f85f4c__kdev_config_new1.png">kdev_config_new1.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/09/25/7130af0f-5e23-45cf-b781-ebe318be8369__kdev_config_new2.png">plugin enabled -> entry exists</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/09/25/dff38c1f-2b3d-4ab7-a97d-adff0a99bb3d__kdev_config_new3.png">plugin unloaded -> entry disappears</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>