<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121046/">https://git.reviewboard.kde.org/r/121046/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121046/diff/1/?file=326938#file326938line12" style="color: black; font-weight: bold; text-decoration: underline;">plugins/standardoutputview/tests/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">12</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">configure_file</span><span class="p">(</span><span class="s">../kdevstandardoutputview.desktop.cmake</span> <span class="o">${</span><span class="nv">CMAKE_CURRENT_BINARY_DIR</span><span class="o">}</span><span class="s">/kdevstandardoutputview.desktop</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hm, ugly to replicate the logic from ../CMakeLists.txt here. No other way?</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121046/diff/1/?file=326946#file326946line27" style="color: black; font-weight: bold; text-decoration: underline;">plugins/welcomepage/sessionsmodel.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">27</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">connect</span><span class="p">(</span><span class="n">KDevelop</span><span class="o">::</span><span class="n">Core</span><span class="o">::</span><span class="n">self</span><span class="p">()</span><span class="o">-></span><span class="n">sessionController</span><span class="p">(),</span> <span class="n"><span class="hl">SIGNAL</span></span><span class="p"><span class="hl">(</span></span><span class="n">sessionDeleted</span><span class="p"><span class="hl">(</span></span><span class="n"><span class="hl">QString</span></span><span class="p"><span class="hl">)),</span></span><span class="hl"> </span><span class="n"><span class="hl">SLOT</span></span><span class="p"><span class="hl">(</span></span><span class="n">sessionDeleted</span><span class="p"><span class="hl">(</span></span><span class="n"><span class="hl">QString</span></span><span class="p"><span class="hl">))</span>);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">27</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">connect</span><span class="p">(</span><span class="n">KDevelop</span><span class="o">::</span><span class="n">Core</span><span class="o">::</span><span class="n">self</span><span class="p">()</span><span class="o">-></span><span class="n">sessionController</span><span class="p">(),</span> <span class="o"><span class="hl">&</span></span><span class="n"><span class="hl">KDevelop</span></span><span class="o"><span class="hl">::</span></span><span class="n"><span class="hl">SessionController</span></span><span class="o"><span class="hl">::</span></span><span class="n">sessionDeleted</span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="k"><span class="hl">this</span></span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="o"><span class="hl">&</span></span><span class="n"><span class="hl">SessionsModel</span></span><span class="o"><span class="hl">::</span></span><span class="n">sessionDeleted</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">s/KDevelop:://</p></pre>
</div>
</div>
<br />
<p>- Kevin Funk</p>
<br />
<p>On November 7th, 2014, 5:36 p.m. UTC, Alexander Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Alexander Richardson.</div>
<p style="color: grey;"><i>Updated Nov. 7, 2014, 5:36 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Convert projectmanagerview plugin to new signal/slot syntax</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Convert patchreview plugin to new signal/slot syntax</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Convert vcschangesview plugin to new signal/slot syntax</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Convert reviewboard plugin to new signal/slot syntax</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Convert problemreporter plugin to new signal/slot syntax</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Convert quickopen plugin to new signal/slot syntax</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Convert standardoutputview plugin to new signal/slot syntax</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Convert testview plugin to new signal/slot syntax</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Convert templatemanager plugin to new signal/slot syntax</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Convert projectfilter plugin to new signal/slot syntax</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Convert all the remaining plugins to new signal/slot syntax</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/quickopen/projectfilequickopen.cpp <span style="color: grey">(5d49e278a2ee77c5ca81e18c11aa2cb19aed3f84)</span></li>
<li>plugins/quickopen/quickopenmodel.cpp <span style="color: grey">(b8c596e254b22c4da55993d2b62dc508b8fcfd89)</span></li>
<li>plugins/quickopen/quickopenplugin.cpp <span style="color: grey">(a8e619b8ce5ab78354148ca19c142eea6cff046e)</span></li>
<li>plugins/reviewboard/reviewboardjobs.h <span style="color: grey">(f971961402813cb727c8633452110e94b2c2c6bd)</span></li>
<li>plugins/reviewboard/reviewboardjobs.cpp <span style="color: grey">(31721332975227265cf209034d0692af9a271414)</span></li>
<li>plugins/reviewboard/reviewboardplugin.cpp <span style="color: grey">(b77089e320cb60059cd7a1dfda8bd8cdb8e01a8e)</span></li>
<li>plugins/reviewboard/reviewpatchdialog.cpp <span style="color: grey">(3ada692a8dec7a54adec5af0968d58795d0b901b)</span></li>
<li>plugins/standardoutputview/outputwidget.cpp <span style="color: grey">(60729adb024a19cc7c4493998e9e6e52d8d8c5bd)</span></li>
<li>plugins/standardoutputview/standardoutputview.cpp <span style="color: grey">(5a7d28ecfa8a9db9f62a3edae9929a20e00e158a)</span></li>
<li>plugins/standardoutputview/tests/CMakeLists.txt <span style="color: grey">(88f2dde443578281fd1d5801f87e15f050e63b58)</span></li>
<li>plugins/switchtobuddy/switchtobuddyplugin.cpp <span style="color: grey">(fdb3b967520a7a3e21e6e566f029f5b6117f8e00)</span></li>
<li>plugins/templatemanager/templatepage.cpp <span style="color: grey">(93cff9a030f8bea233008c36710cd312db02b905)</span></li>
<li>plugins/testview/testview.cpp <span style="color: grey">(e15181674b7d6823da098912b2a4ebcea9cb37de)</span></li>
<li>plugins/testview/testviewplugin.cpp <span style="color: grey">(3768726049f5ee057e000a56ae17e10a4b758bf4)</span></li>
<li>plugins/vcschangesview/vcschangesview.cpp <span style="color: grey">(b403f47b9bdbfc65df4e4c9d83448942bf52766b)</span></li>
<li>plugins/vcschangesview/vcschangesviewplugin.h <span style="color: grey">(bd826429bd850eb7c48d64e8325aeda909531cd8)</span></li>
<li>plugins/vcschangesview/vcschangesviewplugin.cpp <span style="color: grey">(705e79c41e6fc4fc9c30892f8ec940d012670615)</span></li>
<li>plugins/welcomepage/sessionsmodel.cpp <span style="color: grey">(4a28dc2695bd86e2fc1565eeb5f7b12b9e5c2139)</span></li>
<li>plugins/welcomepage/welcomepageview.cpp <span style="color: grey">(3187ac12566a38eaecb32bc3799f3eeb5b1b78b9)</span></li>
<li>plugins/problemreporter/problemtreeview.cpp <span style="color: grey">(47c2295d2db7a794295264a8e914f0099a569e8e)</span></li>
<li>plugins/problemreporter/watcheddocumentset.cpp <span style="color: grey">(62e83281885e952db5c015d44aee4fb29d28078d)</span></li>
<li>plugins/projectfilter/projectfilterkcm.cpp <span style="color: grey">(7eaba23ca09bfedb76fde50a4ff02b28b009c31a)</span></li>
<li>plugins/projectfilter/projectfilterprovider.cpp <span style="color: grey">(e22198349f02675572b1396e7a02bac1b43d2eb8)</span></li>
<li>plugins/projectmanagerview/projectbuildsetwidget.cpp <span style="color: grey">(e558ec1e11046fca2c96f6f01633ef6e3bee7e2e)</span></li>
<li>plugins/projectmanagerview/projectmanagerview.cpp <span style="color: grey">(158ee70bdd3111e43ef7ad996ef95ceb43457940)</span></li>
<li>plugins/projectmanagerview/projectmanagerviewplugin.cpp <span style="color: grey">(78d85f8e0ee56c7f224256e9220c5dfa74cd2b30)</span></li>
<li>plugins/projectmanagerview/projecttreeview.cpp <span style="color: grey">(6a83882a7e849968c65745459e88046690001257)</span></li>
<li>plugins/projectmanagerview/vcsoverlayproxymodel.cpp <span style="color: grey">(3f4f3ab1351097b071e951e1a58733b1289d06f6)</span></li>
<li>plugins/patchreview/patchreview.h <span style="color: grey">(a54695b5128c4cd9918e866c4432d7b4cb5c230a)</span></li>
<li>plugins/patchreview/patchreview.cpp <span style="color: grey">(ae7ed5159c329e7dd3836f3f3ee96ecd70e3d735)</span></li>
<li>plugins/patchreview/patchreviewtoolview.cpp <span style="color: grey">(5bb33d80ad86a7bdd1a9ef63ae890293f00d1d96)</span></li>
<li>plugins/problemreporter/problemhighlighter.cpp <span style="color: grey">(e79ae592b2661e433209d6d09315d49ce34bde33)</span></li>
<li>plugins/problemreporter/problemmodel.cpp <span style="color: grey">(41384a158b644749193677992586de68939bd74e)</span></li>
<li>plugins/problemreporter/problemreporterplugin.cpp <span style="color: grey">(23d02aa511f3b6ee627ba3cf8227b667502ff4b6)</span></li>
<li>plugins/konsole/kdevkonsoleview.cpp <span style="color: grey">(0aecaf210e37e43582a0e37336f14f197f41d1d0)</span></li>
<li>plugins/openwith/openwithplugin.cpp <span style="color: grey">(a04cd9c9a0506d1ed0c3c91b0fa6d8f26035894a)</span></li>
<li>plugins/pastebin/pastebinplugin.cpp <span style="color: grey">(65331b42d508bc233b3b0c852eba5e066fa931a4)</span></li>
<li>plugins/patchreview/localpatchsource.cpp <span style="color: grey">(1a178690e1bd44ca336c094a6f2d1492bbae568e)</span></li>
<li>plugins/patchreview/patchhighlighter.h <span style="color: grey">(c8ee098a2cc471974cbea5e8fc6d92936ae9495a)</span></li>
<li>plugins/patchreview/patchhighlighter.cpp <span style="color: grey">(ed2ba897a53162080726b62ca39de36648c6c3d0)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121046/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>