<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120633/">https://git.reviewboard.kde.org/r/120633/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 17th, 2014, 9:57 p.m. CEST, <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I fixed this already, and will discard this review request.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Sadly your fix doesn't work on my end, what could I have missed?</p></pre>
<br />
<p>- René J.V.</p>
<br />
<p>On October 17th, 2014, 9:57 p.m. CEST, René J.V. Bertin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By René J.V. Bertin.</div>
<p style="color: grey;"><i>Updated Oct. 17, 2014, 9:57 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevelop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The "configure environment" combobox in "Open Configuration.../CMake/Advanced" recently stopped working for me, printing warnings on the terminal:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">Object<span style="color: #666666">::</span>connect<span style="color: #666666">:</span> No such signal KDevelop<span style="color: #666666">::</span>EnvironmentSelectionWidget<span style="color: #666666">::</span>currentIndexChanged(<span style="color: #B00040">int</span>)
Object<span style="color: #666666">::</span>connect<span style="color: #666666">:</span> (sender name<span style="color: #666666">:</span> <span style="border: 1px solid #FF0000">'</span>environment<span style="border: 1px solid #FF0000">'</span>)
kdevelop(<span style="color: #666666">27645</span>)<span style="color: #666666">/</span>kdeui (KConfigDialogManager) KConfigDialogManager<span style="color: #666666">::</span>parseChildren<span style="color: #666666">:</span> Don<span style="border: 1px solid #FF0000">'</span>t know how to monitor widget <span style="border: 1px solid #FF0000">'</span> KDevelop<span style="color: #666666">::</span>EnvironmentSelectionWidget <span style="border: 1px solid #FF0000">'</span> <span style="color: #008000; font-weight: bold">for</span> changes<span style="color: #666666">!</span>
QCoreApplication<span style="color: #666666">::</span>postEvent<span style="color: #666666">:</span> Unexpected null receiver
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">In short: the <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">EnvironmentSelectionWidget</code> is not recognised (cannot be used) as a KComboBox when compiling <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">cmakepreferences.cpp</code>.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I noticed this after "downgrading" from the kde4-legacy branch and reinstalling the 4.7/1.7 code pulled from git. Reverting back to the last kde4-legacy build I had installed did not revert functionality however, and indeed I think that it's been a while that validating a change in the cmake environment profile triggered an invocation of the cmake command.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Curiously the same <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">EnvironmentSelectionWidget</code> works fine in the Make section of the same configuration dialog.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I tested a workaround in which I added a function to retrieve the private <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">KComboBox</code> pointer from a <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">EnvironmentSelectionWidget</code> and use that pointer as the source in the failing connect() call in CMakePreferences::CMakePreferences. </p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Under OS X 10.6.8 with kdelibs 4.14.2 and kdevplatform 1.7/git, both built with gcc 4.8.3 from MacPorts.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">With the workaround I still get</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">kdevelop(<span style="color: #666666">64480</span>)<span style="color: #666666">/</span>kdeui (KConfigDialogManager) KConfigDialogManager<span style="color: #666666">::</span>parseChildren<span style="color: #666666">:</span> Don<span style="border: 1px solid #FF0000">'</span>t know how to monitor widget <span style="border: 1px solid #FF0000">'</span> KDevelop<span style="color: #666666">::</span>EnvironmentSelectionWidget <span style="border: 1px solid #FF0000">'</span> <span style="color: #008000; font-weight: bold">for</span> changes<span style="color: #666666">!</span>
QCoreApplication<span style="color: #666666">::</span>postEvent<span style="color: #666666">:</span> Unexpected null receiver
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">on the calling terminal, but changing the environment profile now "sticks" and launches cmake.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>projectmanagers/cmake/settings/cmakepreferences.cpp <span style="color: grey">(6db6974)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120633/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/10/17/7edf2d31-45d7-45fd-8432-465d28d3834e__patch-envselwidget.diff">accompanying patchfile for kdevplatform/util</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>