<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119830/">https://git.reviewboard.kde.org/r/119830/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Dāvis Mosāns.</div>
<p style="color: grey;"><i>Updated Oct. 15, 2014, 4:44 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">rebased and fixed conflicts</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Remove deprecated IProject methods. No need to keep them, when KUrl will be changed to QUrl signatures would be different anyway, so just remove now.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tests does pass :)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">but note that KDevelop must also be updated and currently it won't compile against this because it still uses these deprecated methods.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/executescript/scriptappconfig.cpp <span style="color: grey">(19b22e7361dd968477b32d2247deb30ce53cfdd4)</span></li>
<li>plugins/dashboard/kdevprojectdashboard.cpp <span style="color: grey">(e16a5a8fddb2cb6536ab19cb3b47197f9ba50fa4)</span></li>
<li>plugins/execute/nativeappconfig.cpp <span style="color: grey">(b0eca9c9712b6a4ff2759180c54a35cc0168fe0f)</span></li>
<li>interfaces/iproject.h <span style="color: grey">(6936821eb4cfab294f605b54b044ad90b73bd66a)</span></li>
<li>plugins/dashboard/dashboarddataengine.cpp <span style="color: grey">(332f1d27218f52d5fff5866d6d6345a4ee16b5f2)</span></li>
<li>plugins/dashboard/dashboarddocument.cpp <span style="color: grey">(26293a66f967391747484bcdb81ac6ca929bd4f4)</span></li>
<li>plugins/externalscript/externalscriptjob.cpp <span style="color: grey">(44753ef735940b4d6017778835d8955d2cb945d3)</span></li>
<li>plugins/filetemplates/templateclassassistant.cpp <span style="color: grey">(f9e27e4387abb0bf2f9a2f54ff2ec0b9fdc3ebc8)</span></li>
<li>plugins/grepview/grepdialog.cpp <span style="color: grey">(69ed226feafeee7b22516d39efb372826c4f6790)</span></li>
<li>plugins/projectmanagerview/projectmanagerview.cpp <span style="color: grey">(7a6379af765958b4c81d2fc94cf3789492ae9e47)</span></li>
<li>plugins/projectmanagerview/vcsoverlayproxymodel.cpp <span style="color: grey">(3f4f3ab1351097b071e951e1a58733b1289d06f6)</span></li>
<li>project/projectmodel.h <span style="color: grey">(b8310c7d9b8dc14f490fb2c1a1861d51071b77c2)</span></li>
<li>project/projectmodel.cpp <span style="color: grey">(91aaac32ad33a510bc02edb41811b0fc5cd4ea79)</span></li>
<li>shell/project.h <span style="color: grey">(4f893c595d75e249d2b2d7cdcacc0c322cecedf3)</span></li>
<li>shell/project.cpp <span style="color: grey">(9369b8e20586f1db1d62a24b4b1af0e9d15f1a18)</span></li>
<li>shell/projectcontroller.cpp <span style="color: grey">(e549155a3b7fc3ac3e6c642c2c9e2c123af11b7c)</span></li>
<li>tests/testproject.h <span style="color: grey">(3aa8e0ecb8fa527c425cb36af40bbdfd0ceb2fad)</span></li>
<li>tests/testproject.cpp <span style="color: grey">(39a6d0be6505fcb7f5e130f27481fe02b89a7446)</span></li>
<li>vcs/models/brancheslistmodel.cpp <span style="color: grey">(5f16c9deafd21aae41b110a0398282e67cd0de43)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119830/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>