<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120273/">https://git.reviewboard.kde.org/r/120273/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">You don't have commit access, do you?</p></pre>
<br />
<p>- Sven Brauch</p>
<br />
<p>On September 21st, 2014, 4:05 p.m. UTC, Jakub Caban wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop and Alexander Richardson.</div>
<div>By Jakub Caban.</div>
<p style="color: grey;"><i>Updated Sept. 21, 2014, 4:05 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdev-upload
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I have ported CMakeList to ECM and Framework based and ported as much source code as I could to compile agains KDevelop and KDevplatform master.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It compiles and works as intended.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Missing bits:<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
- reading/saving uploaded file times<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
- shortcuts to upload actions are not saved</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Those are KDevelop problems maybe?</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>uploadprofiledlg.cpp <span style="color: grey">(930f1c1)</span></li>
<li>uploadprofilemodel.cpp <span style="color: grey">(84e8a79)</span></li>
<li>uploadpreferences.cpp <span style="color: grey">(4b4380e)</span></li>
<li>uploadjob.h <span style="color: grey">(025bb7b)</span></li>
<li>uploadjob.cpp <span style="color: grey">(b48e58c)</span></li>
<li>uploaddialog.cpp <span style="color: grey">(0600a7d)</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(bb4f2f6)</span></li>
<li>profilesfiletree.cpp <span style="color: grey">(fffe74e)</span></li>
<li>kdevuploadplugin.cpp <span style="color: grey">(c805255)</span></li>
<li>profilesfiletree.h <span style="color: grey">(4718b1e)</span></li>
<li>kdevuploadplugin.h <span style="color: grey">(335b2b3)</span></li>
<li>CMakeLists.txt <span style="color: grey">(8e6baa4)</span></li>
<li>kdevupload.desktop.cmake <span style="color: grey">(d3277a0)</span></li>
<li>uploadprojectmodel.cpp <span style="color: grey">(900b8d0)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120273/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>