<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120273/">https://git.reviewboard.kde.org/r/120273/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/120273/diff/3/?file=313523#file313523line25" style="color: black; font-weight: bold; text-decoration: underline;">uploadprofilemodel.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">24</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KSettings</span><span class="o">::</span><span class="n">Dispatcher</span><span class="o">::</span><span class="n">registerComponent</span><span class="p">(</span><span class="n">KComponentData</span><span class="p">(</span><span class="s">"kdevupload"</span><span class="p">),</span> <span class="k">this</span><span class="p">,</span> <span class="s">"revert"</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">25</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KSettings</span><span class="o">::</span><span class="n">Dispatcher</span><span class="o">::</span><span class="n">registerComponent</span><span class="p">(</span><span class="n">KComponentData</span><span class="p">(</span><span class="s">"kdevupload"</span><span class="p">)<span class="hl">.</span></span><span class="n"><span class="hl">componentName</span></span><span class="p"><span class="hl">()</span>,</span> <span class="k">this</span><span class="p">,</span> <span class="s">"revert"</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">isn't the component name "kdevupload", i.e. couldn't you directly write</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">...<span style="color: #666666">::</span>registerComponent(QStringLiteral(<span style="color: #BA2121">"kdevupload"</span>), ...);
</pre></div>
</p></pre>
</div>
</div>
<br />
<p>- Milian Wolff</p>
<br />
<p>On September 19th, 2014, 7:35 p.m. UTC, Jakub Caban wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Jakub Caban.</div>
<p style="color: grey;"><i>Updated Sept. 19, 2014, 7:35 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdev-upload
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I have ported CMakeList to ECM and Framework based and ported as much source code as I could to compile agains KDevelop and KDevplatform master.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It compiles, but currently crashes KDevelop whenever project settings are to be opened.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>uploadprofilemodel.cpp <span style="color: grey">(84e8a79)</span></li>
<li>uploadprojectmodel.cpp <span style="color: grey">(900b8d0)</span></li>
<li>CMakeLists.txt <span style="color: grey">(8e6baa4)</span></li>
<li>kdevuploadplugin.h <span style="color: grey">(335b2b3)</span></li>
<li>kdevuploadplugin.cpp <span style="color: grey">(c805255)</span></li>
<li>profilesfiletree.h <span style="color: grey">(4718b1e)</span></li>
<li>profilesfiletree.cpp <span style="color: grey">(fffe74e)</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(bb4f2f6)</span></li>
<li>uploaddialog.cpp <span style="color: grey">(0600a7d)</span></li>
<li>uploadjob.cpp <span style="color: grey">(b48e58c)</span></li>
<li>uploadpreferences.cpp <span style="color: grey">(4b4380e)</span></li>
<li>uploadprofiledlg.cpp <span style="color: grey">(930f1c1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120273/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>