<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120273/">https://git.reviewboard.kde.org/r/120273/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 18th, 2014, 10:26 p.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/120273/diff/1/?file=313291#file313291line25" style="color: black; font-weight: bold; text-decoration: underline;">uploadprofilemodel.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">24</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KSettings</span><span class="o">::</span><span class="n">Dispatcher</span><span class="o">::</span><span class="n">registerComponent</span><span class="p">(</span><span class="n">KComponentData</span><span class="p">(</span><span class="s">"kdevupload"</span><span class="p">),</span> <span class="k">this</span><span class="p">,</span> <span class="s">"revert"</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">25</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="c1"><span class="hl">// </span> KSettings::Dispatcher::registerComponent(KComponentData("kdevupload")<span class="hl">.componentName()</span>, this, "revert");</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Why is this commented out?<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
You can find it in the KCMUtils framework.</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I couldn't overcome it by myself. I know it should be in KCMUtils and it is even found, but I got compile errors:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">/home/lustmored/projects/kdev-upload/uploadprofilemodel.cpp: In constructor ‘UploadProfileModel::UploadProfileModel(QObject<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">)’:<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
/home/lustmored/projects/kdev-upload/uploadprofilemodel.cpp:25:90: error: invalid initialization of reference of type ‘const QString&’ from expression of type ‘KComponentData’<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
KSettings::Dispatcher::registerComponent(KComponentData("kdevupload"), this, "revert");<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
^<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
In file included from /home/lustmored/projects/kdev-upload/uploadprofilemodel.cpp:14:0:<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
/usr/include/KF5/KCMUtils/ksettings/dispatcher.h:55:22: error: in passing argument 1 of ‘void KSettings::Dispatcher::registerComponent(const QString&, QObject</em>, const char<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">)’<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
KCMUTILS_EXPORT void registerComponent(const QString &componentName, QObject </em>recv, const char *slot);</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'd appreciate some hint as googling failed for me :(</p></pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 18th, 2014, 10:26 p.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/120273/diff/1/?file=313291#file313291line70" style="color: black; font-weight: bold; text-decoration: underline;">uploadprofilemodel.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void UploadProfileModel::revert()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">69</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KUrl</span> <span class="n">url</span> <span class="o">=</span> <span class="n">group</span><span class="p">.</span><span class="n">group</span><span class="p">(</span><span class="n">g</span><span class="p">).</span><span class="n">readEntry</span><span class="p">(</span><span class="s">"url"</span><span class="p">,</span> <span class="n"><span class="hl">KUrl</span></span><span class="p">());</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">70</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KUrl</span> <span class="n">url</span> <span class="o">=</span> <span class="n"><span class="hl">KUrl</span></span><span class="p"><span class="hl">(</span></span><span class="n">group</span><span class="p">.</span><span class="n">group</span><span class="p">(</span><span class="n">g</span><span class="p">).</span><span class="n">readEntry</span><span class="p">(</span><span class="s">"url"</span><span class="p">,</span> <span class="n"><span class="hl">QString</span></span><span class="p">())<span class="hl">)</span>;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I wouldn't read it as a QString, use QUrl?</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I have tried a few ways that seemed reasonable to me, but when left untouched it gives:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">In file included from /usr/include/KF5/KConfigCore/kconfiggroup.h:717:0,<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
from /usr/include/KF5/KConfigCore/KConfigGroup:1,<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
from /home/lustmored/projects/kdev-upload/uploadprofilemodel.cpp:13:<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
/usr/include/KF5/KConfigCore/conversioncheck.h: In instantiation of ‘void ConversionCheck::type_toQVariant<T>::constraint() [with T = KUrl]’:<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
/usr/include/KF5/KConfigCore/conversioncheck.h:82:39: required from ‘void ConversionCheck::to_QVariant() [with T = KUrl]’<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
/usr/include/KF5/KConfigCore/kconfiggroup.h:722:37: required from ‘T KConfigGroup::readEntry(const char*, const T&) const [with T = KUrl]’<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
/home/lustmored/projects/kdev-upload/uploadprofilemodel.cpp:70:62: required from here<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
/usr/include/KF5/KConfigCore/conversioncheck.h:63:23: error: conversion from ‘ConversionCheck::QVconvertible<KUrl>::toQVariant {aka ConversionCheck::unsupported}’ to non-scalar type ‘ConversionCheck::supported’ requested<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
supported x = y;</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">and my only idea was to read as QString and create KUrl object for that. How can I do it better way?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also I'd love to get it going with KUrl before porting to QUrl as it will be probably loads of work (most of the plugin just manipulates KUrls). It should be easier done when I have first some kind of working KUrl based version</p></pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 18th, 2014, 10:26 p.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/120273/diff/1/?file=313292#file313292line230" style="color: black; font-weight: bold; text-decoration: underline;">uploadprojectmodel.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QString UploadProjectModel::currentProfileName()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">229</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="n">m_profileConfigGroup</span><span class="p">.</span><span class="n">readEntry</span><span class="p">(</span><span class="s">"url"</span><span class="p">,</span> <span class="n"><span class="hl">KUrl</span></span><span class="p">());</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">230</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="n"><span class="hl">KUrl</span></span><span class="p"><span class="hl">(</span></span><span class="n">m_profileConfigGroup</span><span class="p">.</span><span class="n">readEntry</span><span class="p">(</span><span class="s">"url"</span><span class="p">,</span> <span class="n"><span class="hl">QString</span></span><span class="p">())<span class="hl">)</span>;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Read as QUrl</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">same as first issue about KUrl</p></pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 18th, 2014, 10:26 p.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I pointed out some issues, but good work otherwise!! :D</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thanks a lot for that! Those simple guidances are really extremely helpful to me!</p></pre>
<br />
<p>- Jakub</p>
<br />
<p>On September 18th, 2014, 8:08 p.m. UTC, Jakub Caban wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Jakub Caban.</div>
<p style="color: grey;"><i>Updated Sept. 18, 2014, 8:08 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdev-upload
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I have ported CMakeList to ECM and Framework based and ported as much source code as I could to compile agains KDevelop and KDevplatform master.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It compiles, but currently crashes KDevelop whenever project settings are to be opened.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>profilesfiletree.cpp <span style="color: grey">(fffe74e)</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(bb4f2f6)</span></li>
<li>uploaddialog.cpp <span style="color: grey">(0600a7d)</span></li>
<li>uploadjob.cpp <span style="color: grey">(b48e58c)</span></li>
<li>uploadpreferences.cpp <span style="color: grey">(4b4380e)</span></li>
<li>uploadprofiledlg.cpp <span style="color: grey">(930f1c1)</span></li>
<li>uploadprofilemodel.cpp <span style="color: grey">(84e8a79)</span></li>
<li>uploadprojectmodel.cpp <span style="color: grey">(900b8d0)</span></li>
<li>CMakeLists.txt <span style="color: grey">(8e6baa4)</span></li>
<li>kdevuploadplugin.h <span style="color: grey">(335b2b3)</span></li>
<li>kdevuploadplugin.cpp <span style="color: grey">(c805255)</span></li>
<li>profilesfiletree.h <span style="color: grey">(4718b1e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120273/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>