<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119972/">https://git.reviewboard.kde.org/r/119972/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Alexander Richardson.</div>
<p style="color: grey;"><i>Updated Sept. 14, 2014, 4:24 nachm.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">removed K_EXPORT_PLUGIN</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This iterates over all plugins in the kdevplatform/$KDEVPLATFORM_VERSION<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
subdirectories of QCoreApplication::libraryPaths and will then include<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
all plugins that contain "KDevelop/Plugin" in their service types.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This meta data is now embedded directly in the shared libraries, there<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
is no more need for kbuildsycoca and .desktop files.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This means we now require KCoreAddons 5.2 and KService 5.3</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">For testing I converted KDevWelcomepage to the new JSON metadata and it<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
loads fine. If this approach is deemed correct I will convert the other plugins.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It requires https://git.reviewboard.kde.org/r/119970/ to get committed first (committed now).</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Welcomepage loads fine when opening kdevelop, other plugins are still loaded. It new finds 26 new style plugin and 17 old style ones (from kdevelop since that is not ported yet)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(428bcebcea3944e7374e3ed95b24ad57f18d8cb9)</span></li>
<li>plugins/welcomepage/kdevwelcomepageplugin.desktop.cmake <span style="color: grey">()</span></li>
<li>plugins/welcomepage/welcomepageplugin.cpp <span style="color: grey">(4ced24720b8c27e892878527a73282c24a77f9b6)</span></li>
<li>shell/plugincontroller.cpp <span style="color: grey">(c610b56722394baad43542c09cbce1a0d3ca16c5)</span></li>
<li>shell/settings/CMakeLists.txt <span style="color: grey">(68d346165182db31f293577c1e9ae3869f1e7001)</span></li>
<li>shell/settings/bgpreferences.cpp <span style="color: grey">(c3a8edac80141576707e7af1484262fed6796d10)</span></li>
<li>shell/settings/ccpreferences.cpp <span style="color: grey">(289390e2be6382eaf0950dc4bda85adc99ea540c)</span></li>
<li>shell/settings/environmentpreferences.cpp <span style="color: grey">(95e41d853da3090f69cc0abdd3df8a3de602984c)</span></li>
<li>shell/settings/pluginpreferences.cpp <span style="color: grey">(8d168c8d76a521c28be8cd452be66542875bf5c7)</span></li>
<li>shell/settings/projectpreferences.cpp <span style="color: grey">(9c605a19f459bd7daaa21f6f3184aa57afe60177)</span></li>
<li>shell/settings/sourceformattersettings.cpp <span style="color: grey">(c82981db9b4879d669c15f7597c61bcf2c81c197)</span></li>
<li>shell/settings/uipreferences.cpp <span style="color: grey">(3bf2e82e5a6202ccba3de862ee6f89c7dacd563a)</span></li>
<li>shell/tests/nonguiinterfaceplugin.cpp <span style="color: grey">(9eabf9a31e40734b7164e79fcda42f44f66438ef)</span></li>
<li>plugins/vcschangesview/CMakeLists.txt <span style="color: grey">(c0142e8d73ea3175e0fa47823e93ae6a646a319b)</span></li>
<li>plugins/vcschangesview/vcschangesviewplugin.cpp <span style="color: grey">(27460040477ade36b516b9c06998a5fd70525eac)</span></li>
<li>plugins/welcomepage/CMakeLists.txt <span style="color: grey">(34ee3302fadd8a85a66dd2f5b776f0aa09468afb)</span></li>
<li>plugins/quickopen/CMakeLists.txt <span style="color: grey">(624513e1cfaa13cd2399f90a5ce76295644fba27)</span></li>
<li>plugins/quickopen/quickopenplugin.cpp <span style="color: grey">(514dc11b35e5bd6cfd3737d1deb3c1653d76acc5)</span></li>
<li>plugins/reviewboard/CMakeLists.txt <span style="color: grey">(9cda85342f725f7968380648a381242313c1930f)</span></li>
<li>plugins/reviewboard/reviewboardplugin.cpp <span style="color: grey">(ff7717cbb823bd97338c70251c578010d09b624c)</span></li>
<li>plugins/snippet/CMakeLists.txt <span style="color: grey">(2305b7863be1ba0796b91732dda79e74e777cd96)</span></li>
<li>plugins/snippet/snippetplugin.cpp <span style="color: grey">(73d2afdeb6d6100641199b7817265e80184934bf)</span></li>
<li>plugins/standardoutputview/CMakeLists.txt <span style="color: grey">(38d8cb82a98b9ac19086a17f392f61b2e189635f)</span></li>
<li>plugins/standardoutputview/standardoutputview.cpp <span style="color: grey">(0b17af80f4ef5800244d375ce2e991f8be70b263)</span></li>
<li>plugins/subversion/CMakeLists.txt <span style="color: grey">(2a31e21165cd05f2537ad9485dcc3fe86f1efd6b)</span></li>
<li>plugins/subversion/kdevsvnplugin.cpp <span style="color: grey">(e5f5a89a1335dd6cb41d37d0a8f77b5e7cd6a0db)</span></li>
<li>plugins/switchtobuddy/CMakeLists.txt <span style="color: grey">(382cc20ba503ac5e687c9bc5c920309cc6236aeb)</span></li>
<li>plugins/switchtobuddy/switchtobuddyplugin.cpp <span style="color: grey">(ad3be718bc12bee24e686d2d1a36aca75ccad7bf)</span></li>
<li>plugins/templatemanager/CMakeLists.txt <span style="color: grey">(4946c7924d5b24731f25a62bf27294b14fb4b412)</span></li>
<li>plugins/templatemanager/templateconfig.cpp <span style="color: grey">(d7c0371bc44ff81f17e6faf6c0c6408e837d45a5)</span></li>
<li>plugins/testview/CMakeLists.txt <span style="color: grey">(10eec21d9725ed5647fc4dff9d065c592e66e6c9)</span></li>
<li>plugins/testview/testviewplugin.cpp <span style="color: grey">(52b16e4ff4d309f5a9715e44f2b74d5bf27589a1)</span></li>
<li>plugins/projectfilter/CMakeLists.txt <span style="color: grey">(e922f5c937f17181ad4eb3ca054440df017c85a5)</span></li>
<li>plugins/projectfilter/projectfilterkcm.cpp <span style="color: grey">(5a59115151702573b95000f4b66b351bcca02710)</span></li>
<li>plugins/projectfilter/projectfilterprovider.cpp <span style="color: grey">(1ff1ec8a03c817f18e0462fbbf2c6b4fe79977a9)</span></li>
<li>plugins/projectmanagerview/CMakeLists.txt <span style="color: grey">(7720a60477f0074ebeb34976459a8a6db38b941e)</span></li>
<li>plugins/projectmanagerview/projectmanagerviewplugin.cpp <span style="color: grey">(0fe57fa27eb37ec6371f2923dea30c00ff4e8ee4)</span></li>
<li>plugins/contextbrowser/contextbrowser.cpp <span style="color: grey">(ea73f8aa1af6644e94256f39c90ec762d08aa0e1)</span></li>
<li>plugins/cvs/CMakeLists.txt <span style="color: grey">(93d6cecd8f52c0b2f4b49de76a5b1661e0432ace)</span></li>
<li>plugins/dashboard/kdevprojectdashboard.cpp <span style="color: grey">(8c2eaf5f0a0f8b63aa1b05ec1a9a2a8e0434f68f)</span></li>
<li>plugins/documentswitcher/CMakeLists.txt <span style="color: grey">(46a779c4cf56f1a4387915dd3d3f030d33b0e284)</span></li>
<li>plugins/documentswitcher/documentswitcherplugin.cpp <span style="color: grey">(b5f448005994495a55037a35c6d76fb7236ca97f)</span></li>
<li>plugins/documentview/CMakeLists.txt <span style="color: grey">(9f1483e0b8d5c74c3de13fa989e2e7b995906c5e)</span></li>
<li>plugins/documentview/kdevdocumentviewplugin.cpp <span style="color: grey">(fa8c3f18b658609f6cdf704529e03c118c463367)</span></li>
<li>plugins/execute/CMakeLists.txt <span style="color: grey">(8f2e01b86f1e382e45ea5ff6bbce205710a52609)</span></li>
<li>plugins/execute/executeplugin.cpp <span style="color: grey">(ca905a501457d81dec49c6cc1e1d7d6986a6eb74)</span></li>
<li>plugins/executescript/CMakeLists.txt <span style="color: grey">(67381f93d4e84aa2b0338c8195d43e14fd92b9e1)</span></li>
<li>plugins/executescript/executescriptplugin.cpp <span style="color: grey">(aa672c9b91b371551f8588e6bd01a7d64674c3de)</span></li>
<li>plugins/externalscript/CMakeLists.txt <span style="color: grey">(93d459bb0780efe7534d7dfc3e19fe7349192fde)</span></li>
<li>plugins/externalscript/externalscriptplugin.cpp <span style="color: grey">(3b125c4162f7b497f820e06590ffbda6d2aab746)</span></li>
<li>plugins/filemanager/CMakeLists.txt <span style="color: grey">(2ea0539e588bf58482a219c3000d2e5e4379047f)</span></li>
<li>plugins/filemanager/kdevfilemanagerplugin.cpp <span style="color: grey">(b84271c6c6c03d569d2031e53813e51e95fce790)</span></li>
<li>plugins/filetemplates/CMakeLists.txt <span style="color: grey">(f9ba4d437000e08a448c3865f24398d3eb54f164)</span></li>
<li>plugins/filetemplates/filetemplatesplugin.cpp <span style="color: grey">(31c7027353945665bb67f467fa1712a97251d769)</span></li>
<li>plugins/genericprojectmanager/CMakeLists.txt <span style="color: grey">(427323c4ebec756801c6a62fa3e284862f00cde8)</span></li>
<li>plugins/genericprojectmanager/genericmanager.cpp <span style="color: grey">(4b563605be98e2a92c6d0d693f218b3ebf110c6a)</span></li>
<li>plugins/git/CMakeLists.txt <span style="color: grey">(35acdea2790646aa1aa2b183043c34b2e10d2244)</span></li>
<li>plugins/git/gitplugin.cpp <span style="color: grey">(8597cf2819a397a71f696c3bbf8397b3b0d21ebd)</span></li>
<li>plugins/git/gitpluginmetadata.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/grepview/CMakeLists.txt <span style="color: grey">(84d66cf9634a359b64ec082689258eba286882e8)</span></li>
<li>plugins/grepview/grepviewplugin.cpp <span style="color: grey">(fc5a1786c8e4039b1705289b2c4cf70f86103b7e)</span></li>
<li>plugins/grepview/grepviewpluginmetadata.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/konsole/CMakeLists.txt <span style="color: grey">(2f536b36b062f1caed254c6ef3a9843cbf3453bf)</span></li>
<li>plugins/konsole/kdevkonsoleviewplugin.cpp <span style="color: grey">(ac8a4816a43f73b0feeae5f9a3db19a501748394)</span></li>
<li>plugins/openwith/CMakeLists.txt <span style="color: grey">(407777482ef2c88461716c7290a7310125abcbbf)</span></li>
<li>plugins/openwith/openwithplugin.cpp <span style="color: grey">(37bb97b3d0f62cb398c221aea223c8872314f683)</span></li>
<li>plugins/pastebin/CMakeLists.txt <span style="color: grey">(9d2d4cba0120601fc5b314b056ebd033e6ab69b3)</span></li>
<li>plugins/pastebin/pastebinplugin.cpp <span style="color: grey">(3960ef4d5fbda1aa4eaba8ace7d112b7251a81bd)</span></li>
<li>plugins/patchreview/CMakeLists.txt <span style="color: grey">(02720119fc44770c6ee7a14d1d03184b284db791)</span></li>
<li>plugins/patchreview/patchreview.cpp <span style="color: grey">(dbf6a34d3859493b780879270e8c11d68988bb0b)</span></li>
<li>plugins/problemreporter/CMakeLists.txt <span style="color: grey">(25fbdcec795f1cb0c0fe1a3a14fc841a303af766)</span></li>
<li>plugins/problemreporter/problemreporterplugin.cpp <span style="color: grey">(2d9971d198ac8b5e9ee05682e281fb18d2ad585e)</span></li>
<li>plugins/appwizard/appwizardplugin.cpp <span style="color: grey">(9bc69f83fb813bfacae5d9f01b7b450eb03d6368)</span></li>
<li>plugins/bazaar/CMakeLists.txt <span style="color: grey">(17820ea528abfe0b8b9cb610edddbe00bc5b02f2)</span></li>
<li>plugins/bazaar/bazaarplugin.cpp <span style="color: grey">(dc1ac6e102b2f593c096164aa46d9ef7be2695c6)</span></li>
<li>plugins/bazaar/bazaarpluginmetadata.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/classbrowser/CMakeLists.txt <span style="color: grey">(c5d61a37811999844ae759c5e97821d52e92ab2d)</span></li>
<li>plugins/classbrowser/classbrowserplugin.cpp <span style="color: grey">(6b4a726fa84626db9295ea4af1a60a9d36570b92)</span></li>
<li>plugins/codeutils/CMakeLists.txt <span style="color: grey">(12c3ce390dfaa62c1fecdff932d1181318622e9f)</span></li>
<li>plugins/codeutils/codeutilsplugin.cpp <span style="color: grey">(3864c943d3e675023bd041f6804ca1e4c1d32181)</span></li>
<li>plugins/contextbrowser/CMakeLists.txt <span style="color: grey">(e2cf7f63c608520a5cd024ca3bcf22549b8200cd)</span></li>
<li>plugins/appwizard/CMakeLists.txt <span style="color: grey">(7fb59bac3396c7b061e0532cb1a4a822ba9fce87)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119972/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>