<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119972/">https://git.reviewboard.kde.org/r/119972/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 29th, 2014, 3:57 p.m. UTC, <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">thanks, this looks good. some nit picks and a question on my side. otherwise looks good</p></pre>
</blockquote>
<p>On September 10th, 2014, 8:22 a.m. UTC, <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">ping? do you plan to ship this anytime soon?</p></pre>
</blockquote>
<p>On September 13th, 2014, 4:32 p.m. UTC, <b>Alexander Richardson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Was on holiday until today without an internet connection, so I couldn't answer earlier. Sorry. I'll try to fix the mentioned issues by tomorrow.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">no worries, take your time :) thanks for working on this!</p></pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 29th, 2014, 3:57 p.m. UTC, <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/119972/diff/2/?file=308436#file308436line31" style="color: black; font-weight: bold; text-decoration: underline;">plugins/git/gitpluginmetadata.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">31</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="c1">// </span><span class="cs">TODO</span><span class="c1">: use object or static library?</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">here and elsewhere: yes, that would be the better approach (i.e. use an object library)</p></pre>
</blockquote>
<p>On September 13th, 2014, 4:32 p.m. UTC, <b>Alexander Richardson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Will update to fix this issue</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">in the meantime I tried to use object/static libs in one place (in kdev-php) and failed, horribly. So don't do this change for now and concentrate on the other changes first so that we can get this in. The cleanup with the libs can be done later then.</p></pre>
<br />
<p>- Milian</p>
<br />
<p>On August 29th, 2014, 2:36 p.m. UTC, Alexander Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Alexander Richardson.</div>
<p style="color: grey;"><i>Updated Aug. 29, 2014, 2:36 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This iterates over all plugins in the kdevplatform/$KDEVPLATFORM_VERSION<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
subdirectories of QCoreApplication::libraryPaths and will then include<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
all plugins that contain "KDevelop/Plugin" in their service types.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This meta data is now embedded directly in the shared libraries, there<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
is no more need for kbuildsycoca and .desktop files.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This means we now require KCoreAddons 5.2 and KService 5.2</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">For testing I converted KDevWelcomepage to the new JSON metadata and it<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
loads fine. If this approach is deemed correct I will convert the other plugins.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It requires https://git.reviewboard.kde.org/r/119970/ to get committed first.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Welcomepage loads fine when opening kdevelop, other plugins are still loaded. It new finds 26 new style plugin and 17 old style ones (from kdevelop since that is not ported yet)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/executescript/executescriptplugin.cpp <span style="color: grey">(a170439a20e85fa660ecd705f1dd0022bd1b7625)</span></li>
<li>plugins/externalscript/CMakeLists.txt <span style="color: grey">(93d459bb0780efe7534d7dfc3e19fe7349192fde)</span></li>
<li>plugins/externalscript/externalscriptplugin.cpp <span style="color: grey">(3d5c8fa3c8c748e5d64c31079c1848bbd2da851e)</span></li>
<li>plugins/filemanager/CMakeLists.txt <span style="color: grey">(2ea0539e588bf58482a219c3000d2e5e4379047f)</span></li>
<li>plugins/filemanager/kdevfilemanagerplugin.cpp <span style="color: grey">(f36b3d3b908a2ba354a2fcf10f90bf3dd4674fb4)</span></li>
<li>plugins/execute/executeplugin.cpp <span style="color: grey">(6a1c30f1792cb094f2f06ca03d64981ed90f97cd)</span></li>
<li>plugins/executescript/CMakeLists.txt <span style="color: grey">(67381f93d4e84aa2b0338c8195d43e14fd92b9e1)</span></li>
<li>plugins/documentview/CMakeLists.txt <span style="color: grey">(9f1483e0b8d5c74c3de13fa989e2e7b995906c5e)</span></li>
<li>plugins/documentview/kdevdocumentviewplugin.cpp <span style="color: grey">(395e1d9d58ec6c2ae5b81a74fa75bd9e372c2f3b)</span></li>
<li>plugins/execute/CMakeLists.txt <span style="color: grey">(8f2e01b86f1e382e45ea5ff6bbce205710a52609)</span></li>
<li>plugins/codeutils/codeutilsplugin.cpp <span style="color: grey">(bf21766fad6a5cb634604bb00c91dd66c3f83425)</span></li>
<li>plugins/contextbrowser/CMakeLists.txt <span style="color: grey">(e2cf7f63c608520a5cd024ca3bcf22549b8200cd)</span></li>
<li>plugins/contextbrowser/contextbrowser.cpp <span style="color: grey">(155da65df82d538f5cf443e782c4bd6cd25a278e)</span></li>
<li>plugins/cvs/CMakeLists.txt <span style="color: grey">(93d6cecd8f52c0b2f4b49de76a5b1661e0432ace)</span></li>
<li>plugins/documentswitcher/CMakeLists.txt <span style="color: grey">(46a779c4cf56f1a4387915dd3d3f030d33b0e284)</span></li>
<li>plugins/documentswitcher/documentswitcherplugin.cpp <span style="color: grey">(7a4c3c17c79e626ed852caae9a697228cff45cb0)</span></li>
<li>plugins/bazaar/bazaarpluginmetadata.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/classbrowser/CMakeLists.txt <span style="color: grey">(c5d61a37811999844ae759c5e97821d52e92ab2d)</span></li>
<li>plugins/classbrowser/classbrowserplugin.cpp <span style="color: grey">(13416c6325d8e282df492e4eee20ef4fbfca6f9e)</span></li>
<li>plugins/codeutils/CMakeLists.txt <span style="color: grey">(12c3ce390dfaa62c1fecdff932d1181318622e9f)</span></li>
<li>CMakeLists.txt <span style="color: grey">(77836881f8a667c86efa883c87921748a42da714)</span></li>
<li>plugins/appwizard/CMakeLists.txt <span style="color: grey">(7fb59bac3396c7b061e0532cb1a4a822ba9fce87)</span></li>
<li>plugins/appwizard/appwizardplugin.cpp <span style="color: grey">(e14b140e9ba4fb195c3d2df214cfc01bb3248a21)</span></li>
<li>plugins/bazaar/CMakeLists.txt <span style="color: grey">(17820ea528abfe0b8b9cb610edddbe00bc5b02f2)</span></li>
<li>plugins/bazaar/bazaarplugin.cpp <span style="color: grey">(c94612cb41453295d16a9500586a256606c6fdc5)</span></li>
<li>plugins/projectfilter/projectfilterprovider.cpp <span style="color: grey">(1ff1ec8a03c817f18e0462fbbf2c6b4fe79977a9)</span></li>
<li>plugins/projectmanagerview/CMakeLists.txt <span style="color: grey">(7720a60477f0074ebeb34976459a8a6db38b941e)</span></li>
<li>plugins/projectmanagerview/projectmanagerviewplugin.cpp <span style="color: grey">(19e487eda653e1de53d47526bedd9d5b84cd7a88)</span></li>
<li>plugins/quickopen/CMakeLists.txt <span style="color: grey">(624513e1cfaa13cd2399f90a5ce76295644fba27)</span></li>
<li>plugins/quickopen/quickopenplugin.cpp <span style="color: grey">(c49df9ddb9e105c5ef77a3b3d59e338654f687b9)</span></li>
<li>plugins/pastebin/pastebinplugin.cpp <span style="color: grey">(1a53d744ea28fb3b2f60c98b6a6b3a820aacf3b3)</span></li>
<li>plugins/patchreview/CMakeLists.txt <span style="color: grey">(02720119fc44770c6ee7a14d1d03184b284db791)</span></li>
<li>plugins/patchreview/patchreview.cpp <span style="color: grey">(0195d372d59571fd8714988bbea73d1ac87c9783)</span></li>
<li>plugins/problemreporter/CMakeLists.txt <span style="color: grey">(25fbdcec795f1cb0c0fe1a3a14fc841a303af766)</span></li>
<li>plugins/problemreporter/problemreporterplugin.cpp <span style="color: grey">(2c44cca3bd76e23333a90f6799042e989e27cb82)</span></li>
<li>plugins/projectfilter/CMakeLists.txt <span style="color: grey">(e922f5c937f17181ad4eb3ca054440df017c85a5)</span></li>
<li>plugins/projectfilter/projectfilterkcm.cpp <span style="color: grey">(5a59115151702573b95000f4b66b351bcca02710)</span></li>
<li>plugins/pastebin/CMakeLists.txt <span style="color: grey">(9d2d4cba0120601fc5b314b056ebd033e6ab69b3)</span></li>
<li>plugins/git/gitpluginmetadata.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/grepview/CMakeLists.txt <span style="color: grey">(84d66cf9634a359b64ec082689258eba286882e8)</span></li>
<li>plugins/grepview/grepviewplugin.cpp <span style="color: grey">(310000a32f00e7736f8fba49bfdd0924fb44b533)</span></li>
<li>plugins/grepview/grepviewpluginmetadata.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/konsole/CMakeLists.txt <span style="color: grey">(2f536b36b062f1caed254c6ef3a9843cbf3453bf)</span></li>
<li>plugins/konsole/kdevkonsoleviewplugin.cpp <span style="color: grey">(ac8a4816a43f73b0feeae5f9a3db19a501748394)</span></li>
<li>plugins/openwith/CMakeLists.txt <span style="color: grey">(407777482ef2c88461716c7290a7310125abcbbf)</span></li>
<li>plugins/openwith/openwithplugin.cpp <span style="color: grey">(b80916232ab451fe0cdcbae3c4c2283444270318)</span></li>
<li>plugins/filetemplates/CMakeLists.txt <span style="color: grey">(f9ba4d437000e08a448c3865f24398d3eb54f164)</span></li>
<li>plugins/filetemplates/filetemplatesplugin.cpp <span style="color: grey">(4fa5a2cb1b65d2822505020c7d7e378d58fec3d8)</span></li>
<li>plugins/genericprojectmanager/CMakeLists.txt <span style="color: grey">(427323c4ebec756801c6a62fa3e284862f00cde8)</span></li>
<li>plugins/genericprojectmanager/genericmanager.cpp <span style="color: grey">(4b563605be98e2a92c6d0d693f218b3ebf110c6a)</span></li>
<li>plugins/git/CMakeLists.txt <span style="color: grey">(35acdea2790646aa1aa2b183043c34b2e10d2244)</span></li>
<li>plugins/git/gitplugin.cpp <span style="color: grey">(9fe04a0c7485371959a476bea0168aba69705c9c)</span></li>
<li>plugins/reviewboard/CMakeLists.txt <span style="color: grey">(9cda85342f725f7968380648a381242313c1930f)</span></li>
<li>plugins/reviewboard/reviewboardplugin.cpp <span style="color: grey">(63c73ca3ccb69e35efd3a35c5d5cf84930001234)</span></li>
<li>plugins/snippet/CMakeLists.txt <span style="color: grey">(2305b7863be1ba0796b91732dda79e74e777cd96)</span></li>
<li>plugins/snippet/snippetplugin.cpp <span style="color: grey">(d9d1a08df3fe0574c69c8f1b54cb8c405adfae3d)</span></li>
<li>plugins/standardoutputview/CMakeLists.txt <span style="color: grey">(38d8cb82a98b9ac19086a17f392f61b2e189635f)</span></li>
<li>plugins/standardoutputview/standardoutputview.cpp <span style="color: grey">(ed9c035d1e15eb4389c2bdbb39a43f06d06ab948)</span></li>
<li>plugins/subversion/CMakeLists.txt <span style="color: grey">(2a31e21165cd05f2537ad9485dcc3fe86f1efd6b)</span></li>
<li>plugins/subversion/kdevsvnplugin.cpp <span style="color: grey">(a87343d511e9515cd82cf3fe693ce36daf07cb59)</span></li>
<li>plugins/switchtobuddy/CMakeLists.txt <span style="color: grey">(382cc20ba503ac5e687c9bc5c920309cc6236aeb)</span></li>
<li>plugins/switchtobuddy/switchtobuddyplugin.cpp <span style="color: grey">(bad7dbba8c56c87ce23a5ea5b513ca30160c0ecf)</span></li>
<li>plugins/templatemanager/CMakeLists.txt <span style="color: grey">(4946c7924d5b24731f25a62bf27294b14fb4b412)</span></li>
<li>plugins/templatemanager/templateconfig.cpp <span style="color: grey">(d7c0371bc44ff81f17e6faf6c0c6408e837d45a5)</span></li>
<li>plugins/testview/CMakeLists.txt <span style="color: grey">(10eec21d9725ed5647fc4dff9d065c592e66e6c9)</span></li>
<li>plugins/testview/testviewplugin.cpp <span style="color: grey">(52b16e4ff4d309f5a9715e44f2b74d5bf27589a1)</span></li>
<li>plugins/vcschangesview/CMakeLists.txt <span style="color: grey">(c0142e8d73ea3175e0fa47823e93ae6a646a319b)</span></li>
<li>plugins/vcschangesview/vcschangesviewplugin.cpp <span style="color: grey">(465635fbdd7ab10ca1b35a9d506a6336e0e5a388)</span></li>
<li>plugins/welcomepage/CMakeLists.txt <span style="color: grey">(34ee3302fadd8a85a66dd2f5b776f0aa09468afb)</span></li>
<li>plugins/welcomepage/kdevwelcomepageplugin.desktop.cmake <span style="color: grey">()</span></li>
<li>plugins/welcomepage/welcomepageplugin.cpp <span style="color: grey">(d24317e7767600d2774972ace8a4f1f708c565d1)</span></li>
<li>shell/plugincontroller.cpp <span style="color: grey">(1acb54b5cd6aad61abbb515bb7b4a6aa536c7d22)</span></li>
<li>shell/settings/CMakeLists.txt <span style="color: grey">(68d346165182db31f293577c1e9ae3869f1e7001)</span></li>
<li>shell/settings/bgpreferences.cpp <span style="color: grey">(c3a8edac80141576707e7af1484262fed6796d10)</span></li>
<li>shell/settings/ccpreferences.cpp <span style="color: grey">(289390e2be6382eaf0950dc4bda85adc99ea540c)</span></li>
<li>shell/settings/environmentpreferences.cpp <span style="color: grey">(95e41d853da3090f69cc0abdd3df8a3de602984c)</span></li>
<li>shell/settings/pluginpreferences.cpp <span style="color: grey">(8d168c8d76a521c28be8cd452be66542875bf5c7)</span></li>
<li>shell/settings/projectpreferences.cpp <span style="color: grey">(9c605a19f459bd7daaa21f6f3184aa57afe60177)</span></li>
<li>shell/settings/sourceformattersettings.cpp <span style="color: grey">(31d5efec5f4512eb6b9a06453038df8f0b89849d)</span></li>
<li>shell/settings/uipreferences.cpp <span style="color: grey">(3bf2e82e5a6202ccba3de862ee6f89c7dacd563a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119972/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>