<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120164/">https://git.reviewboard.kde.org/r/120164/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop and Aleix Pol Gonzalez.</div>
<div>By Kevin Funk.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevelop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">CMake: Make JSON import threaded</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Before this patch parsing the compile_commands.json file blocked the<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
main thread. Make the parsing async instead.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The tests are quite broken right now (due to the refactoring), I cannot really test using them.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>projectmanagers/cmake/CMakeLists.txt <span style="color: grey">(148d9f3743af1b2f9a74ee897d8eaef5809ef5d2)</span></li>
<li>projectmanagers/cmake/cmakeimportjsonjob.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>projectmanagers/cmake/cmakeimportjsonjob.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>projectmanagers/cmake/cmakemanager.h <span style="color: grey">(cc5ea0b205bebaab9e244bee80533aebe276a37d)</span></li>
<li>projectmanagers/cmake/cmakemanager.cpp <span style="color: grey">(ba8746cb0b04a98056cb77b4258fb6de921cbc8e)</span></li>
<li>projectmanagers/cmake/cmakeprojectdata.h <span style="color: grey">(fbe33122be81bb1a5e6eda7273e6ed4c397b841a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120164/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>