<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119830/">https://git.reviewboard.kde.org/r/119830/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Dāvis Mosāns.</div>
<p style="color: grey;"><i>Updated Sept. 12, 2014, 6:31 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">rebase</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Remove deprecated IProject methods. No need to keep them, when KUrl will be changed to QUrl signatures would be different anyway, so just remove now.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tests does pass :)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">but note that KDevelop must also be updated and currently it won't compile against this because it still uses these deprecated methods.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/dashboard/kdevprojectdashboard.cpp <span style="color: grey">(e08b4b4e86265413cda67da0b932763f0d258dd3)</span></li>
<li>plugins/execute/nativeappconfig.cpp <span style="color: grey">(6feee465dcfd4e2fd23ba6fa43865120b5cbd35a)</span></li>
<li>plugins/executescript/scriptappconfig.cpp <span style="color: grey">(6146de42416afe01a2325d1f975f13baddfcacd2)</span></li>
<li>plugins/externalscript/externalscriptjob.cpp <span style="color: grey">(aaef1b3e7ad0b3cc10bfc122ff7bfed54158479a)</span></li>
<li>plugins/filetemplates/templateclassassistant.cpp <span style="color: grey">(4e8604513d48f3170bc4cdf91578a58722e1cfa1)</span></li>
<li>plugins/grepview/grepdialog.cpp <span style="color: grey">(35733f2a7da54a775e9ba34fc297a6b820f94ddb)</span></li>
<li>interfaces/iproject.h <span style="color: grey">(f884642b5033a710d43e7fc7eee1192fb47a245b)</span></li>
<li>plugins/dashboard/dashboarddataengine.cpp <span style="color: grey">(332f1d27218f52d5fff5866d6d6345a4ee16b5f2)</span></li>
<li>plugins/dashboard/dashboarddocument.cpp <span style="color: grey">(2faac45529f342a9304261eba3e1316e1d9b3329)</span></li>
<li>plugins/dashboard/dashboardview.cpp <span style="color: grey">(11233433fb71c804a298ae3947f80cf48504cc2b)</span></li>
<li>vcs/models/projectchangesmodel.cpp <span style="color: grey">(1308b8b12208ab94f0c536af8ee77a91966061bb)</span></li>
<li>vcs/vcspluginhelper.h <span style="color: grey">(7e660163225181869d7f9dffe83285de6e94dfdc)</span></li>
<li>vcs/vcspluginhelper.cpp <span style="color: grey">(883178d3fd5876db039e006165f6fec2daa80cfc)</span></li>
<li>project/projectmodel.cpp <span style="color: grey">(6791c48285a698fffa9eec348e512061e85cca06)</span></li>
<li>shell/documentcontroller.cpp <span style="color: grey">(c03cecda8821d4a19b149505bae5295f54e8d0ec)</span></li>
<li>shell/project.h <span style="color: grey">(59aac113fcfe30b4429313c1dae4352b1e8a8c1f)</span></li>
<li>shell/project.cpp <span style="color: grey">(8dbe26fb744b222430569f0cdeff6f8128cc5720)</span></li>
<li>shell/projectcontroller.cpp <span style="color: grey">(061810a20e88d332f211cd4f3d6f44f54ac49e77)</span></li>
<li>tests/testproject.h <span style="color: grey">(0cc7a2c3d0af329f25f42be3c55dfa790a62c16c)</span></li>
<li>tests/testproject.cpp <span style="color: grey">(362e762ae1e67f674f9c0584c3ccab7b9c6db58b)</span></li>
<li>vcs/models/brancheslistmodel.cpp <span style="color: grey">(f2fbe0dda21deff587575ba4d350762037449529)</span></li>
<li>vcs/models/projectchangesmodel.h <span style="color: grey">(ae6eec5ae26a49fa492dbd9ddf04fdb3e85c7d43)</span></li>
<li>project/projectmodel.h <span style="color: grey">(d157eaa68688235c77d9f955954101b22521d173)</span></li>
<li>plugins/projectmanagerview/projectmanagerview.cpp <span style="color: grey">(8a10e3875d77e6af4d2f74316f6a037dd315e5d7)</span></li>
<li>plugins/projectmanagerview/vcsoverlayproxymodel.cpp <span style="color: grey">(02af4a7a7d95d3177bb8eaff460edd7bd5c2ab92)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119830/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>