<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120104/">https://git.reviewboard.kde.org/r/120104/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 8th, 2014, 10:04 p.m. CEST, <b>Miquel Sabaté Solà</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">IIRC, we're targeting GCC 4.7 and Clang 3.1 (since the release of KDevelop 4.7). In these two cases this should compile just fine, so I don't know why you would want to remove that override :/</p></pre>
</blockquote>
<p>On September 8th, 2014, 10:20 p.m. CEST, <b>Laurent Navet</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I have gcc 4.9.1, and it don't build with :)</p></pre>
</blockquote>
<p>On September 8th, 2014, 10:54 p.m. CEST, <b>Miquel Sabaté Solà</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">gcc 4.9.1 here and it builds just fine :P Are you on the last commit of KDevplatform master. Keep in mind that a recent commit [1] on KDevplatform changed the type of the first argument.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">[1] http://quickgit.kde.org/?p=kdevplatform.git&a=commit&h=cd15efed451a41ac2443812698381a8c4b88bcbe</p></pre>
</blockquote>
<p>On September 8th, 2014, 10:55 p.m. CEST, <b>Laurent Navet</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">here is the error thrown by gcc:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">In file included from /home/laurent/src/kdev-python/codecompletion/context.cpp:23:0:<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
/home/laurent/src/kdev-python/codecompletion/items/functiondeclaration.h:44:18: erreur: ‘virtual void Python::FunctionDeclarationCompletionItem::executed(KTextEditor::View<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">, const KTextEditor::Range&)’ marked override, but does not override<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
virtual void executed(KTextEditor::View</em> view, const KTextEditor::Range& word) override;<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
^<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
In file included from /home/laurent/src/kdev-python/codecompletion/items/keyword.h:22:0,<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
from /home/laurent/src/kdev-python/codecompletion/context.cpp:21: <br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
/home/laurent/kdevelop4/include/kdevplatform/language/codecompletion/normaldeclarationcompletionitem.h:52:16: attention : ‘virtual void KDevelop::NormalDeclarationCompletionItem::executed(KTextEditor::Document<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">, const KTextEditor::Range&)’ was hidden [-Woverloaded-virtual]<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
virtual void executed(KTextEditor::Document</em> document, const KTextEditor::Range& word);<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
^<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
In file included from /home/laurent/src/kdev-python/codecompletion/context.cpp:23:0:<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
/home/laurent/src/kdev-python/codecompletion/items/functiondeclaration.h:44:18: attention : by ‘virtual void Python::FunctionDeclarationCompletionItem::executed(KTextEditor::View<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">, const KTextEditor::Range&)’ [-Woverloaded-virtual]<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
virtual void executed(KTextEditor::View</em> view, const KTextEditor::Range& word) override; ^</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">thank's Miquel, I'll discard and update my kdevplatform</p></pre>
<br />
<p>- Laurent</p>
<br />
<p>On September 8th, 2014, 9:47 p.m. CEST, Laurent Navet wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop and Sven Brauch.</div>
<div>By Laurent Navet.</div>
<p style="color: grey;"><i>Updated Sept. 8, 2014, 9:47 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdev-python
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">remove 'override' keyword to make kdev-python (frameworks branch) build properly</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">just build.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>codecompletion/items/functiondeclaration.h <span style="color: grey">(2e301a5)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120104/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>