<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120068/">https://git.reviewboard.kde.org/r/120068/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop, Milian Wolff and Niko Sams.</div>
<div>By Miquel Sabaté Solà.</div>
<p style="color: grey;"><i>Updated Sept. 6, 2014, 5:27 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Let's use some typedef that are already available in KDevPlatform.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdev-php
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I use the kdev-php plugin at work, so I decided to port it myself. Moreover, this patch depends on the review request #120067. This port is not over though:</p>
<ol style="padding: 0;text-rendering: inherit;margin: 0 0 0 2em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Some tests are failing.</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">The unittestprovider plugin is not linking properly.</li>
</ol>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'll work on this in the following days, but I thought of submitting this patch to reviewboard so you guys can give me some tips and point me to some errors :)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">And yes, this patch is a bit large, sorry about that ;)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">On the works. Some tests are failing.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(7387738)</span></li>
<li>completion/CMakeLists.txt <span style="color: grey">(96746d3)</span></li>
<li>completion/codemodelitem.h <span style="color: grey">(5a30852)</span></li>
<li>completion/codemodelitem.cpp <span style="color: grey">(fce05ba)</span></li>
<li>completion/context.h <span style="color: grey">(dc3bf74)</span></li>
<li>completion/context.cpp <span style="color: grey">(71cd035)</span></li>
<li>completion/implementationitem.h <span style="color: grey">(6f173fc)</span></li>
<li>completion/implementationitem.cpp <span style="color: grey">(d67ea54)</span></li>
<li>completion/includefileitem.h <span style="color: grey">(95282cc)</span></li>
<li>completion/includefileitem.cpp <span style="color: grey">(428547f)</span></li>
<li>completion/item.h <span style="color: grey">(e643ef0)</span></li>
<li>completion/item.cpp <span style="color: grey">(accb1e2)</span></li>
<li>completion/keyworditem.h <span style="color: grey">(03a8357)</span></li>
<li>completion/keyworditem.cpp <span style="color: grey">(58314ed)</span></li>
<li>completion/model.h <span style="color: grey">(9df9d44)</span></li>
<li>completion/model.cpp <span style="color: grey">(ba7d7ca)</span></li>
<li>completion/tests/CMakeLists.txt <span style="color: grey">(2db6e35)</span></li>
<li>completion/tests/test_completion.cpp <span style="color: grey">(3bafd8b)</span></li>
<li>completion/worker.h <span style="color: grey">(c45ae8c)</span></li>
<li>duchain/CMakeLists.txt <span style="color: grey">(3b40524)</span></li>
<li>duchain/builders/declarationbuilder.cpp <span style="color: grey">(9ba4b84)</span></li>
<li>duchain/builders/typebuilder.cpp <span style="color: grey">(a8e7354)</span></li>
<li>duchain/completioncodemodel.h <span style="color: grey">(5ed4799)</span></li>
<li>duchain/completioncodemodel.cpp <span style="color: grey">(96b10e1)</span></li>
<li>duchain/declarations/classdeclaration.h <span style="color: grey">(59c5926)</span></li>
<li>duchain/declarations/classmethoddeclaration.h <span style="color: grey">(976a500)</span></li>
<li>duchain/declarations/functiondeclaration.h <span style="color: grey">(404624d)</span></li>
<li>duchain/declarations/functiondeclaration.cpp <span style="color: grey">(17386d9)</span></li>
<li>duchain/declarations/namespacealiasdeclaration.h <span style="color: grey">(321a2b7)</span></li>
<li>duchain/declarations/namespacedeclaration.h <span style="color: grey">(c6691cc)</span></li>
<li>duchain/expressionevaluationresult.cpp <span style="color: grey">(d89f86f)</span></li>
<li>duchain/helper.h <span style="color: grey">(9b55955)</span></li>
<li>duchain/navigation/magicconstantnavigationcontext.h <span style="color: grey">(1065bf5)</span></li>
<li>duchain/navigation/magicconstantnavigationcontext.cpp <span style="color: grey">(878d1f6)</span></li>
<li>duchain/navigation/navigationwidget.h <span style="color: grey">(eba8be9)</span></li>
<li>duchain/navigation/navigationwidget.cpp <span style="color: grey">(cf2c4f3)</span></li>
<li>duchain/tests/CMakeLists.txt <span style="color: grey">(bf365ad)</span></li>
<li>duchain/tests/duchain.cpp <span style="color: grey">(5d983d4)</span></li>
<li>duchain/tests/duchain_multiplefiles.cpp <span style="color: grey">(ffd48c5)</span></li>
<li>duchain/tests/duchaintestbase.cpp <span style="color: grey">(21dec92)</span></li>
<li>duchain/tests/expressionparser.cpp <span style="color: grey">(17d0bbe)</span></li>
<li>duchain/types/integraltypeextended.h <span style="color: grey">(9043fd5)</span></li>
<li>duchain/types/structuretype.h <span style="color: grey">(2d80be5)</span></li>
<li>parser/CMakeLists.txt <span style="color: grey">(49dbb54)</span></li>
<li>parser/main.cpp <span style="color: grey">(42f2128)</span></li>
<li>parser/parsesession.h <span style="color: grey">(b365a4d)</span></li>
<li>parser/parsesession.cpp <span style="color: grey">(2b11828)</span></li>
<li>parser/php.g <span style="color: grey">(dd0394c)</span></li>
<li>phplanguagesupport.h <span style="color: grey">(6112646)</span></li>
<li>phplanguagesupport.cpp <span style="color: grey">(aab1ba8)</span></li>
<li>phpparsejob.h <span style="color: grey">(8672065)</span></li>
<li>phpparsejob.cpp <span style="color: grey">(6d962ea)</span></li>
<li>testprovider/CMakeLists.txt <span style="color: grey">(95df50d)</span></li>
<li>testprovider/phpunitprovider.cpp <span style="color: grey">(0f87886)</span></li>
<li>testprovider/testdoxdelegate.h <span style="color: grey">(cc2a48d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120068/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>