<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119959/">https://git.reviewboard.kde.org/r/119959/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 28th, 2014, 4:15 a.m. UTC, <b>Sergey Kalinichev</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ok, just retested it. Yeah regarding code-completion it's so much better!<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
But I still see a lot of those: ClangParsingEnvironmentFile::needsUpdate: environment differs, require update: "/usr/include/*<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
messages when switching between files (e.g. working with clanghelpers.cpp then switch to clangparsejob.cpp work here then come back to clanghelpers.cpp), it takes some time to get code-completion/problems back - about 10-15 seconds for me.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
I think it shouldn't be like that.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes, I agree. I'll push this changeset first and try to investigate the rest later.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Cheers, thanks for testing!</p></pre>
<br />
<p>- Milian</p>
<br />
<p>On August 27th, 2014, 8:49 p.m. UTC, Milian Wolff wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop and Sergey Kalinichev.</div>
<div>By Milian Wolff.</div>
<p style="color: grey;"><i>Updated Aug. 27, 2014, 8:49 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdev-clang
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The implementation of ClangParsingEnvironmentFile::matchEnvironment<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
was too restrictive. A "match" should just indicate that a given<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
DUChain is valid for a given environment in principle, not whether<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
its environment is equal (or so I think right now).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Otherwise, we end up creating multiple TopDUContexts with associated<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
ClangEnvironmentFiles whenever the environment has changed and a<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
reparse is triggered.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Properly update environment and modification revision of includes.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Otherwise these files will be parsed over and over again since<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
neither their environment, nor their timestamp is updated properly.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This hopefully fixes the slowness during code completion.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The unit test now passes, but I could never reproduce this:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">commit fccc9b4311abb8f858c18e80348df8d3e09b1ce3<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
Author: Sergey Kalinichev <a href="mailto:kalinichev.so.0@gmail.com" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">kalinichev.so.0@gmail.com</a><br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
Date: Tue Aug 19 21:54:57 2014 +0400</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">Implement ClangParsingEnvironmentFile<span style="color: #666666">::</span>matchEnvironment
Now code completion is so much faster<span style="color: #666666">!</span>
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">so I don't know whether the code completion is now slower again? Anyhow, if that is the case we'd need a different fix anyways.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>clangparsejob.cpp <span style="color: grey">(578d3abbb84671113da43eab9f7bb0401c7f71e1)</span></li>
<li>clangsupport.cpp <span style="color: grey">(7d091eb3873a973ae283dcdafb9551d0fd16d325)</span></li>
<li>duchain/clanghelpers.cpp <span style="color: grey">(6db552dfde667335a145d99852efbb3a74985f50)</span></li>
<li>duchain/clangparsingenvironmentfile.cpp <span style="color: grey">(b7d903c9961beeecaca7438d7f5c96be5394387c)</span></li>
<li>tests/test_duchain.cpp <span style="color: grey">(d0146c92f8a7d878aaca8266d6c3f07b24a60701)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119959/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>