<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119919/">https://git.reviewboard.kde.org/r/119919/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 24th, 2014, 2:53 nachm. CEST, <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/119919/diff/1/?file=307426#file307426line99" style="color: black; font-weight: bold; text-decoration: underline;">debuggers/gdb/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">99</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">install</span><span class="p">(</span><span class="s">TARGETS</span> <span class="s">kdevgdb</span> <span class="s">DESTINATION</span> <span class="o">${</span><span class="nv">PLUGIN_INSTALL_DIR</span><span class="o">}</span><span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">99</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">install</span><span class="p">(</span><span class="s">TARGETS</span> <span class="s">kdevgdb</span> <span class="s">DESTINATION</span> <span class="o">${</span><span class="nv">PLUGIN_INSTALL_DIR</span><span class="o">}</span><span class="s"><span class="hl">/kdevplatform</span></span><span class="o"><span class="hl">${</span></span><span class="nv"><span class="hl">KDEV_PLUGIN_VERSION</span></span><span class="o"><span class="hl">}</span></span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'd opt for a folder structure of the form</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">kdevplatform/$version/</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">or at least put a - between kdevplatform and the version</p></pre>
</blockquote>
<p>On August 24th, 2014, 4:55 nachm. CEST, <b>Alexander Richardson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Okay will change it to kdevplatform/$version/</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Reviewboard somehow ate my previous reply (guess I forgot to press OK before publish), I mean to change it to kdevplatform/$version/plugins for plugins and kdevplatform/$version/kcm. Is this okay?</p></pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 24th, 2014, 2:53 nachm. CEST, <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/119919/diff/1/?file=307427#file307427line122" style="color: black; font-weight: bold; text-decoration: underline;">debuggers/gdb/kdevgdb.desktop.cmake</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">122</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="err">X-KDE-Library=kdevgdb</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">122</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="err">X-KDE-Library=kdevplatform@KDEV_PLUGIN_VERSION@/kdevgdb</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">interesting, why this? could we not simply install the .desktop file into the same folder like the plugins?</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">X-KDE-Library is always interpreted relative to QT_PLUGIN_PATH no relative to the .desktop files. These have to be in share/kservice5 so that kbuildsycoca and KPluginTrader can find them.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">In the future we can use KPluginLoader::findPlugins("kdevplatform/$version/plugins") which no longer needs the .desktop files and instead reads the metadata from inside the shared library (without loading it). This simply iterates over all .so files in the directory and then we can decide which ones to load based on the metadata. Since it iterates over all files in the directory I would suggest having kcms and plugins in different subdirectories.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I think KCMs may still need kbuildsycoca, have not looked into that yet.</p></pre>
<br />
<p>- Alexander</p>
<br />
<p>On August 24th, 2014, 2:20 nachm. CEST, Alexander Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Alexander Richardson.</div>
<p style="color: grey;"><i>Updated Aug. 24, 2014, 2:20 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevelop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Install plugins to a versioned kdevplatform subdirectory</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Plugins still load (after running kbuildsycoca5).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is the first towards using KPluginLoader::findPlugins() which will allow removing usage of kbuildsycoca</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>utils/okteta/kdevokteta.desktop.cmake <span style="color: grey">(b4873440e782c1e38eb6fcfc12429a1fbf6fd601)</span></li>
<li>utils/okteta/CMakeLists.txt <span style="color: grey">(ce2e402d50d68e71f4e15203ecdef0984c32f1a3)</span></li>
<li>projectmanagers/custom-buildsystem/kdevcustombuildsystem.desktop.cmake <span style="color: grey">(9d2aa8b92e65f42eaea17c70fd2abce7fbddea63)</span></li>
<li>projectmanagers/custommake/CMakeLists.txt <span style="color: grey">(0625b06a2613b67a653def424ee8b2e03e2c11d4)</span></li>
<li>projectmanagers/custommake/kdevcustommakemanager.desktop.cmake <span style="color: grey">(64aed5efa78984e98cb0d1d0132141f5797f8770)</span></li>
<li>providers/ghprovider/CMakeLists.txt <span style="color: grey">(9b668e42fda4c6a0bf4d5e87d05c9f474625c72a)</span></li>
<li>providers/ghprovider/kdevghprovider.desktop.cmake <span style="color: grey">(558f8a26e89582046549e95699bd918410c849a5)</span></li>
<li>projectmanagers/cmake/kdevcmakedocumentation.desktop.cmake <span style="color: grey">(c2ae394a45be1cf10d2fa36277c3facc9ea6c6a4)</span></li>
<li>projectmanagers/cmake/kdevcmakemanager.desktop.cmake <span style="color: grey">(daa942389c8e3b09c96a0293b6b2e960c5ec6c1b)</span></li>
<li>projectmanagers/custom-buildsystem/CMakeLists.txt <span style="color: grey">(be186bf79a495c9dfb67b07b2e8c6a60c43b6c97)</span></li>
<li>projectbuilders/ninjabuilder/kdevninja.desktop.cmake <span style="color: grey">(d7bcc24a226d9d2f9a9ec36037277f9e07a6a931)</span></li>
<li>projectmanagers/cmake/CMakeLists.txt <span style="color: grey">(a894120ec150a9893e2dde6be5bee84b8d3ce3c8)</span></li>
<li>languages/cpp/CMakeLists.txt <span style="color: grey">(2fc31ae95f69391e6c0838cf676fe14158db5f54)</span></li>
<li>languages/cpp/kdevcppsupport.desktop.cmake <span style="color: grey">(f3aae87def3e5c7e7b8f559a291e6cbce6502095)</span></li>
<li>languages/plugins/custom-definesandincludes/CMakeLists.txt <span style="color: grey">(5fd7c510f454002c9335a7da1e692358803bb6d8)</span></li>
<li>languages/plugins/custom-definesandincludes/compilerprovider/CMakeLists.txt <span style="color: grey">(af4b8aae0ad7b829925b02594c464e92cb7db832)</span></li>
<li>languages/plugins/custom-definesandincludes/compilerprovider/kdevcompilerprovider.desktop.cmake <span style="color: grey">(b3f9f1fda2a5a69f3bd788ba8cc9c5434a61c432)</span></li>
<li>languages/plugins/custom-definesandincludes/kdevdefinesandincludesmanager.desktop.cmake <span style="color: grey">(764bedffc149b30c8158f1a074aecc9a62e5d7e9)</span></li>
<li>projectbuilders/cmakebuilder/CMakeLists.txt <span style="color: grey">(23fa7bc2a854f1437c9b396125de668afe40d9bd)</span></li>
<li>projectbuilders/cmakebuilder/kdevcmakebuilder.desktop.cmake <span style="color: grey">(72a7b30ee480c49073c22ca8ccdcc7b89978f791)</span></li>
<li>projectbuilders/makebuilder/CMakeLists.txt <span style="color: grey">(cd4fb2ebcd404e4673674be2c881ab4cec53e9d5)</span></li>
<li>projectbuilders/makebuilder/kdevmakebuilder.desktop.cmake <span style="color: grey">(b40f7cfc558703de804c4a4170fbeb24ce087e4c)</span></li>
<li>projectbuilders/ninjabuilder/CMakeLists.txt <span style="color: grey">(6bd40aede43de87ed63e425a83e51686f513e3e0)</span></li>
<li>formatters/customscript/CMakeLists.txt <span style="color: grey">(a6777d03336145e5ece7f668ec99ba665dcef492)</span></li>
<li>formatters/customscript/kdevcustomscript.desktop.cmake <span style="color: grey">(575947d012ae7210968fcc61d2d5a770061d95e5)</span></li>
<li>kdeintegration/executeplasmoid/CMakeLists.txt <span style="color: grey">(ebf593996ce031a3dbe2e896850273a77dca81d2)</span></li>
<li>kdeintegration/executeplasmoid/kdevexecuteplasmoid.desktop.cmake <span style="color: grey">(5c8f9407ac7e9386f1545e4fd535b7eb299418ae)</span></li>
<li>kdeintegration/kdeprovider/CMakeLists.txt <span style="color: grey">(ce472d8d511fde3e7515f0551e97c0ebd52026a3)</span></li>
<li>kdeintegration/kdeprovider/kdevkdeprovider.desktop.cmake <span style="color: grey">(8db895f4ffb8a3e3d18d3935ff5578af3e80699a)</span></li>
<li>documentation/qthelp/CMakeLists.txt <span style="color: grey">(b5a95c6fb9d874601e192762c348d4bcea7ceb48)</span></li>
<li>documentation/qthelp/kdevqthelp.desktop.cmake <span style="color: grey">(62590260b4b181d60b564a9a28b5d8fd8e43d6d4)</span></li>
<li>formatters/astyle/CMakeLists.txt <span style="color: grey">(c73a299a45fc84468a4a223fcfbd9ccb09b68268)</span></li>
<li>formatters/astyle/kdevastyle.desktop.cmake <span style="color: grey">(e27931321ab3f96dd18f9068fe56932255ddbca9)</span></li>
<li>debuggers/gdb/CMakeLists.txt <span style="color: grey">(4f29c1fda4875980d53d5842834caf8f4b228a1d)</span></li>
<li>debuggers/gdb/kdevgdb.desktop.cmake <span style="color: grey">(9c9ee1bc90ac44b51289943ab784ca7e4327fdcc)</span></li>
<li>documentation/manpage/CMakeLists.txt <span style="color: grey">(c58907f2c2973d52ffb88a0aa9ebc97c4150e25c)</span></li>
<li>documentation/manpage/kdevmanpage.desktop.cmake <span style="color: grey">(b31d9a234c413e31f187906caafb4dc22f593df5)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119919/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>