<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119830/">https://git.reviewboard.kde.org/r/119830/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Dāvis Mosāns.</div>
<p style="color: grey;"><i>Updated Aug. 18, 2014, 7:42 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Remove deprecated IProject methods. No need to keep them, when KUrl will be changed to QUrl signatures would be different anyway, so just remove now.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tests does pass :)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">but note that KDevelop must also be updated and currently it won't compile against this because it still uses these deprecated methods.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tests/testproject.h <span style="color: grey">(bbff5a3a193ffbb83d77e55d169082252f177d38)</span></li>
<li>shell/project.cpp <span style="color: grey">(1a4a1c3d54fb84b2c2ce919d3829fcc9ba897f33)</span></li>
<li>shell/project.h <span style="color: grey">(0452dd7273c83696d6709997e2bb81cd9e553a1c)</span></li>
<li>project/projectmodel.cpp <span style="color: grey">(6791c48285a698fffa9eec348e512061e85cca06)</span></li>
<li>project/projectmodel.h <span style="color: grey">(5d77958b08d288a79e9f23bf4d248c3cb3945f7d)</span></li>
<li>plugins/projectmanagerview/vcsoverlayproxymodel.cpp <span style="color: grey">(c478ff8ddce4738222fe82ab8e03c1a54f07cd4f)</span></li>
<li>plugins/projectmanagerview/projectmanagerview.cpp <span style="color: grey">(781cf49a19697744899bcebbc4463e88b7023375)</span></li>
<li>plugins/grepview/grepdialog.cpp <span style="color: grey">(6034191c4257fdbb6a2d6311f07503bb3931f0e2)</span></li>
<li>plugins/filetemplates/templateclassassistant.cpp <span style="color: grey">(4e8604513d48f3170bc4cdf91578a58722e1cfa1)</span></li>
<li>plugins/externalscript/externalscriptjob.cpp <span style="color: grey">(aaef1b3e7ad0b3cc10bfc122ff7bfed54158479a)</span></li>
<li>plugins/executescript/scriptappconfig.cpp <span style="color: grey">(e4e7fbdb13d76ddb524a80dd2ff45c1a30e8ffb4)</span></li>
<li>plugins/execute/nativeappconfig.cpp <span style="color: grey">(ab406e3bb71a53a122d2c9566b0fb8c958b15db7)</span></li>
<li>plugins/dashboard/kdevprojectdashboard.cpp <span style="color: grey">(e08b4b4e86265413cda67da0b932763f0d258dd3)</span></li>
<li>plugins/dashboard/dashboardview.cpp <span style="color: grey">(11233433fb71c804a298ae3947f80cf48504cc2b)</span></li>
<li>plugins/dashboard/dashboarddocument.cpp <span style="color: grey">(2faac45529f342a9304261eba3e1316e1d9b3329)</span></li>
<li>plugins/dashboard/dashboarddataengine.cpp <span style="color: grey">(332f1d27218f52d5fff5866d6d6345a4ee16b5f2)</span></li>
<li>vcs/models/brancheslistmodel.cpp <span style="color: grey">(f2fbe0dda21deff587575ba4d350762037449529)</span></li>
<li>vcs/models/projectchangesmodel.h <span style="color: grey">(ae6eec5ae26a49fa492dbd9ddf04fdb3e85c7d43)</span></li>
<li>vcs/models/projectchangesmodel.cpp <span style="color: grey">(1308b8b12208ab94f0c536af8ee77a91966061bb)</span></li>
<li>vcs/vcspluginhelper.h <span style="color: grey">(596f8a90d76097343ea99175617ce569d33ecd23)</span></li>
<li>vcs/vcspluginhelper.cpp <span style="color: grey">(949b336784391c3f812e8c29eb807aa3d2403c2e)</span></li>
<li>interfaces/iproject.h <span style="color: grey">(f884642b5033a710d43e7fc7eee1192fb47a245b)</span></li>
<li>shell/projectcontroller.cpp <span style="color: grey">(140771bf8547f8faa441e9c9380a5dde850e786f)</span></li>
<li>shell/documentcontroller.cpp <span style="color: grey">(d5e7c3b1c58cc389e1c9fb887e24c5a745efe73a)</span></li>
<li>tests/testproject.cpp <span style="color: grey">(b7530a8cad17be4d983f9bccb513d06feef5f2eb)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119830/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>