<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119795/">https://git.reviewboard.kde.org/r/119795/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop and Kevin Funk.</div>
<div>By Laurent Navet.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=337282">337282</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">rename .cpp .h and target from footest or whatever to test_foo<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
rename class from FooTest to TestFoo<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
adapt headers guardians if needed</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">make && ctest</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">some tests are failing, but certainly due to my setup</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>vcs/dvcs/tests/CMakeLists.txt <span style="color: grey">(da80212)</span></li>
<li>vcs/dvcs/tests/dvcsjobTest.h <span style="color: grey">(3f3287e)</span></li>
<li>vcs/dvcs/tests/dvcsjobTest.cpp <span style="color: grey">(c375840)</span></li>
<li>vcs/dvcs/tests/test_dvcsjob.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>vcs/dvcs/tests/test_dvcsjob.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>vcs/models/tests/CMakeLists.txt <span style="color: grey">(a359493)</span></li>
<li>vcs/models/tests/modelstest.h <span style="color: grey">(bab997f)</span></li>
<li>vcs/models/tests/modelstest.cpp <span style="color: grey">(b23876e)</span></li>
<li>vcs/models/tests/test_models.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>vcs/models/tests/test_models.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>sublime/tests/areaoperationtest.cpp <span style="color: grey">(b99415b)</span></li>
<li>sublime/tests/areaprinter.h <span style="color: grey">(f7911b2)</span></li>
<li>sublime/tests/areawalkertest.h <span style="color: grey">(1fa7eed)</span></li>
<li>sublime/tests/areawalkertest.cpp <span style="color: grey">(d56f06a)</span></li>
<li>sublime/tests/controllertest.h <span style="color: grey">(0b4fff5)</span></li>
<li>sublime/tests/controllertest.cpp <span style="color: grey">(39d527b)</span></li>
<li>sublime/tests/documenttest.h <span style="color: grey">(7d8692c)</span></li>
<li>sublime/tests/documenttest.cpp <span style="color: grey">(36e8c3d)</span></li>
<li>sublime/tests/test_aggregatemodel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>sublime/tests/test_aggregatemodel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>sublime/tests/test_areaoperation.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>sublime/tests/test_areaoperation.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>sublime/tests/test_areawalker.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>sublime/tests/test_areawalker.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>sublime/tests/test_controller.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>sublime/tests/test_controller.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>sublime/tests/test_document.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>sublime/tests/test_document.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>sublime/tests/test_toolviewtoolbar.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>sublime/tests/test_toolviewtoolbar.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>sublime/tests/test_view.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>sublime/tests/test_view.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>sublime/tests/test_viewactivation.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>sublime/tests/test_viewactivation.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>sublime/tests/toolviewtoolbartest.h <span style="color: grey">(7fb95f6)</span></li>
<li>sublime/tests/toolviewtoolbartest.cpp <span style="color: grey">(d2d222d)</span></li>
<li>sublime/tests/viewactivationtest.h <span style="color: grey">(2a3b5b4)</span></li>
<li>sublime/tests/viewactivationtest.cpp <span style="color: grey">(7b15414)</span></li>
<li>sublime/tests/viewtest.h <span style="color: grey">(b6e67b2)</span></li>
<li>sublime/tests/viewtest.cpp <span style="color: grey">(9debb6b)</span></li>
<li>tests/modeltest.cpp <span style="color: grey">(a22b635)</span></li>
<li>util/tests/CMakeLists.txt <span style="color: grey">(896a4ad)</span></li>
<li>shell/tests/testcontrollertest.h <span style="color: grey">(e7d5ca0)</span></li>
<li>shell/tests/testcontrollertest.cpp <span style="color: grey">(de58600)</span></li>
<li>shell/tests/uicontrollertest.h <span style="color: grey">(2481f74)</span></li>
<li>shell/tests/uicontrollertest.cpp <span style="color: grey">(dc8b80a)</span></li>
<li>sublime/tests/CMakeLists.txt <span style="color: grey">(c3d487e)</span></li>
<li>sublime/tests/aggregatemodeltest.h <span style="color: grey">(d5e92b0)</span></li>
<li>sublime/tests/aggregatemodeltest.cpp <span style="color: grey">(0ed7d6b)</span></li>
<li>sublime/tests/areaoperationtest.h <span style="color: grey">(fde0b8c)</span></li>
<li>shell/tests/test_uicontroller.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>interfaces/tests/CMakeLists.txt <span style="color: grey">(d7c68b7)</span></li>
<li>language/backgroundparser/tests/CMakeLists.txt <span style="color: grey">(d97ac73)</span></li>
<li>language/codegen/tests/CMakeLists.txt <span style="color: grey">(844eb90)</span></li>
<li>language/duchain/tests/CMakeLists.txt <span style="color: grey">(84a7ac1)</span></li>
<li>language/duchain/tests/benchhashes.h <span style="color: grey">(f3fabfc)</span></li>
<li>language/duchain/tests/benchhashes.cpp <span style="color: grey">(2da3589)</span></li>
<li>language/duchain/tests/test_benchhashes.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>language/duchain/tests/test_benchhashes.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>language/duchain/tests/test_duchainshutdown.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>language/duchain/tests/test_duchainshutdown.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>language/duchain/tests/tst_duchainshutdown.h <span style="color: grey">(1a47ae7)</span></li>
<li>language/duchain/tests/tst_duchainshutdown.cpp <span style="color: grey">(c1a6323)</span></li>
<li>language/highlighting/tests/CMakeLists.txt <span style="color: grey">(c2710c7)</span></li>
<li>plugins/git/tests/CMakeLists.txt <span style="color: grey">(f3e6d87)</span></li>
<li>plugins/git/tests/gittest.h <span style="color: grey">(4199854)</span></li>
<li>plugins/git/tests/gittest.cpp <span style="color: grey">(ea91a4c)</span></li>
<li>plugins/git/tests/test_git.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/git/tests/test_git.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/grepview/tests/CMakeLists.txt <span style="color: grey">(e6143de)</span></li>
<li>plugins/grepview/tests/findreplacetest.h <span style="color: grey">(309df44)</span></li>
<li>plugins/grepview/tests/findreplacetest.cpp <span style="color: grey">(53255e3)</span></li>
<li>plugins/grepview/tests/test_findreplace.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/grepview/tests/test_findreplace.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/projectfilter/tests/CMakeLists.txt <span style="color: grey">(6c18ff9)</span></li>
<li>plugins/quickopen/tests/CMakeLists.txt <span style="color: grey">(08b94ba)</span></li>
<li>plugins/quickopen/tests/quickopenbench.h <span style="color: grey">(14f01d3)</span></li>
<li>plugins/quickopen/tests/quickopenbench.cpp <span style="color: grey">(912b0ad)</span></li>
<li>plugins/quickopen/tests/quickopentest.h <span style="color: grey">(f0148eb)</span></li>
<li>plugins/quickopen/tests/quickopentest.cpp <span style="color: grey">(0f69a5e)</span></li>
<li>plugins/quickopen/tests/test_quickopen.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/quickopen/tests/test_quickopen.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/quickopen/tests/test_quickopenbench.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/quickopen/tests/test_quickopenbench.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/standardoutputview/tests/CMakeLists.txt <span style="color: grey">(58234c0)</span></li>
<li>plugins/standardoutputview/tests/standardoutputviewtest.h <span style="color: grey">(92ef213)</span></li>
<li>plugins/standardoutputview/tests/standardoutputviewtest.cpp <span style="color: grey">(d48fb84)</span></li>
<li>plugins/standardoutputview/tests/test_standardoutputview.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/standardoutputview/tests/test_standardoutputview.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>project/tests/CMakeLists.txt <span style="color: grey">(ab7fdf6)</span></li>
<li>project/tests/projectmodeltest.h <span style="color: grey">(7301b72)</span></li>
<li>project/tests/projectmodeltest.cpp <span style="color: grey">(1ba4cce)</span></li>
<li>project/tests/test_projectmodel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>project/tests/test_projectmodel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>serialization/tests/CMakeLists.txt <span style="color: grey">(6345328)</span></li>
<li>shell/tests/CMakeLists.txt <span style="color: grey">(a5c3832)</span></li>
<li>shell/tests/documentcontrollertest.h <span style="color: grey">(86462a4)</span></li>
<li>shell/tests/documentcontrollertest.cpp <span style="color: grey">(1edcf4a)</span></li>
<li>shell/tests/plugincontrollertest.h <span style="color: grey">(a318bea)</span></li>
<li>shell/tests/plugincontrollertest.cpp <span style="color: grey">(72ec0f0)</span></li>
<li>shell/tests/sessioncontrollertest.h <span style="color: grey">(3230b09)</span></li>
<li>shell/tests/sessioncontrollertest.cpp <span style="color: grey">(e397e37)</span></li>
<li>shell/tests/shellbuddytest.h <span style="color: grey">(7f92f0e)</span></li>
<li>shell/tests/shellbuddytest.cpp <span style="color: grey">(7ef62cc)</span></li>
<li>shell/tests/shelldocumentoperationtest.h <span style="color: grey">(f70ed6b)</span></li>
<li>shell/tests/shelldocumentoperationtest.cpp <span style="color: grey">(20798cc)</span></li>
<li>shell/tests/test_documentcontroller.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/tests/test_documentcontroller.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/tests/test_plugincontroller.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/tests/test_plugincontroller.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/tests/test_sessioncontroller.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/tests/test_sessioncontroller.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/tests/test_shellbuddy.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/tests/test_shellbuddy.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/tests/test_shelldocumentoperation.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/tests/test_shelldocumentoperation.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/tests/test_testcontroller.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/tests/test_testcontroller.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/tests/test_uicontroller.h <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119795/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>