<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119779/">https://git.reviewboard.kde.org/r/119779/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Dāvis Mosāns.</div>
<p style="color: grey;"><i>Updated Aug. 14, 2014, 10:44 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Fix and enable ProjectController Test</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It compiles, but no idea if it works, for some reason all shell tests (except shell-testcontrollertest) does fail for me with </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">QDEBUG <span style="color: #666666">:</span> ProjectControllerTest<span style="color: #666666">::</span>initTestCase<span style="color: #666666">()</span> kdevplatform <span style="color: #666666">(</span>language<span style="color: #666666">):</span> creating <span style="color: #008000; font-weight: bold">new</span> parsing<span style="color: #666666">-</span>environment <span style="color: #008000; font-weight: bold">static</span> data
QDEBUG <span style="color: #666666">:</span> ProjectControllerTest<span style="color: #666666">::</span>initTestCase<span style="color: #666666">()</span> kdevplatform <span style="color: #666666">(</span>shell<span style="color: #666666">):</span> loading session plugins
QDEBUG <span style="color: #666666">:</span> ProjectControllerTest<span style="color: #666666">::</span>initTestCase<span style="color: #666666">()</span> kdevplatform <span style="color: #666666">(</span>shell<span style="color: #666666">):</span> Attempting to load <span style="color: #BA2121">"KDevCMakeDocumentation"</span> <span style="color: #666666">-</span> name<span style="color: #666666">:</span> <span style="color: #BA2121">"CMake Documentation"</span>
QFATAL <span style="color: #666666">:</span> ProjectControllerTest<span style="color: #666666">::</span>initTestCase<span style="color: #666666">()</span> ASSERT failure <span style="color: #008000; font-weight: bold">in</span> <span style="color: #008000; font-weight: bold">void</span> KDevelop<span style="color: #666666">::</span>DUChainItemSystem<span style="color: #666666">::</span>registerTypeClass<span style="color: #666666">()</span> <span style="color: #666666">[</span><span style="color: #008000; font-weight: bold">with</span> T <span style="color: #666666">=</span> KDevelop<span style="color: #666666">::</span>DUContext<span style="color: #666666">;</span> Data <span style="color: #666666">=</span> KDevelop<span style="color: #666666">::</span>DUContextData<span style="color: #666666">]:</span> <span style="color: #BA2121">"This identity is already registered"</span><span style="color: #666666">,</span> file <span style="color: #BB6688">/home/build/KDE/extragear/kdevelop/kdevplatform/language/duchain/</span>duchainregister<span style="color: #666666">.</span><span style="color: #7D9029">h</span><span style="color: #666666">,</span> line <span style="color: #666666">107</span>
FAIL<span style="color: #666666">!</span> <span style="color: #666666">:</span> ProjectControllerTest<span style="color: #666666">::</span>initTestCase<span style="color: #666666">()</span> Received a fatal error<span style="color: #666666">.</span>
Loc<span style="color: #666666">:</span> <span style="color: #666666">[</span>Unknown file<span style="color: #666666">(0)]</span>
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Note: I've recompiled everything with latest versions from kdesrc-build</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shell/tests/CMakeLists.txt <span style="color: grey">(4ba922722472402d2d6b4c2a2fdaa7e9ac21ecbe)</span></li>
<li>shell/tests/projectcontrollertest.h <span style="color: grey">(ab62203d9edaff6f7dcf8a8fc711871b5e20c847)</span></li>
<li>shell/tests/projectcontrollertest.cpp <span style="color: grey">(99cd453258d67621249712420d761a75b663c264)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119779/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>