<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119757/">https://git.reviewboard.kde.org/r/119757/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ship It!</p></pre>
<br />
<p>- Milian Wolff</p>
<br />
<p>On August 13th, 2014, 12:22 p.m. UTC, Dāvis Mosāns wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Dāvis Mosāns.</div>
<p style="color: grey;"><i>Updated Aug. 13, 2014, 12:22 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">kde4_add_plugin and kde4_install_icons is deprecated so replace those and update to new syntax.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">No warnings for CMake anymore.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/bazaar/CMakeLists.txt <span style="color: grey">(e7bd1585c9796b3f0af8b749d69d83683a93ccc2)</span></li>
<li>plugins/bazaar/icons/CMakeLists.txt <span style="color: grey">(02e3c9ecf2e80622b6cb3a816c89cba556b500a8)</span></li>
<li>plugins/bazaar/icons/hi128-app-bazaar.png <span style="color: grey">()</span></li>
<li>plugins/git/icons/CMakeLists.txt <span style="color: grey">(b60fd9253dfcbf6a8fa9e578989a91cdd3f8051f)</span></li>
<li>plugins/git/icons/hi16-app-git.png <span style="color: grey">()</span></li>
<li>plugins/git/icons/hi32-app-git.png <span style="color: grey">()</span></li>
<li>plugins/git/icons/hi64-app-git.png <span style="color: grey">()</span></li>
<li>plugins/reviewboard/icons/CMakeLists.txt <span style="color: grey">(170ecc74fa280d612765b92ef0a2d8c02be696ce)</span></li>
<li>plugins/reviewboard/icons/hi128-app-reviewboard.png <span style="color: grey">()</span></li>
<li>plugins/reviewboard/icons/hi16-app-reviewboard.png <span style="color: grey">()</span></li>
<li>plugins/subversion/icons/CMakeLists.txt <span style="color: grey">(b60fd9253dfcbf6a8fa9e578989a91cdd3f8051f)</span></li>
<li>plugins/subversion/icons/hi16-app-subversion.png <span style="color: grey">()</span></li>
<li>plugins/subversion/icons/hi32-app-subversion.png <span style="color: grey">()</span></li>
<li>plugins/subversion/icons/hi64-app-subversion.png <span style="color: grey">()</span></li>
<li>plugins/subversion/icons/hisc-app-subversion.svg <span style="color: grey">()</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119757/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>