<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119710/">https://git.reviewboard.kde.org/r/119710/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/119710/diff/1/?file=303713#file303713line164" style="color: black; font-weight: bold; text-decoration: underline;">util/activetooltip.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void ActiveToolTip::addFriendWidget(QWidget* widget)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">163</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">object</span> <span class="o">==</span> <span class="k">this</span> <span class="o">||</span> <span class="n">object</span> <span class="o">==</span> <span class="p">(</span><span class="n">QObject</span> <span class="o">*</span><span class="p">)</span><span class="k">this</span><span class="o">-></span><span class="n">windowHandle</span><span class="p">()</span> <span class="o">||</span> <span class="n">d</span><span class="o">-></span><span class="n">friendWidgets_</span><span class="p">.</span><span class="n">contains</span><span class="p">(</span><span class="n">object</span><span class="p">))</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">prefer static_cast<QObject*>(windowHandle())</p></pre>
</div>
</div>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Other than that, it looks good to me, especially if it's solving your problem (and also removing some weird logic).</p></pre>
<p>- Aleix Pol Gonzalez</p>
<br />
<p>On August 11th, 2014, 9:49 a.m. UTC, Denis Steckelmacher wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Denis Steckelmacher.</div>
<p style="color: grey;"><i>Updated Aug. 11, 2014, 9:49 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Some navigation tool-tips can contain interactive elements, like scroll-bars (displayed if the documentation of a declaration is very long) or QtQuick elements (used in QML/JS). Event handling in Qt5 is a bit special and some care is needed in order to prevent the tool-tips from being closed when the user clicks in them:</p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">No need to handle focusIn/focusOut in the ContextBrowser plugin, the tool-tip already handles that and has more information. For instance, if the tool-tip gains focus, KateView will lose it, but the tool-tip should not be closed.</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">When the tool-tip is activated by a click on it, QEvent::WindowDeactivate is sent to nearly every widget of the KDevelop main window (menu bars, buttons, Kate views, etc). This patch removes support for this event because it is not really needed: if a window deactivates, another one will activate or the mouse will go out of the tool-tip.</li>
</ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Opening navigation tool-tips with a scroll-bar works and the scroll-bar can be used. Quick-based interactive navigation widgets of QML/JS can also be used. The tool-tips are properly closed when the mouse goes out of them or when I alt-tab to another window.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/contextbrowser/browsemanager.cpp <span style="color: grey">(d31df7c)</span></li>
<li>plugins/contextbrowser/contextbrowser.cpp <span style="color: grey">(f9324da)</span></li>
<li>util/activetooltip.cpp <span style="color: grey">(2833c77)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119710/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>