<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119686/">https://git.reviewboard.kde.org/r/119686/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Kevin Funk.</div>
<p style="color: grey;"><i>Updated Aug. 9, 2014, 8:59 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Introduce kdevplatformrepositories</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The idea is to have a separate component that contains all the infrastructure needed for building your item registry.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
Plus, store generally useful repositories here (such as the StringRepository/IndexedString combo).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This helps to decouple IndexedString from kdevplatformlanguage.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>repositories/tests/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>repositories/tests/serialization/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>repositories/tests/serialization/tst_indexedstring.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>repositories/tests/serialization/tst_indexedstring.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>repositories/tests/serialization/tst_itemrepository.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>repositories/tests/serialization/tst_itemrepository.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>repositories/tests/test_itemrepository.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>repositories/itemrepository.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>repositories/itemrepositoryexampleitem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>repositories/itemrepositoryregistry.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>repositories/itemrepositoryregistry.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>repositories/referencecounting.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>repositories/referencecounting.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/classbrowser/classtree.cpp <span style="color: grey">(151a964201d4a7b4fc5add750e49eeb80ee5a6d8)</span></li>
<li>plugins/problemreporter/watcheddocumentset.h <span style="color: grey">(6805a97e48ab5fdd90996715f80f307fd20bf377)</span></li>
<li>plugins/quickopen/duchainitemquickopen.cpp <span style="color: grey">(c4c1576d343f3b580d4ed5bcdeba5919104beb98)</span></li>
<li>plugins/quickopen/projectfilequickopen.h <span style="color: grey">(5e79058496681088a96c9041a492732e809b9cd1)</span></li>
<li>plugins/quickopen/projectfilequickopen.cpp <span style="color: grey">(049d40a3ad2dbf233faf9403aa8ea623dae85542)</span></li>
<li>plugins/quickopen/projectitemquickopen.h <span style="color: grey">(9f723be1b67b44d7318585d532be22d8269eeee1)</span></li>
<li>plugins/quickopen/quickopenmodel.h <span style="color: grey">(f9a0ae3f96d4ff3e697d45e5c0e4cc6630b9daa2)</span></li>
<li>plugins/quickopen/quickopenplugin.cpp <span style="color: grey">(2c937d131bb707043c9006a5e482caeab14619e4)</span></li>
<li>plugins/classbrowser/projectfolder.cpp <span style="color: grey">(1c386dd30347729c5152314698714dd4fe58bd16)</span></li>
<li>plugins/contextbrowser/contextbrowserview.h <span style="color: grey">(4b7f000e8bdc16a662f22e507ff9560190d83376)</span></li>
<li>plugins/contextbrowser/contextbrowserview.cpp <span style="color: grey">(0c3ef2e575c87a69e3c7e4d0aa595d143eac91b3)</span></li>
<li>plugins/grepview/grepfindthread.cpp <span style="color: grey">(c10f4b8a706927adc0dbdaecace31e7ee2dfd110)</span></li>
<li>plugins/grepview/grepjob.cpp <span style="color: grey">(a1dc2fc78e25ffc2ac646690846f62460e2c95da)</span></li>
<li>plugins/problemreporter/problemhighlighter.cpp <span style="color: grey">(46727e8c7c5d01502c5fe8a4525857500d99b87f)</span></li>
<li>plugins/problemreporter/problemreporterplugin.h <span style="color: grey">(88746eb09d9b85c97bcd14149e1d0d4fcdcff134)</span></li>
<li>language/highlighting/codehighlighting.h <span style="color: grey">(6a9730510d1dfd7b00fed4920abc836c793f239c)</span></li>
<li>language/util/basicsetrepository.h <span style="color: grey">(5b4c683c4a2b58d6acdf71164e0f9c7e136149fc)</span></li>
<li>language/editor/modificationrevision.cpp <span style="color: grey">(841d5f379339459103a7a5eb918c640c56a308d0)</span></li>
<li>language/editor/modificationrevisionset.cpp <span style="color: grey">(484511708664cb70d3ea692614824a407bc0b7ac)</span></li>
<li>language/editor/documentrange.h <span style="color: grey">(fc2b1727a85e6bbc4bfcb322bb67e5eed064b20b)</span></li>
<li>language/duchain/types/typesystem.cpp <span style="color: grey">(7727640393276e9eeee2eaa91ea8ab2961f20b00)</span></li>
<li>language/duchain/types/typesystemdata.h <span style="color: grey">(b3c99dfa2242fddcb4cdc6f68214a2feaa6f15d1)</span></li>
<li>language/duchain/waitforupdate.h <span style="color: grey">(37ace42babe977f78526384b7211455711419c21)</span></li>
<li>language/editor/documentcursor.h <span style="color: grey">(04c4866adc731b237d86579ce9c5870a4f4f1808)</span></li>
<li>language/duchain/types/structuretype.cpp <span style="color: grey">(807b706649de70eaf886c0e774c60f7cfa11cff2)</span></li>
<li>language/duchain/types/typerepository.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>language/duchain/types/typerepository.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>language/duchain/tests/test_itemrepository.cpp <span style="color: grey">(6c0bacd0b6f10c52f66b0b6b0959309a26f1754f)</span></li>
<li>language/duchain/tests/test_itemrepositoryregistry_automatic.cpp <span style="color: grey">(e3bba3da52ffab93b9055de7e86dc42d40ab9857)</span></li>
<li>language/duchain/tests/test_itemrepositoryregistry_deferred.cpp <span style="color: grey">(e6c5ab70a1a35e09477efe3be1b392c65d2db852)</span></li>
<li>language/duchain/tests/tst_identifier.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>language/duchain/tests/tst_identifier.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>language/duchain/topducontextdata.h <span style="color: grey">(5313eb0bde7f2572b4f2b8da49703d62cb08ac31)</span></li>
<li>language/duchain/types/abstracttype.cpp <span style="color: grey">(6aeeb955746f5e2f99e04fb5fded5ffb968fa1d1)</span></li>
<li>language/duchain/types/arraytype.cpp <span style="color: grey">(31c371fc3c0ee1ec7be799471f4fe165fca00bb9)</span></li>
<li>language/duchain/types/delayedtype.cpp <span style="color: grey">(affff09e4b8a83524d50201550be84fb0790ba5e)</span></li>
<li>language/duchain/types/functiontype.cpp <span style="color: grey">(7c4a1f6b3265b8ba6958a86ac833f0542981b823)</span></li>
<li>language/duchain/types/indexedtype.h <span style="color: grey">(9dcfe31bc03f18c22fe770f8fdab9ad1e01c2cee)</span></li>
<li>language/duchain/types/indexedtype.cpp <span style="color: grey">(7e5d6f2d31721614e819fd4b8c49f863651f4f74)</span></li>
<li>language/duchain/types/integraltype.cpp <span style="color: grey">(a3309f4c73746b75073622132a88bd91552f307f)</span></li>
<li>language/duchain/types/pointertype.cpp <span style="color: grey">(36260be05437a53cd4d90e4daf8776dc34dd9cb7)</span></li>
<li>language/duchain/types/referencetype.cpp <span style="color: grey">(b5bd5789c3a4aaa13ce6a015958bfe2d5fcb31ed)</span></li>
<li>plugins/classbrowser/classmodelnodescontroller.h <span style="color: grey">(220c93d5f6ff6628f3712dad4cae074761988db5)</span></li>
<li>language/duchain/tests/serialization/tst_itemrepository.cpp <span style="color: grey">(c9f4fdc9294ac73f8c1051cf9f55200877046f8b)</span></li>
<li>language/duchain/tests/test_itemrepository.h <span style="color: grey">(e69de29bb2d1d6434b8b29ae775ad8c2e48c5391)</span></li>
<li>project/abstractfilemanagerplugin.cpp <span style="color: grey">(b9379b92f84118c7345ef637196d5c5d177ab12e)</span></li>
<li>project/projectmodel.cpp <span style="color: grey">(7470429a7d7876f513c90e8dc40ac2131fab47b6)</span></li>
<li>repositories/tests/test_itemrepository.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>repositories/tests/test_itemrepositoryregistry_automatic.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>repositories/tests/test_itemrepositoryregistry_deferred.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/project.cpp <span style="color: grey">(648c391186874ebec024d37977c1bbf759694497)</span></li>
<li>shell/session.cpp <span style="color: grey">(8df96a88b254983558a6770de51e2551af55d6c5)</span></li>
<li>shell/sessioncontroller.cpp <span style="color: grey">(838894850c7999cf1880c7dd1f0db12dc42eea09)</span></li>
<li>tests/testproject.h <span style="color: grey">(f4a59efa3aac7bc21ee5b610e435e8a7942574a3)</span></li>
<li>vcs/vcspluginhelper.cpp <span style="color: grey">(2379709ecb6b1facedc46c02452c743e4159b45a)</span></li>
<li>repositories/repositorymanager.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>repositories/stringrepository.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>repositories/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>repositories/abstractitemrepository.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>repositories/abstractitemrepository.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>repositories/indexedstring.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>repositories/indexedstring.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>language/duchain/tests/serialization/tst_itemrepository.h <span style="color: grey">(ba9e44175bde292215a1c292a63a809c9d061e49)</span></li>
<li>language/duchain/tests/serialization/tst_indexedstring.h <span style="color: grey">(4460fedae9323d64ac2a93a4bac17b0a882c001f)</span></li>
<li>language/duchain/tests/serialization/tst_indexedstring.cpp <span style="color: grey">(c58ace3393d4f105c22d94c720031ffee857372d)</span></li>
<li>language/util/setrepository.h <span style="color: grey">(d4644b2a7565f41d1f4f8757ab34ddfb98fb4958)</span></li>
<li>language/util/setrepository.cpp <span style="color: grey">(f92040152954f8c8b1024ef5cdf91c32d68002cc)</span></li>
<li>plugins/classbrowser/classbrowserplugin.cpp <span style="color: grey">(cba2ddf5a6421399d93760c449eb8d9f440f1a05)</span></li>
<li>language/duchain/tests/serialization/tst_identifier.cpp <span style="color: grey">(5268bd90e20cad6b095a85ca9399cf27230e4b9b)</span></li>
<li>language/duchain/tests/serialization/CMakeLists.txt <span style="color: grey">(82d42ddc613b487506a5365b0923ccd3e82c434d)</span></li>
<li>language/duchain/tests/serialization/tst_identifier.h <span style="color: grey">(045e42431e57156deb524f4ffbacb557318a0e5c)</span></li>
<li>language/duchain/repositories/abstractitemrepository.cpp <span style="color: grey">(1459034a2d55c419cc37e262f4ef0bc5de5f7907)</span></li>
<li>language/duchain/repositories/itemrepository.h <span style="color: grey">(1f5e9064ba7f363858c393e655be82a3163f3cca)</span></li>
<li>language/duchain/repositories/itemrepositoryexampleitem.h <span style="color: grey">(1d3bdef01defef7eaeba0bbd0a8ee9430f8f06f2)</span></li>
<li>language/duchain/repositories/itemrepositoryregistry.h <span style="color: grey">(b1b795bc42b33404610190925eb8f60690a6c739)</span></li>
<li>language/duchain/repositories/itemrepositoryregistry.cpp <span style="color: grey">(aae3e8054be3b284424328eaec6104bdb3a0b2c0)</span></li>
<li>language/duchain/repositories/repositorymanager.h <span style="color: grey">(75d99f33e691d33396f249cc1f9e68f88e308f2d)</span></li>
<li>language/duchain/repositories/stringrepository.h <span style="color: grey">(94ae6b4f5c333a959a5cab75953874b5e2db6f82)</span></li>
<li>language/duchain/repositories/typerepository.h <span style="color: grey">(12285c41713044d19c46017e3f2bcd7ab7f91d75)</span></li>
<li>language/duchain/repositories/typerepository.cpp <span style="color: grey">(323d5a597d2c06f296abea789110cdfa377e76be)</span></li>
<li>language/duchain/tests/CMakeLists.txt <span style="color: grey">(b52d5ba54c418e59e669b091a5ff8870ff53f646)</span></li>
<li>language/duchain/tests/benchhashes.cpp <span style="color: grey">(0bf66acc82495a42c8b6b030c484a3028538e604)</span></li>
<li>language/codegen/coderepresentation.cpp <span style="color: grey">(44792ac1c2c09c3514f4b980d10d4d1f8e06990c)</span></li>
<li>language/codegen/documentchangeset.h <span style="color: grey">(36cd1721811e55e70bf2a6a0549b88bd6d28674e)</span></li>
<li>language/codegen/progressdialogs/refactoringdialog.cpp <span style="color: grey">(1e9ffc88b02b68123ee3a2d97d3b566b3f28ab67)</span></li>
<li>language/codegen/templaterenderer.cpp <span style="color: grey">(30421c17311e144b82aecdf9efc793772a74fe43)</span></li>
<li>language/codegen/utilities.cpp <span style="color: grey">(ee50706d54867d8a440bd7126ce3e590c82d0fe3)</span></li>
<li>language/duchain/abstractfunctiondeclaration.cpp <span style="color: grey">(3a3be14d864ac5e69cadc9df62a3383a492bb14a)</span></li>
<li>language/duchain/appendedlist_static.h <span style="color: grey">(d76ca19757d6bb093cec6341df72508faeb69f4d)</span></li>
<li>language/duchain/classdeclaration.cpp <span style="color: grey">(c1c2fac165a9e35348e2100df3cec643b2d18628)</span></li>
<li>language/duchain/codemodel.cpp <span style="color: grey">(35bde270852b296324db775e17a5982ddb3178a4)</span></li>
<li>language/duchain/declaration.cpp <span style="color: grey">(423555479ec41439f0d232f96e775c3583a4f7f8)</span></li>
<li>language/duchain/definitions.cpp <span style="color: grey">(5b4c38215ef4a2814c2a13a8dc3b05ed3dca3f33)</span></li>
<li>language/duchain/duchain.cpp <span style="color: grey">(9952343b94ada5c76669f7859bc296611490fc8b)</span></li>
<li>language/duchain/duchainbase.cpp <span style="color: grey">(a77428457b9f7f2ca7f90b1e87df0583b8458c7b)</span></li>
<li>language/duchain/duchaindumper.cpp <span style="color: grey">(e87f2242286165c108caf15983cd0066a32b05a9)</span></li>
<li>language/duchain/ducontext.cpp <span style="color: grey">(10d455a682a91a2f815ea18fda12fe5a66fb84ae)</span></li>
<li>language/duchain/identifier.h <span style="color: grey">(292f10d7a47700e595ff56d2a485b091d1381e3a)</span></li>
<li>language/duchain/identifier.cpp <span style="color: grey">(20aec4b330f09d5865b62616416e45916fe59dad)</span></li>
<li>language/duchain/indexedstring.h <span style="color: grey">(8c74c34efabbe368f271b8751eb0a80a5c09479f)</span></li>
<li>language/duchain/indexedstring.cpp <span style="color: grey">(7f2ceb81c2f2b2173b4e2dd9531e50781cfc1e86)</span></li>
<li>language/duchain/instantiationinformation.h <span style="color: grey">(136db1b4e67f4d229de5362e46d80f0188e82ebe)</span></li>
<li>language/duchain/instantiationinformation.cpp <span style="color: grey">(027f6769fe97c01cd027f70fd4146cbb2ad40c03)</span></li>
<li>language/duchain/navigation/usescollector.h <span style="color: grey">(91d00dd5c3313f851f2921ac16fae174fa3072da)</span></li>
<li>language/duchain/parsingenvironment.h <span style="color: grey">(647b8e2174f8b76e80b4742edbd7736e12a33a36)</span></li>
<li>language/duchain/problem.h <span style="color: grey">(e1f56379ce9cc11021137acfa90fa5757ac1a0db)</span></li>
<li>language/duchain/referencecounting.h <span style="color: grey">(c396bca52e483980ec3bdc6d219c744254579c0b)</span></li>
<li>language/duchain/referencecounting.cpp <span style="color: grey">(ab3fc2bccb27951036c1cc7d132f9f7f6a1671ef)</span></li>
<li>language/duchain/repositories/abstractitemrepository.h <span style="color: grey">(51c907ff4dd724593f3c016575e4e5627b920dd8)</span></li>
<li>language/assistant/renameassistant.h <span style="color: grey">(bc898a432b7e020b0c744bea34635ef6c217ba93)</span></li>
<li>language/assistant/staticassistantsmanager.h <span style="color: grey">(4e59e1516716b45423e305ace89c28173b0adabd)</span></li>
<li>language/backgroundparser/documentchangetracker.h <span style="color: grey">(c7d4ba22e6a0a68f830c33e5de007b3f211ee8e1)</span></li>
<li>language/backgroundparser/documentchangetracker.cpp <span style="color: grey">(e84c952bfe942747d7b936de85c62508a2531bb2)</span></li>
<li>language/backgroundparser/parsejob.h <span style="color: grey">(36e79eb9861603ddf53dc310ac18850388bf45b8)</span></li>
<li>language/backgroundparser/parseprojectjob.h <span style="color: grey">(ae23d6da570bbfb5ca34137b8d241d7ae8684150)</span></li>
<li>language/backgroundparser/tests/test_backgroundparser.h <span style="color: grey">(4e5e837e8de524ec536a13edba34c0aa7c455311)</span></li>
<li>language/backgroundparser/urlparselock.h <span style="color: grey">(e0d310922412532a2e898b25088117026142d1dd)</span></li>
<li>language/codegen/codegenerator.h <span style="color: grey">(8f5d57c75233d7dab2da894c5cdc3127f69dae35)</span></li>
<li>language/codegen/coderepresentation.h <span style="color: grey">(605ab845feea78a462e9417114f0dc29b7378f5e)</span></li>
<li>CMakeLists.txt <span style="color: grey">(8ec8e97dbdb8fa295e89a67a7ffc7475b06c512e)</span></li>
<li>KDevPlatformConfig.cmake.in <span style="color: grey">(5eb91a0d6e6d5b01df9341b375aa84723c32e29c)</span></li>
<li>language/CMakeLists.txt <span style="color: grey">(e40eab5d27ea80ddca423e803bd94915113dc9e1)</span></li>
<li>language/assistant/renameaction.h <span style="color: grey">(d613400353d9e68e32ff6419c10a049fd2eb3ccd)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119686/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>