<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119613/">https://git.reviewboard.kde.org/r/119613/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Sergey Kalinichev.</div>
<p style="color: grey;"><i>Updated Aug. 5, 2014, 11:26 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevelop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">IMO it doesn't make sense at all to run "make" to compute include directories for projects that don't use Makefiles. Even if some project managers indirectly use Makefiles and can't compute include directories themselves, then it should be fixed there, and not workarounded by calling MakeFile include path resolver, which btw works only with very simple Makefiles, and as a result, at least for me, it almost never succeeds.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>languages/cpp/includepathcomputer.cpp <span style="color: grey">(792dd71)</span></li>
<li>languages/plugins/custom-definesandincludes/CMakeLists.txt <span style="color: grey">(d1be9a1)</span></li>
<li>languages/plugins/custom-definesandincludes/definesandincludesmanager.h <span style="color: grey">(ac224dc)</span></li>
<li>languages/plugins/custom-definesandincludes/definesandincludesmanager.cpp <span style="color: grey">(fd7b095)</span></li>
<li>languages/plugins/custom-definesandincludes/idefinesandincludesmanager.h <span style="color: grey">(3a6e87a)</span></li>
<li>languages/plugins/custom-definesandincludes/makefileresolver/CMakeLists.txt <span style="color: grey">(6211f3a)</span></li>
<li>languages/plugins/custom-definesandincludes/makefileresolver/makefileresolver.h <span style="color: grey">(a493e62)</span></li>
<li>languages/plugins/custom-definesandincludes/makefileresolver/makefileresolver.cpp <span style="color: grey">(628d37d)</span></li>
<li>languages/plugins/custom-definesandincludes/makefileresolver/tests/CMakeLists.txt <span style="color: grey">(d41f0ec)</span></li>
<li>languages/plugins/custom-definesandincludes/makefileresolver/tests/test_custommake.h <span style="color: grey">(16c05f1)</span></li>
<li>languages/plugins/custom-definesandincludes/makefileresolver/tests/test_custommake.cpp <span style="color: grey">(5a55262)</span></li>
<li>projectmanagers/custommake/CMakeLists.txt <span style="color: grey">(f80979f)</span></li>
<li>projectmanagers/custommake/custommakemanager.h <span style="color: grey">(e230d09)</span></li>
<li>projectmanagers/custommake/custommakemanager.cpp <span style="color: grey">(2f6d2f2)</span></li>
<li>projectmanagers/custommake/kdevcustommakemanager.desktop.cmake <span style="color: grey">(aab7839)</span></li>
<li>projectmanagers/custommake/makefileresolver/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>projectmanagers/custommake/makefileresolver/makefileresolver.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>languages/cpp/includepathcomputer.h <span style="color: grey">(70851a2)</span></li>
<li>projectmanagers/custommake/makefileresolver/makefileresolver.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>projectmanagers/custommake/makefileresolver/tests/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>projectmanagers/custommake/makefileresolver/tests/test_custommake.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>projectmanagers/custommake/makefileresolver/tests/test_custommake.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119613/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>