<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/119328/">https://git.reviewboard.kde.org/r/119328/</a>
     </td>
    </tr>
   </table>
   <br />





<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
 <tr>
  <td>

<div>Review request for KDevelop.</div>
<div>By Sergey Kalinichev.</div>










<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevelop
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">That way it can be reused by kdev-clang</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Added a simple unit test for it.</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>languages/cpp/cppparsejob.cpp <span style="color: grey">(5589a57)</span></li>

 <li>languages/cpp/includepathcomputer.h <span style="color: grey">(25b8ff4)</span></li>

 <li>languages/cpp/includepathcomputer.cpp <span style="color: grey">(f43cb7f)</span></li>

 <li>languages/cpp/makefileresolver.h <span style="color: grey">(cf75f30)</span></li>

 <li>languages/cpp/makefileresolver.cpp <span style="color: grey">(1bb58ef)</span></li>

 <li>languages/cpp/tests/CMakeLists.txt <span style="color: grey">(464a6f4)</span></li>

 <li>languages/plugins/custom-definesandincludes/CMakeLists.txt <span style="color: grey">(becaf36)</span></li>

 <li>languages/plugins/custom-definesandincludes/definesandincludesmanager.h <span style="color: grey">(b53415f)</span></li>

 <li>languages/plugins/custom-definesandincludes/definesandincludesmanager.cpp <span style="color: grey">(29c4c15)</span></li>

 <li>languages/plugins/custom-definesandincludes/idefinesandincludesmanager.h <span style="color: grey">(a077a33)</span></li>

 <li>languages/plugins/custom-definesandincludes/makefileresolver/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>languages/plugins/custom-definesandincludes/makefileresolver/makefileresolver.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>languages/plugins/custom-definesandincludes/makefileresolver/makefileresolver.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>languages/plugins/custom-definesandincludes/makefileresolver/tests/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>languages/plugins/custom-definesandincludes/makefileresolver/tests/test_custommake.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>languages/plugins/custom-definesandincludes/makefileresolver/tests/test_custommake.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>languages/cpp/CMakeLists.txt <span style="color: grey">(bc72ab6)</span></li>

 <li>languages/cpp/codegen/unresolvedincludeassistant.cpp <span style="color: grey">(a8d140c)</span></li>

 <li>languages/cpp/cpplanguagesupport.cpp <span style="color: grey">(719d227)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/119328/diff/" style="margin-left: 3em;">View Diff</a></p>






  </td>
 </tr>
</table>




  </div>
 </body>
</html>