<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119109/">https://git.reviewboard.kde.org/r/119109/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit b3d786bf7def3c8a51618b5b578cdda5d45ce7b5 by Alex Richardson to branch frameworks.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On July 4th, 2014, 12:07 a.m. UTC, Alexander Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Alexander Richardson.</div>
<p style="color: grey;"><i>Updated July 4, 2014, 12:07 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This exposes a few cyclic dependecies, compilation can be fixed by using
a custom target_include_directories() call</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">compiles</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>interfaces/CMakeLists.txt <span style="color: grey">(f5c3a07856e9fd74382a57eb149774c439bba627)</span></li>
<li>interfaces/interfacesexport.h <span style="color: grey">(e06b18fb43c42a2e1ec7340643339c5475d54e39)</span></li>
<li>interfaces/iproject.h <span style="color: grey">(52ac27f6deb5defdb3c610e20280491a6264b01f)</span></li>
<li>interfaces/tests/CMakeLists.txt <span style="color: grey">(1cbdf6c825616176ebbc8c349bdfe760f9a97094)</span></li>
<li>language/CMakeLists.txt <span style="color: grey">(8acec0b645b18f82d8360e4ad17167c85fe7e068)</span></li>
<li>language/assistant/renamefileaction.cpp <span style="color: grey">(2090a5ca86b0fa493d3080b2c35b4309ea8db516)</span></li>
<li>language/codegen/documentchangeset.cpp <span style="color: grey">(4b46986a5bf266f7c66365e76b2b90de44be98a8)</span></li>
<li>plugins/documentview/CMakeLists.txt <span style="color: grey">(f02517be386f42e4bc1868321ad1acf3b6d10f25)</span></li>
<li>plugins/genericprojectmanager/CMakeLists.txt <span style="color: grey">(96e2a65c4b6a256c2fa2479699d4744ceae202a4)</span></li>
<li>plugins/git/stashmanagerdialog.cpp <span style="color: grey">(542e609dc58da7436a23a34672ffb29f981b9929)</span></li>
<li>plugins/projectmanagerview/projectmanagerview.cpp <span style="color: grey">(94b19b711bc094cc0fb6b560e37df76b94330113)</span></li>
<li>plugins/reviewboard/CMakeLists.txt <span style="color: grey">(5990c6662e4f4f63d256c3db66dc9ccb916d9199)</span></li>
<li>project/CMakeLists.txt <span style="color: grey">(d7790eda47483fa2bf253a70c4c5d2f4d7a3d51e)</span></li>
<li>project/interfaces/ibuildsystemmanager.h <span style="color: grey">(241b6965460b5aed1ccc5ca52c0c66567ba45945)</span></li>
<li>project/interfaces/iprojectbuilder.h <span style="color: grey">(b9c0527d22ec62e8148463dd8e0149b4c9578c70)</span></li>
<li>project/interfaces/iprojectfilemanager.h <span style="color: grey">(76c812ae5c8d9c795953eee1983f3dbde896590d)</span></li>
<li>project/interfaces/iprojectfilter.h <span style="color: grey">(e133c22265453e66454afdccd588370238803627)</span></li>
<li>project/interfaces/iprojectfilterprovider.h <span style="color: grey">(431a63367dc32a2346eb12cd5a26955eb467b1c8)</span></li>
<li>project/projectexport.h <span style="color: grey">(d509c8944ccc043f02a03288a7fb6c3d301c05f4)</span></li>
<li>project/projectmodel.h <span style="color: grey">(74402a7880a8ac0e6d8a2dd4e60bd858d848e939)</span></li>
<li>shell/CMakeLists.txt <span style="color: grey">(2eb64278b3c10b6142ac51212b19d2cf7fbc2a11)</span></li>
<li>shell/project.h <span style="color: grey">(a798ef03477015966229456ade7620cd534ec724)</span></li>
<li>shell/settings/environmentpreferences.cpp <span style="color: grey">(c17d1fdf149877f36a6219dfddde4cfdff8093b2)</span></li>
<li>shell/shellexport.h <span style="color: grey">(f057b1479b3dab21887e421cdaf6a40bf1e4a8f0)</span></li>
<li>sublime/CMakeLists.txt <span style="color: grey">(757af87be7e1c5ea9d354f4d9e064eba52e273bc)</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(641f1c789c76bc003c7e1590d43ea88048aee282)</span></li>
<li>tests/json/CMakeLists.txt <span style="color: grey">(12ee68352aecf740b6135bd823ab57c3b2aeaef4)</span></li>
<li>tests/json/kdevplatformjsontestsexport.h <span style="color: grey">(7ed27f8045eb710eae8192f532064387144d40fe)</span></li>
<li>tests/kdevplatformtestsexport.h <span style="color: grey">(8c7539f8aaee771b400316461e5a185b8738cede)</span></li>
<li>util/CMakeLists.txt <span style="color: grey">(bd0f591d2a5ee0ff71c82961e81547cb28ad5a00)</span></li>
<li>util/utilexport.h <span style="color: grey">(223c15c4e621ac6093ba800dd1735ce155865020)</span></li>
<li>vcs/models/vcsitemeventmodel.cpp <span style="color: grey">(d836f0a3b0fa5a849fa152d069d6fce164f8d3ec)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119109/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>