<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119057/">https://git.reviewboard.kde.org/r/119057/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No time for a proper code review just now, but why did you remove the help texts from the dialog? they could be kept, no? I'll do a review of the code later, I hope.
cheers</pre>
<br />
<p>- Milian Wolff</p>
<br />
<p>On July 1st, 2014, 11:55 a.m. UTC, Sergey Kalinichev wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Sergey Kalinichev.</div>
<p style="color: grey;"><i>Updated July 1, 2014, 11:55 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevelop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is needed as it will let us to get rid of the .kdev_include_paths related code from the kdev-clang. Also it'll make it easier to extract the MakeFileResolver in the future.
Also simplified the code.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added an unit test for NoProjectIncludePathsManager.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>languages/cpp/CMakeLists.txt <span style="color: grey">(48f12da)</span></li>
<li>languages/cpp/codegen/customincludepaths.h <span style="color: grey">(1041682)</span></li>
<li>languages/cpp/codegen/customincludepaths.cpp <span style="color: grey">(8e4e41e)</span></li>
<li>languages/cpp/codegen/ui/custom_include_paths.ui <span style="color: grey">(37be9b5)</span></li>
<li>languages/cpp/codegen/unresolvedincludeassistant.h <span style="color: grey">(60a048b)</span></li>
<li>languages/cpp/codegen/unresolvedincludeassistant.cpp <span style="color: grey">(7c3bc49)</span></li>
<li>languages/cpp/cpplanguagesupport.h <span style="color: grey">(e1659ae)</span></li>
<li>languages/cpp/cpplanguagesupport.cpp <span style="color: grey">(79530e9)</span></li>
<li>languages/cpp/includepathcomputer.h <span style="color: grey">(61de3ec)</span></li>
<li>languages/cpp/includepathcomputer.cpp <span style="color: grey">(61c3646)</span></li>
<li>languages/cpp/includepathresolver.h <span style="color: grey">(c9e9d7d)</span></li>
<li>languages/cpp/includepathresolver.cpp <span style="color: grey">(3cffeb1)</span></li>
<li>languages/cpp/makefileresolver.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>languages/cpp/makefileresolver.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>languages/cpp/tests/CMakeLists.txt <span style="color: grey">(68ba233)</span></li>
<li>languages/plugins/custom-definesandincludes/CMakeLists.txt <span style="color: grey">(4dc013c)</span></li>
<li>languages/plugins/custom-definesandincludes/definesandincludesmanager.h <span style="color: grey">(f996a83)</span></li>
<li>languages/plugins/custom-definesandincludes/definesandincludesmanager.cpp <span style="color: grey">(98f32fc)</span></li>
<li>languages/plugins/custom-definesandincludes/noprojectincludesanddefines/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>languages/plugins/custom-definesandincludes/noprojectincludesanddefines/noprojectcustomincludepaths.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>languages/plugins/custom-definesandincludes/noprojectincludesanddefines/noprojectcustomincludepaths.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>languages/plugins/custom-definesandincludes/noprojectincludesanddefines/noprojectcustomincludepaths.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>languages/plugins/custom-definesandincludes/noprojectincludesanddefines/noprojectincludepathsmanager.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>languages/plugins/custom-definesandincludes/noprojectincludesanddefines/noprojectincludepathsmanager.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>languages/plugins/custom-definesandincludes/tests/definesandincludestest.h <span style="color: grey">(1589b78)</span></li>
<li>languages/plugins/custom-definesandincludes/tests/definesandincludestest.cpp <span style="color: grey">(9c421bb)</span></li>
<li>languages/plugins/custom-definesandincludes/tests/projectsgenerator.h <span style="color: grey">(b919ae5)</span></li>
<li>languages/plugins/custom-definesandincludes/tests/projectsgenerator.cpp <span style="color: grey">(5d08a25)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119057/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/07/01/39f48afe-f63e-46a1-ba1f-12a7a0d48a98__kdevplatform.diff">kdevplatform.diff</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/07/01/bf114c23-763e-47b8-a153-70c57b14ecf7__before.png">before.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/07/01/b5cdd3d1-6b5e-4b6a-8075-21f8c9655f8b__after.png">after.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>